Patch Detail
Show a patch.
GET /api/patches/25610/?format=api
{ "id": 25610, "url": "https://patchwork.libcamera.org/api/patches/25610/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25610/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218232220.761254-5-rui.wang@ideasonboard.com>", "date": "2025-12-18T23:22:18", "name": "[v6,4/6] ipa: rkisp1: algorithms: dpf: Simplify YAML key names", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fde55aa0a6763837f03fb63ade26c56bdd14db7e", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25610/mbox/", "series": [ { "id": 5673, "url": "https://patchwork.libcamera.org/api/series/5673/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5673", "date": "2025-12-18T23:22:14", "name": "refactor DPF parsing and initialization", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5673/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25610/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25610/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 421D4C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Dec 2025 23:22:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD24261F5C;\n\tFri, 19 Dec 2025 00:22:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4236F61F5C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Dec 2025 00:22:53 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86A36596;\n\tFri, 19 Dec 2025 00:22:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DOiD8MLK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766100165;\n\tbh=3CK6uMw2KOE4Likz+4ZQPxifnHxjNx2m8j+Tz7bjHOI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DOiD8MLKUO6BQSm8+Jma9lDqqI2QUBF2aHs9h4fVo9S1s/4nGmYC9nB3iP/dS/X+k\n\tMSKR6dqrdIeINVzXZD3suqOILkEV83NUFCrZnOMZICFQCxIAkCNGkxcYsHw2H76Grd\n\tl/fDWJeMAoYxD9tHHgejHyGL6OooZIFFRDWoXmXo=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v6 4/6] ipa: rkisp1: algorithms: dpf: Simplify YAML key names", "Date": "Thu, 18 Dec 2025 18:22:18 -0500", "Message-ID": "<20251218232220.761254-5-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251218232220.761254-1-rui.wang@ideasonboard.com>", "References": "<20251218232220.761254-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename DPF tuning file keys to shorter, more concise names:\n- DomainFilter -> filter\n- NoiseLevelFunction -> nll\n- FilterStrength -> strength\n\nThis improves readability and reduces verbosity in tuning files\nwhile maintaining the same functionality. Error messages are\nupdated accordingly to reflect the new key names.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\nchangelog since v5: Nothing changed\n\n Reviewed-by tags from v5 are carried over (no code changes).\n\n src/ipa/rkisp1/algorithms/dpf.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex ee82dfd2..2c28e38f 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -126,7 +126,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * The domain kernel is configured with a 9x9 kernel for the green\n \t * pixels, and a 13x9 or 9x9 kernel for red and blue pixels.\n \t */\n-\tconst YamlObject &dFObject = tuningData[\"DomainFilter\"];\n+\tconst YamlObject &dFObject = tuningData[\"filter\"];\n \n \t/*\n \t * For the green component, we have the 9x9 kernel specified\n@@ -148,7 +148,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tvalues = dFObject[\"g\"].getList<uint8_t>().value_or(std::vector<uint8_t>{});\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:g': expected \"\n+\t\t\t<< \"Invalid 'filter:g': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n \t\treturn -EINVAL;\n@@ -185,7 +185,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS &&\n \t values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:rb': expected \"\n+\t\t\t<< \"Invalid 'filter:rb': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1\n \t\t\t<< \" or \" << RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n@@ -207,13 +207,13 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * which stores a piecewise linear function that characterizes the\n \t * sensor noise profile as a noise level function curve (NLF).\n \t */\n-\tconst YamlObject &rFObject = tuningData[\"NoiseLevelFunction\"];\n+\tconst YamlObject &rFObject = tuningData[\"nll\"];\n \n \tstd::vector<uint16_t> nllValues;\n \tnllValues = rFObject[\"coeff\"].getList<uint16_t>().value_or(std::vector<uint16_t>{});\n \tif (nllValues.size() != RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:coeff': expected \"\n+\t\t\t<< \"Invalid 'nll:coeff': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS\n \t\t\t<< \" elements, got \" << nllValues.size();\n \t\treturn -EINVAL;\n@@ -229,13 +229,13 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t\tconfig.nll.scale_mode = RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC;\n \t} else {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:scale-mode': expected \"\n+\t\t\t<< \"Invalid 'nll:scale-mode': expected \"\n \t\t\t<< \"'linear' or 'logarithmic' value, got \"\n \t\t\t<< scaleMode;\n \t\treturn -EINVAL;\n \t}\n \n-\tconst YamlObject &fSObject = tuningData[\"FilterStrength\"];\n+\tconst YamlObject &fSObject = tuningData[\"strength\"];\n \n \tstrengthConfig.r = fSObject[\"r\"].get<uint8_t>().value_or(64);\n \tstrengthConfig.g = fSObject[\"g\"].get<uint8_t>().value_or(64);\n", "prefixes": [ "v6", "4/6" ] }