Patch Detail
Show a patch.
GET /api/patches/25604/?format=api
{ "id": 25604, "url": "https://patchwork.libcamera.org/api/patches/25604/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25604/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218140701.83069-1-barnabas.pocze@ideasonboard.com>", "date": "2025-12-18T14:06:59", "name": "[v1,1/3] libcamera: v4l2_subdevice: Remove unnecessary variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b5de4c26d31e0906bed7f16993ae9213e13215db", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25604/mbox/", "series": [ { "id": 5672, "url": "https://patchwork.libcamera.org/api/series/5672/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5672", "date": "2025-12-18T14:06:59", "name": "[v1,1/3] libcamera: v4l2_subdevice: Remove unnecessary variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5672/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25604/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25604/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20C86BD7D8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Dec 2025 14:07:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D26A161F0A;\n\tThu, 18 Dec 2025 15:07:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B61C361A61\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Dec 2025 15:07:06 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78DC11189\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Dec 2025 15:06:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VmIMRScH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766066819;\n\tbh=wxkzOG6KW68GkSj2l/6sEEKc167HLiLva91gSup+qNg=;\n\th=From:To:Subject:Date:From;\n\tb=VmIMRScHKcqzVSLQzf5FwWMdJpdBkxlyfeNoMZqWGUp2U+z2WWBM1P2/1kLOaolFo\n\tM+SdOHkMZ4eSPVtJVuhFlR8GydEeiPZzVFLx/rB1Xz0ESEF3e/QIL85QvICtyvpw19\n\t8TzegzhzMfQjUAeRzZkl1thGJ7NXU9k1UGNEAdjg=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 1/3] libcamera: v4l2_subdevice: Remove unnecessary\n\tvariable", "Date": "Thu, 18 Dec 2025 15:06:59 +0100", "Message-ID": "<20251218140701.83069-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`model` is not used, so remove it.\n\nFixes: 5d2aad02e86d45 (\"libcamera: add model() for retrieving model name in V4L2Subdevice\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/v4l2_subdevice.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 199424600..00205bc72 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -1728,7 +1728,6 @@ const std::string &V4L2Subdevice::model()\n \tstd::regex i2cRegex{ \" [0-9]+-[0-9a-f]{4}\" };\n \tstd::smatch match;\n \n-\tstd::string model;\n \tif (std::regex_search(entityName, match, i2cRegex))\n \t\tmodel_ = entityName.substr(0, entityName.find(' '));\n \telse\n", "prefixes": [ "v1", "1/3" ] }