Patch Detail
Show a patch.
GET /api/patches/25596/?format=api
{ "id": 25596, "url": "https://patchwork.libcamera.org/api/patches/25596/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25596/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-24-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:35", "name": "[v9,23/26] ipa: software_isp: Call createSelfEnumeratingAlgorithm() to statically instantiate CCM algo", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e42ca8d9b968f0f78e3cdf53126b4af3ff15a7b2", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25596/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25596/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25596/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EBA8C32F2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D7D61F6A;\n\tWed, 17 Dec 2025 11:02:27 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9F5361F3A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:02:11 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-47775fb6cb4so39075285e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:02:11 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:02:10 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"r9fUE5Ir\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965731; x=1766570531;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6NGx7nrnGQs63AF6qiiVewUWKS47LzoGmU3o9iY1/W0=;\n\tb=r9fUE5Iri77LzP23ZPTjTGJJFdFS9zt13v/MzJ+OVqj0yWQcRuZixPlbBhzRV0aFeU\n\t8FJ6EmVHZCVm9+d8tjpTBjWMy7HOycuE8u44cJDHo5SjnOzO+lfmruYHfGRY67QZEWNt\n\tCURLYKZngHb5zrtSSq8xggpfzmmAo0S31NhjKGLq/0E9hR8qwEu1zZ82euDyNyht8Doq\n\tDGFfiB8966CoxJ0+iQqtM3fU68aVN1+m9bvLmzmvwcBEGaJ9X3bFMj9+0VbwCC+PeTOV\n\tvv+NVY9wmAoKyQvZMPV0LHp/Y/cLDgqYupSpOcBr4yKHxhsH3XveLQ+BR6VUwoc7v+Cc\n\td+ZA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965731; x=1766570531;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=6NGx7nrnGQs63AF6qiiVewUWKS47LzoGmU3o9iY1/W0=;\n\tb=XEAHIP5LMVgodtQEsAxg9TnNVlHxYC1FV9YU0vb/ycKbbAVpK5iX6SmBXqvDUPtNsL\n\tAhn5OX5Md6IcWyfBj8DPxqx871FI+ludiM+PskLTXpPVRoYXjiAF6iaS5kkE795Va6Kt\n\tCQYR1VlxKeEacXxTn72pfjN5s0ZIDCiXiF2g1Z1SbSTFh3r8DwITf3RmiEiHhTpCtetr\n\tUwzZV77o40B7PPLitu+2IS4DUGbT6Mz1VWa7/qGhxOtOgFmrfi/GcP8rKxdsU0s4+JuC\n\tTJoD9GNvP/+XnoVkOPDC78HW772Z6oG9xBxYGL5ksH1ADf4b1LI7hIYpM7guZUg2Wv2h\n\tYxYw==", "X-Gm-Message-State": "AOJu0YySJVj5Yd+4dZiSuA6w2mZaoWMXXdR/kD6LkGCPI/4zp8zcch8B\n\tBKjm+lHQe9NUjnOkzdy67B2ngtz2we1Cexlm9Aw5UC0IvojF33+i72YYOrT6phPLyVus1IQiaE0\n\tCIpMr", "X-Gm-Gg": "AY/fxX6h1bgT3OldamYxcJOmJ09O7K0fwYVGeAbTVgy8xACC5gpBJhjJsLIioxwJ81M\n\ts02XXPg0X2oOtR+IHYB2NnYICuwTGtjiP/XO54b92Moanjrl7MP9XhfsrlPa7pIC9l2OGBc0QtL\n\tKfnj2ZEhuz4BxjlTXMtqQZnXXuHS/A04aQTyXVmMxUy42mh5+QCKSP30nQHVW5CVTdZ8Yn/UNKC\n\tVnBjUD71gUPgVGAzh7lwMPeay+qGBd76Ivfx3iW0peF6oHzdFYZEQEMwPIkoHdZEeK5txQcYwbs\n\tlqcrY0Zb0+cHWnOlScApyd97oFNykDwaheSvTcde/BdI7JLLySsXLNqdQ1l78gP90zbl5qtWJpS\n\tHgQPXH5aabdx3fzdR2SmhmKCu7OfAjzYz77v2MdDR1WOkyCJMaxvYSkFVWsGdbUhS4ravJjQEQC\n\t1Bs9a6vWq1+e85E+pdHsfgSpQxyOQeBLFujXgprzGVVW0oRBgNkBrf4Mk2mvLueIhZzeo=", "X-Google-Smtp-Source": "AGHT+IFlwf4r5BmtVr0g1MSw2YLt8vFQWbLFjQsVnivkBUhbosqMSGitFn3Sm9zvV627eRrqdbq8RQ==", "X-Received": "by 2002:a05:600c:4e49:b0:477:aed0:f401 with SMTP id\n\t5b1f17b1804b1-47a8f90653bmr160869375e9.23.1765965730867; \n\tWed, 17 Dec 2025 02:02:10 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v9 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo", "Date": "Wed, 17 Dec 2025 10:01:35 +0000", "Message-ID": "<20251217100138.82525-24-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Check the algorithm list. If CCM is not included call\ncreateSelfEnumeratingAlgorithm() to have CCM initialise itself.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/ipa/simple/soft_simple.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 2bbe271d9..cc263dc1f 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -137,6 +137,23 @@ int IPASoftSimple::init(const IPASettings &settings,\n \tif (ret)\n \t\treturn ret;\n \n+\tbool ccmLoaded = false;\n+\n+\tfor (auto &algo : algorithms()) {\n+\t\tAlgorithm<Module> *algoPtr = algo.get();\n+\t\tconst std::type_info &info = typeid(*algoPtr);\n+\n+\t\tif (std::string(info.name()).find(\"Ccm\") != std::string::npos) {\n+\t\t\tccmLoaded = true;\n+\t\t}\n+\t}\n+\n+\tif (context_.gpuIspEnabled && !ccmLoaded) {\n+\t\tret = createSelfEnumeratingAlgorithm(context_, std::string(\"Ccm\"));\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n \t*ccmEnabled = context_.ccmEnabled;\n \n \tparams_ = nullptr;\n", "prefixes": [ "v9", "23/26" ] }