Patch Detail
Show a patch.
GET /api/patches/25589/?format=api
{ "id": 25589, "url": "https://patchwork.libcamera.org/api/patches/25589/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25589/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-17-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:28", "name": "[v9,16/26] libcamera: software_isp: GPU support for unpacked 10/12-bit formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "342a5d142ff84081d2ab4fdc62997e8de3158641", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25589/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25589/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25589/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2430C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1403F61D61;\n\tWed, 17 Dec 2025 11:02:18 +0100 (CET)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 459ED61A5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:02:03 +0100 (CET)", "by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-47a80d4a065so34399635e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:02:03 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:02:02 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"iFVwTFfS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965722; x=1766570522;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=HhtFnWRlGMhahKWMF7YUw5HWUh4rGouum/Sd9bsme4c=;\n\tb=iFVwTFfSrDszGMjEhPZre7AzEyoln26S0l8+1hIy9vSeXi2iFdz02XnTJYqfVBIlrY\n\t7Ts7k8jzFtr/6g/dOrHVS+F31YSVmlNV83xgBdG7jZi5ESI1rBhwnT59iF68FM1P49X7\n\tDd6nNtI//SvK6APQk1o1XQZjbmg8b1WLE5PIwkf3zAA4ReqdIsCApzmO5UjFr/5Khat5\n\tzR5X6Y1Z8GdOSRpMC+X18lTxCyRvtUF/dX3kSGrIEV5A8T811rmskFQx1gVwNsLhKKXq\n\tSmcsHMG5qj3OQgjAjSg0gkCCvuH5PbTGrWudZNkoDMqqaII5joJcJwTRSb1X3YIUnoq7\n\te3Mw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965722; x=1766570522;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=HhtFnWRlGMhahKWMF7YUw5HWUh4rGouum/Sd9bsme4c=;\n\tb=k+KHcEK4+woYbr5a3LMMuuhbO8M5xNFLmpmNRvaChxiD2TLPKT2sYf+hrk5Rat3Q9H\n\tCicPHNNr2TxX3097nE7UFK0xio2WBIDobVsFP9nHaC7fZ2WVlQbzpasvnEdXVRAjIrFd\n\tYFE50rLkWBVOXpokvjKRMMj9RtJYx4E7ArIGGcop/nVLN6YabdMefFrL9h8loBUti+u2\n\tZRAq+ZQyqeWR22IBf9CMze+/4NYFS2TE7+aMzkdKsY/qneQas2bkHWFoc/AVV6erx8xu\n\tFE/s/zp1hi18/xO4ZILRl6bxw/2h9g/EGI0mrsR+NjHgSJJYjt5+8JW/21LAEb8sHQiz\n\tYF7g==", "X-Gm-Message-State": "AOJu0Yxo+uyQm2sVa620xClqsCC7WkP1XxOHj8cQQIXutYMubkYbZR2/\n\tnqARecQYyFprztf54F5+pfcDmcHGCLj2JphobI+kOKc5Mhj7dZelhZ16SHCGLGqQd+gyMtmUOlk\n\tGZL7B", "X-Gm-Gg": "AY/fxX5fAUYWTk9w8LfNaUjQLR1nfnK6UzOMfRs+cTNbWfaG8OnxPZmW9ewwsqv9rey\n\tLQcmCfC+sI2hq8T95wOtQFVv80ezqD3Ax9rgpaCiaTeHKpsZ7cbFI350U7SGR1knJRrNaZ+fLTl\n\t6NvxOx57AG3fbCPHBBZ4zZji1dZUfgRH4wQUKJHY99PjyjtOhxKaZSI2Y91T/fhqVupdMuwohKt\n\to0IgL5dArFHvbeRrXKQeaXTANRE900aDaI81wI9XN0M+jI+zq8grN+kf+dBdPeyYzWfK7TIBSAf\n\tmi03PPv3G1IUChtG4sSVA+/KRlXivvkKqBNnS8LWyCmrXztQjG0SlTd3S539RxhXPpGxsj25fFD\n\t7mRc8Zznjja5ehjI5aINi/pI+hIbSSj4zwQME/hMr7tfciCeedSBeYFspCoxliVgEHNix034zSj\n\tqH9Ff9kDYEqHghjp52CuMPO+NY+UALqRXq+AVTnCkVZpHrZWvtrwyIm0ePArYRN4jbs1M=", "X-Google-Smtp-Source": "AGHT+IG+MBWNlnyRkWB6WvCtr/mb9eU2Pi5slwFy2nlm3x5eGfGYuNmDVHK/Sd6Tca6h9a/kLjzkqg==", "X-Received": "by 2002:a05:600c:4e4c:b0:471:114e:5894 with SMTP id\n\t5b1f17b1804b1-47a8f90da04mr188513975e9.25.1765965722478; \n\tWed, 17 Dec 2025 02:02:02 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Milan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v9 16/26] libcamera: software_isp: GPU support for unpacked\n\t10/12-bit formats", "Date": "Wed, 17 Dec 2025 10:01:28 +0000", "Message-ID": "<20251217100138.82525-17-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nThe GPU processing supports 8-bit sensor formats and 10/12-bit packed\nformats. Support for 10/12-bit unpacked formats is missing, let's add\nit.\n\n10/12-bit unpacked formats use two adjacent bytes to store the value.\nThis means the 8-bit shaders can be used if we can modify them for\nadditional support of 16-bit addressing. This requires the following\nmodifications:\n\n- Using GL_RG (two bytes per pixel) instead of GL_LUMINANCE (one byte\n per pixel) as the texture format for the given input formats.\n\n- Setting the texture width to the number of pixels rather than the\n number of bytes.\n\n- Making the definition of `fetch' macro variable, according to the\n pixel format.\n\n- Using only `fetch' for accessing the texture.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_unpacked.frag | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 114e32058..477e8bbf6 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -41,9 +41,17 @@ float apply_contrast(float value, float contrastExp)\n void main(void) {\n vec3 rgb;\n \n+ #if defined(RAW10P)\n+ #define pixel(p) p.r / 4.0 + p.g * 64.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #elif defined(RAW12P)\n+ #define pixel(p) p.r / 16.0 + p.g * 16.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #else\n #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r\n+ #endif\n \n- float C = texture2D(tex_y, center.xy).r; // ( 0, 0)\n+ float C = fetch(center.x, center.y); // ( 0, 0)\n const vec4 kC = vec4( 4.0, 6.0, 5.0, 5.0) / 8.0;\n \n // Determine which of four types of pixels we are on.\n", "prefixes": [ "v9", "16/26" ] }