Patch Detail
Show a patch.
GET /api/patches/25588/?format=api
{ "id": 25588, "url": "https://patchwork.libcamera.org/api/patches/25588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-16-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:27", "name": "[v9,15/26] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4332d9c2287e66c06675e1d2dd88742998b215e1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25588/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA769C32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 111AE61F4F;\n\tWed, 17 Dec 2025 11:02:17 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB1AC61A37\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:02:01 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-47bdbc90dcaso5943375e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:02:01 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:02:00 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"I+rdohQh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965721; x=1766570521;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=;\n\tb=I+rdohQhnb48j5GwtDjHGq5C04i2iS+y5oGcPRnjdghDRLhNiWbL5zHQyWH/gMMhxp\n\tdRmFtaURy8dj6Qxg0km9H+kVlW9x6C3IADOglE8bXXXShryjM40/060wwc19sYOrFJ1/\n\t+lk3jTSqnvzLIJEPtubQkvOeINXQvy1YIDkFLS+jsKdL6nvNbY8yRG2sRbb8mvvAJMvk\n\t8fV61PB+DqtoAwlJDr7pIYQTAPH4oziRXemZzmGtGnllzzjC5hFWx6ej/zVxPYnKkCRX\n\tO7oVTxgpv5lsanLHJJJQybCce9RS07c397qGpVnlt+5d5nyqY0M7oxWLK3jIaDe2RIFT\n\tgWpQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965721; x=1766570521;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=;\n\tb=A9Y3rwSpg1nM5OanpvMPPH+wJZdsamKpQVlBpiLn2P8+a0pq7bueXdkT+B9Rc0iBWA\n\tSFYZkFK6YPJ6fX4L6Qf+wY9g/3Ry6g9/SlNP+FdQ4Urvz7aNPMZysSnzNpwbyzlet4UO\n\tIpmcP8JuoiNjUphcBdcNJafasp2vMgkQ2F3e2iGAMqethnEGGC7KGh2Wy1hIwHxf4j9a\n\tTCB7fx6PEI5l+RSd/SAKXofECk8UuCyfqlBe36gX4qWX4bk7Uh4u5yMSlH8Dlj3lIkHW\n\tjPPerafqXlyUzt42CvEmMgCehtmJ5XbN5HhNy97IfVERJEXn/mGv0yOQVcL0dbRvYVtf\n\tvYCQ==", "X-Gm-Message-State": "AOJu0Yx+LH8Wv5hgch4BdGEI7KExNOP/vOlDQaKXFl5ONNxDx1npLTny\n\t3fBA4uGKCq10ZjZiE9NTcHnVf69M3nBnt0+zAXBJxhKu+dJ6QeW/UyvWiudm2YMVRaVaeRJVyvY\n\tOZpD/", "X-Gm-Gg": "AY/fxX5suHXjaaUhuw0UXAYsj17a7jXbyTFbmj9+w+hMJxP55sMKObjemGvX2b9tvPr\n\t+r10Iwol904gcthPdBW7GXNdPcOuGrImB8KgM77aRRldR3onmAZHZ43m4/tDsSYEX4kXY35cHOe\n\tR11vAq4iaFjcYqrsQLBqzSwGJCwusxvTvPZVtB0AYb0v20ACiUah3zoCE0XXeBqP2P4XEsUXkPY\n\ty5q83m4yu70yfuuiZYBNszkUWc0GxeQKKxqwLVEqbr6OitVdXwqF+yO2/Ei60Qz61OhthP8WoBb\n\ttuDIZYk7ZxlFOI43ZwTVpaDEhDZfBBENAr5MVFvE9EEUE07awsIiaLzjul+yk8AqtDH5yqCkEjI\n\tDUJQgbiKBuUlfYS4Ug/gNWtYj8Gy4svQMtSwoDUyqRx9XrBlfKyiocBggRCfxQ2Zro/IrIS0Rm+\n\ttLzo6A97vGOytQakk7st4agYsD1ZHDpD3MAvCe+iqqvSeI9vR0GvxZAjk09Iqgl2+YCdM=", "X-Google-Smtp-Source": "AGHT+IEuHVIjI3uI49LaFagDFH6IbZnPoRCd1fUpWHaX48z5VVUNeM7pDMgn2HPO5dhJ0Btva/ZifQ==", "X-Received": "by 2002:a05:600c:8288:b0:477:a1a2:d829 with SMTP id\n\t5b1f17b1804b1-47a8f8c0caamr165081045e9.13.1765965720968; \n\tWed, 17 Dec 2025 02:02:00 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 15/26] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static", "Date": "Wed, 17 Dec 2025 10:01:27 +0000", "Message-ID": "<20251217100138.82525-16-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurrently CPU ISP supports more diverse input and output schemes.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex ecc4f9dd0..67df2b93a 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -97,8 +97,8 @@ private:\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n", "prefixes": [ "v9", "15/26" ] }