Patch Detail
Show a patch.
GET /api/patches/25582/?format=api
{ "id": 25582, "url": "https://patchwork.libcamera.org/api/patches/25582/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25582/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-10-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:21", "name": "[v9,09/26] libcamera: shaders: Add support for Gamma", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b84f0f5b603856659bfecac8e4eaaab2a6d7aa8", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25582/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25582/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25582/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81D5AC32AF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 037C361D64;\n\tWed, 17 Dec 2025 11:02:06 +0100 (CET)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9017E61A36\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:01:53 +0100 (CET)", "by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-47a8195e515so45229425e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:01:53 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:52 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cVscKM/w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965713; x=1766570513;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=cVscKM/wCKvJFUVK5ppjBtSmlzVPnwFzuOtRowv78mP35qlpYYh6E/o7VM6Ph9VpSz\n\tAgkUL1dUlCWqaNZevlC6W03TICFb5XQbJt4+SHyQBNvAClpt+xaW+wL8I5P3Dc3fOjIF\n\tgo43CNc6o3DGSY0Y9a+d+z1vwoKi8Q2V2xt9bTFTPx9vrhKmjzDpMYzyJ4XbD5PSTnMM\n\tMcE5LcuufD3Qh2oN/jGtAmqENb/HAJusR7SQDzYch7sp8p5eb/5FwFxgW/xAl6zxmlsM\n\tYV4yml9WxodzIx8dnZ03vCPxqeqzm6i3rkZtSL4Ax+XCWu5vEn7BUB+Jb4cd4DR/ihM5\n\tk3xg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965713; x=1766570513;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=gC9mAKwXpVLD8Pk+0cVLkIPLq0J0GXR28kxZD9R2c+u7XqTW2rnVWFKSd2JAlEu3CT\n\t88VVzpcX6IBOPYw0aF8OB0wr9b/gEROFMJVHDKly3ruQo1PSDVZ00qIBDLFdTDUaGQkc\n\t52Eii2snQfLaysqjK/YL3bBJoy/H8HZeGeSgETUJbOnIPEOy5QKIaiyC6FbezUq0NYIT\n\tz0WwW+TOth0zj+4Awg7WioeN0LyWN/s+YMPy5HfEZtoDn8qrWKLRdLsrMAU1iYVrkJnL\n\tjHgvNtJq+tkgP60ID5GHWd09wYyyHlzJZ7dw4D11qgpa8EHTucOD3t0auIF4dK7XvM6g\n\tRqwA==", "X-Gm-Message-State": "AOJu0Yy3jax0DZC875/n8APHAU4uamKKO6cHeaKAzkjD28V84KzA1doK\n\tsP58ZAwIvzdI4xOCJt5pigdamlt1qb52Axo4ca1EHC9FhUbQvJfWAztqnCQBi8fQQMBM9z3Y0d4\n\t3cr1/", "X-Gm-Gg": "AY/fxX5227xr6LvdmD8irZUg/f3GqNQCUDSUUHk5bl6oiCaDRd2v/N7O9Fpm+y7xvty\n\tz6ETBrvq20rkBQnVdeLKQiQdnxYdSB7AlXHROjj0DAiX1Xfzjh/9Trd4mS8lYDA6EaoE+kJs7bu\n\tD4sdCAX+fT3LsLrDKqp366z+npbk4IYIlcQ2NHXdncvacrZDAC3qyA16MlDj6QsrMpcaYfamil2\n\tloF/MR+MpoiVN9mWD2h/dHjeVbI/cNPXkbzRTqMijIsfBoKuUgjFH5gu7RhjdokY4MN62Frp/FY\n\tU3UXJDzWu4FAuqSKjPrwEsfTdVEi0UAUpKmukKF4RBFx28wQ3j8koBJkUPfSLQ/f9a1vO5xsSQ9\n\thr+XaoaPfydjkInlvvzXDdM3rCqH/jKP1I0yxUMZwpVEnQNeI94kVHhPR0OFqKezbXWxWWVFzK8\n\tO8DgxtpdYmpupvXSz4HqeviqD67eDEFW7HXzC7mbh4X+HJwpSw/NcpDGkvA9MbkYbIGm8=", "X-Google-Smtp-Source": "AGHT+IGT+CwgvaidH/6C7tpMUBsaACFuTtFglAX2FPTKT1yXK+w++FjF+HHhb5YwSBDY6AvUBBwIJg==", "X-Received": "by 2002:a05:600c:6290:b0:477:63db:c718 with SMTP id\n\t5b1f17b1804b1-47a8f8ce390mr222333985e9.16.1765965712753; \n\tWed, 17 Dec 2025 02:01:52 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 09/26] libcamera: shaders: Add support for Gamma", "Date": "Wed, 17 Dec 2025 10:01:21 +0000", "Message-ID": "<20251217100138.82525-10-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add gamma compensation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 7036fe278..77d9fbfa7 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n uniform sampler2D tex_y;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -260,6 +261,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n \tgl_FragColor = vec4(rgb.bgr, 1.0);\n #else\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex f0d8cd1e2..aba11a87f 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -26,6 +26,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -155,6 +156,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n gl_FragColor = vec4(rgb.bgr, 1.0);\n #else\n", "prefixes": [ "v9", "09/26" ] }