Patch Detail
Show a patch.
GET /api/patches/25580/?format=api
{ "id": 25580, "url": "https://patchwork.libcamera.org/api/patches/25580/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25580/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-8-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:19", "name": "[v9,07/26] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c8fe7f0d90359367374670fccaad26c63fe1bcac", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25580/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25580/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25580/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06DC7C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AD1E61B0E;\n\tWed, 17 Dec 2025 11:02:02 +0100 (CET)", "from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D40F61A3F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:01:51 +0100 (CET)", "by mail-wm1-x341.google.com with SMTP id\n\t5b1f17b1804b1-4777771ed1aso42310815e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:01:51 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:50 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ZS3f5+7w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965711; x=1766570511;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=ZS3f5+7wA3N6QBoKyQuSG20kLtZ97PuFqu/dDszf/2fAqe5ag6OlZ9WiDFceO9YTrk\n\t+0Yw8EEKCZ2lwvWHFf3YNkSQY/16Chz8bOZT2ESV49zoQA3CcyQ0GysJ9B94BbvmlZQp\n\toPVvlTtQBXupfY7FkTiCbbelVcT800MlpxUzHtpw3AoqXlbld13PtY1b3lIYSjUC8S8H\n\t2TEIEfUoJ0pVlJ/+c9MW6ffMjywGr3KbfVE2X580mZnR18qn0L7jb9CCmvXlxGibDJ7K\n\tGsx0WI66CjAT98jnJJwOAlHvCXkWpm3gFxW/fke5X7MXAmvGMz5jqEbrPfCAUMfJr2Lb\n\t7J4g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965711; x=1766570511;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=nm5pslPUX0BZb3c2gP7YJK+uuWKu0gSGZKz0DtKFJQ9ZlhSsVgE4HxQ0JuJN/52pus\n\tpr/cUahfRxNZcmSW7YVy2O0kGOZd2Dns+7BOKD++7KNm9GBj55ioRT4ht3IwxHQbt7XV\n\t/LbzdNRqWp7ELjBgbDlwkAEev4Bq07vgP99cuNU/rfz2CzFtM5SlPPIq+DSNbGr/QTd8\n\tJnAuV2Mq1OGHhlZb2mTw1QPNSC06HGy1vtqB60QluHpHKO8XPKc/QTr86mZ4mI9KNTeO\n\tNTEMNQFyOpf9Kg/B43ALkr+GhR6tOvclLe/aI6UXB8MzfaCteHfSU03+XF1g9TYoc05R\n\tJVnw==", "X-Gm-Message-State": "AOJu0YxMZIFw+fBVm8kjyQ4FwwN8bDo6lvRp+TMVnnb6khksMP7ZwJQh\n\tYWVYhrswif8FPb9GWr4uvUMV2B5OIi9+k2B0HyXN0PP3vmtMuT7dXz/qyW5txJNTNPDjfvhcVnK\n\tFJxS0P3o=", "X-Gm-Gg": "AY/fxX6b1o/N7MSCAlypsH0Yl2hL+gXadkqcsNP6FQl/I0qGbmn1+IRwXzxecZTpqdd\n\tCCxOUEcPK+RXjJA/ZsIILHjnPxa2Ne/yKRrA42+5+YzWGABF7RvwkLs3vAsy7uI5Iy1aYL3eq60\n\t2uzg7Z57QRC7ArGHAyo7o43Ulk/IVBCvpP5VugZQO+ceBSl08ux5RiqtnVyKb5VEO9R8TPghOsU\n\tVFOW3rNnrqhCFCHlaU8lXjQwE1NqzZKkabt0Fs2NgFe0z1flQpeaPXRKYLxx4Ic06AOQtOT8meb\n\t2HWnJ+ObxTSh7ZYql38Pyr77a/F/6z3EsjyueTvWjXm/0uXJS7DYbCMGTji7GNra4RAmp/Lh5/U\n\t/tgt/Da3GCUWV37AnQ5rQyfy5oIWVoL1h4mNOMKHxbYlLYtDS9xG10zae0CDYPJuTx4LODjEHks\n\tHOzE845bmXgz7OIxJJbbZm51VOyPNw1Ts5lRrKi1U7asN6Y1tdaEeRn1M9p3/AP8m53x6o7QvJX\n\tqH6/A==", "X-Google-Smtp-Source": "AGHT+IHltAJSRMoZ/fQAsJFX2wyo7j87D4uDCaJMocqwCmIr9Wqa6eLKHWAuwlImXlqYro69upaP0A==", "X-Received": "by 2002:a05:600c:548f:b0:477:994b:dbb8 with SMTP id\n\t5b1f17b1804b1-47a8f8bd84amr160597375e9.11.1765965710745; \n\tWed, 17 Dec 2025 02:01:50 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v9 07/26] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Wed, 17 Dec 2025 10:01:19 +0000", "Message-ID": "<20251217100138.82525-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 171a928c2..db8c2a0b3 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -257,5 +257,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex c41d72f4f..06d80f3dd 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -152,5 +152,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+ gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+ gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v9", "07/26" ] }