Patch Detail
Show a patch.
GET /api/patches/25577/?format=api
{ "id": 25577, "url": "https://patchwork.libcamera.org/api/patches/25577/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25577/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-5-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:16", "name": "[v9,04/26] libcamera: shaders: Rename bayer_8 to bayer_unpacked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "35a6d78fdb97510d821282384ecb89af3e2b1926", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25577/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25577/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25577/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72450C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:01:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B0E461A5B;\n\tWed, 17 Dec 2025 11:01:54 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56EC761A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:01:47 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-477aa218f20so37293435e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:01:47 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RwWOmEhZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965707; x=1766570507;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=IkJAuqeYrqHSkFYcCTDfg5+OJJh/GJhI6Eleh7WU2G8=;\n\tb=RwWOmEhZ6UB4QM3KhH9vQdpSOo3oyGd4/y3gSg8NL6sAQjxpFxbW7vNhNw0dwlv5to\n\tcUGa5KZlnIY6P1z/Bx8XtSQZVOK2kuWkJ8xMX6LSdKLcQqMVarihYadHm3fuFXXkI0G4\n\t6Wc5grcmcpiOx3BQa2Hme30/tNppCbJDzhnHIl+W2KsUNd67bRUwHHDCqY4yBfTvIIkl\n\tSIOXeJo1XYx9raqt6Av2ZGdRusxubwJHxVhZgrwCOcP2KrbMvcfdCanjdr4uYVAKcCs5\n\to3bALQutFPhrcYJx7po2m1dTQ+jyJKVFkpFsjrFeLZXl3biRCAXM4aWl82t8DQprSiqg\n\t6jMA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965707; x=1766570507;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=IkJAuqeYrqHSkFYcCTDfg5+OJJh/GJhI6Eleh7WU2G8=;\n\tb=XFOJjRPxMet2FD5ukSjm9pn4uWOkXlp13nsd9avizTLszYJ9enbdLe3NXCxt0N1wVm\n\tXaw0aay/MFHp34zSK6mwVC8noqCwuOc51SNrYlt44+cxbRRk3PO/wPa6lNe8xL5USiek\n\t+zdpTyu1PJcB++k6BXT+CWSCjAMda21EF7NIOY2fpru5LL4jEvCNP9aDkNgUrvc77fff\n\t3kX29SbuNaYB5Eo2cVx7QzzYWwA03kvp1HiVs+cgbkkKxN8daaNZoqkSaa59vaLQj0fz\n\tx1ZSrw0TmUvK2Q1IlZcS6YS8nOHwyF498wPdIb1uDQvv4u+OF3k+JnOPLToKFmJG0S3v\n\t10ZQ==", "X-Gm-Message-State": "AOJu0Yz2DHWJcRiw7UQmRje53skhzt4do2x+znqn48iXouVEJ7niQJtd\n\tFS39vo0eulyNVs+dn/M6x5GjKhyyNWg9WaY8e8XdksacRsmXyt9ZgBWfeODxdAiro+lM7aF3WpZ\n\tKg09v", "X-Gm-Gg": "AY/fxX6odvXs6HrEkZ5ZfpDl0Z47Zea3zxVLY1m92qDdhKwV2YC1rh0S9c5RgY4aYHB\n\tyE6AhGc9phD95x/G5mykGbpfDDnGpF0L4FcppNlrG7+HHb0vBP8TxmHx6oAzJuzWAa/aK3uxnb1\n\txwPvsXuQ1oDJ5pFKbWBrpb7XRxnlUa3F7J2d9WtyWevmyK02IUOfyRVoC4+XCSKqy82zagc1P4/\n\t6D+wXK9iu8SPwh2faZvFRXdeW98ZvOJ6z3RryC6WrWBF87pzRIbFY2x87tmvqkgB5zDUuir9Ra7\n\tEk9U85c/x576g2rt7g84EJ1j6vK0+60QSxdjDUge2KKyanG21exlDaibMgV9VuQBmrrBUkcaT9i\n\tYTrAl/oNanFsgy3VH0jvWEvcfoOeqYbUiybYr7uviGD+bQFid8K1r5BCrffaXO7rG2pauEAQ9eu\n\tqjpf1/gzASYtlERAeDqmfspoPCw/g0ZAQy8QbpuHQn9uDS32+KRAh0DwLLQ9NI+QTz1FJ4/574O\n\tLLlMQ==", "X-Google-Smtp-Source": "AGHT+IHdlmgm8g6MDlSgIC5JoC0PP8rGUZFJaH5lIRe5XSBfD3E7shwSAro3PxYnBZG1hVFQrabfNA==", "X-Received": "by 2002:a05:600c:1c2a:b0:477:6d96:b3c8 with SMTP id\n\t5b1f17b1804b1-47a8f905313mr190061065e9.23.1765965706612; \n\tWed, 17 Dec 2025 02:01:46 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v9 04/26] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked", "Date": "Wed, 17 Dec 2025 10:01:16 +0000", "Message-ID": "<20251217100138.82525-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)", "diff": "diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t<file>../../../../../src/libcamera/shaders/YUV_3_planes.frag</file>\n \t<file>../../../../../src/libcamera/shaders/YUV_packed.frag</file>\n \t<file>../../../../../src/libcamera/shaders/bayer_1x_packed.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.vert</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.frag</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.vert</file>\n \t<file>../../../../../src/libcamera/shaders/identity.vert</file>\n </qresource>\n </RCC>\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 4698c5aac..47f41350e 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n", "prefixes": [ "v9", "04/26" ] }