Patch Detail
Show a patch.
GET /api/patches/25574/?format=api
{ "id": 25574, "url": "https://patchwork.libcamera.org/api/patches/25574/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25574/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-2-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:13", "name": "[v9,01/26] libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a2f2a7c0b58f0a9de8c6e623f6040632367d868b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25574/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25574/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25574/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 366D4C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:01:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8087461A37;\n\tWed, 17 Dec 2025 11:01:45 +0100 (CET)", "from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4810161A2C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:01:43 +0100 (CET)", "by mail-wm1-x341.google.com with SMTP id\n\t5b1f17b1804b1-477a2ab455fso59485825e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:01:43 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:42 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RmSrsvWH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965702; x=1766570502;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dZHtM5rS1+WasttTnOa/hgF19f8pxm9uPEY0c2MJV14=;\n\tb=RmSrsvWH9jgiRhMvEn5xbNVHx/Mro0LxV77n0Le01NLG4cZpn8EAFFTI5YB4aRWjEl\n\tC/6OQ0Va8PqP6BA0Z1YzEIOv+cF8xAgVFteINuQpCEWk74MAA0EpUyoNipvCPlePyL64\n\txccokET6dUGN3pbaMMDSaP11t7hqsbVeWIz6HV4P96n/NdGn/RS1LcGt97BhXkmryBw4\n\t1MVDMWCBPrUUn+FKmqlB6T+HZpT9DJqlm+OiEzplzw3feMZZWqJZfwDmcMn1ZxlVOahE\n\tWbSWb1f3H8L8HcatTgnnE2aDYTCZubYYaSFuMq4aZGtKluiI0Q4TNBO3X4wGmGwtpQxg\n\ta4Sw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965702; x=1766570502;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=dZHtM5rS1+WasttTnOa/hgF19f8pxm9uPEY0c2MJV14=;\n\tb=wpmbApgdoGkJCRgP1rcPwxedqKBBzZ0IjILtsjWhTEqTl1vbMfrB53VNLAl2jceLaJ\n\tKXcY1dgzyTkrhum8DcMbsY78Vx7BB/xsb1EWaw9uIm/oEuH8K9KvUzosR6PKpAr0TTkl\n\tPmCGzbHMxacbhv3k48N6i0CCYTIhNEOgvWri/aD/Is/d8ypgoEQHstcdLu3DUFaaMR79\n\twrhLOpzFGQMGvkfepfeYGrt0Pf/PPlzMfZ+Vji8QhCCFeEX3f5AjcSdor0Iap5rslFGK\n\tehslBxmaSUbmTqK0WKonNIwT85yhMXhbbfC7Ksrwkc4asNUcv1URWzzYPbJDYWbRsMCi\n\tqK+w==", "X-Gm-Message-State": "AOJu0Yworxukr4t214YnLXsIvOdJONnxPrty4ld8ROyM8LlVcYB4EwwW\n\tOEQYtUw8g2MGP9qfg+R1QMgZzV5tCA2MlWg4/zcy8oPZpe4SozMPKpZmfiVgbKaUEjucbmy7JLj\n\t8nlL72Gg=", "X-Gm-Gg": "AY/fxX4CJ/wwPxD0nqtDPW2itw3Oe3k5B6NeET/PGyckJWTNWOQQgt2voU2lUVTt3PA\n\tZDluvf1VyxYehPmD1FNzM1IL/0QRpo89bZ6+OvLmxtjL4BrCRIab/alPQ2ed0sV0NESPM4inBUq\n\tec0SDJqDO0tOrsGp3BC3LUGPvZV4dGbSgLYNs0OEb5ZUEUYI9gcmzGG3dMuT8m1juSL8ZRCfdPj\n\ten1gkDldEkaH95dwv+qwwZ8BCLV4bfZwj9TiJNP/d6evFnRikf/tmJunN6ZjG8o9OcQ3q0JAATU\n\taLwcpdRM4HRz0nJvIdOGl7FZ5CyIqExsLpOTC/+cSWwkBePYT24YdHIswtXJShndl1ypedXCYid\n\t+MiejY47ACWoN+eRoR8TsGjuDAkVXu6dbc82naxsQnPkfquhY0Sv99SvJ61L1XyJxMDOVizAGVW\n\tYawUyTI86J2vgO5WTDAZWWrmhSn0rJZtQ1wvqTaXXQot2rYk8dH8HjlJkcOtDLRCWm4cM=", "X-Google-Smtp-Source": "AGHT+IHMTrPrehygcRjE2z/y9prMTCpPyyhNNyfOPbLgTjg29NyqDEMimKI+CpaAnhVH8xaKxGDXtw==", "X-Received": "by 2002:a05:600c:19cd:b0:47a:819f:3acf with SMTP id\n\t5b1f17b1804b1-47a8f8abfa7mr186808455e9.10.1765965702492; \n\tWed, 17 Dec 2025 02:01:42 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 01/26] libcamera: software_isp: gbm: Add a GBM helper\n\tclass for GPU surface access", "Date": "Wed, 17 Dec 2025 10:01:13 +0000", "Message-ID": "<20251217100138.82525-2-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A helper class to interact with GBM. This will allow us to specify the\ninternal storage format of the GPU when making a texture for the Debayer\nvertex/fragment shaders and thus ensure we receive an uncompressed and\nuntiled output buffer.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/gbm.h | 39 ++++++++\n include/libcamera/internal/meson.build | 1 +\n src/libcamera/gbm.cpp | 130 +++++++++++++++++++++++++\n src/libcamera/meson.build | 10 ++\n 4 files changed, 180 insertions(+)\n create mode 100644 include/libcamera/internal/gbm.h\n create mode 100644 src/libcamera/gbm.cpp", "diff": "diff --git a/include/libcamera/internal/gbm.h b/include/libcamera/internal/gbm.h\nnew file mode 100644\nindex 000000000..09811d1ef\n--- /dev/null\n+++ b/include/libcamera/internal/gbm.h\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+ *\n+ * Helper class for managing GBM interactions\n+ */\n+\n+#pragma once\n+\n+#include <gbm.h>\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/formats.h>\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(GBM)\n+\n+class GBM\n+{\n+public:\n+\tGBM();\n+\t~GBM();\n+\n+\tint createDevice();\n+\tstruct gbm_device *getDevice();\n+\tPixelFormat getPixelFormat();\n+\n+private:\n+\tint fd_;\n+\tstruct gbm_device *gbmDevice_;\n+\tPixelFormat format_;\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex e9540a2f7..b8324996b 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -23,6 +23,7 @@ libcamera_internal_headers = files([\n 'dma_buf_allocator.h',\n 'formats.h',\n 'framebuffer.h',\n+ 'gbm.h',\n 'global_configuration.h',\n 'ipa_data_serializer.h',\n 'ipa_manager.h',\ndiff --git a/src/libcamera/gbm.cpp b/src/libcamera/gbm.cpp\nnew file mode 100644\nindex 000000000..659860500\n--- /dev/null\n+++ b/src/libcamera/gbm.cpp\n@@ -0,0 +1,130 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+ *\n+ * Helper class for managing GBM interactions\n+ */\n+\n+#include \"libcamera/internal/gbm.h\"\n+\n+#include <errno.h>\n+#include <fcntl.h>\n+#include <sys/ioctl.h>\n+#include <sys/mman.h>\n+#include <unistd.h>\n+\n+#include <linux/dma-buf.h>\n+#include <linux/dma-heap.h>\n+\n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(GBM)\n+\n+/**\n+ * \\class GBM\n+ * \\brief Helper class for managing GBM interactions\n+ *\n+ * The GBM class provides a simplified interface for creating and managing\n+ * GBM devices. It handles the initialization and teardown of GBM devices\n+ * used for buffer allocation in graphics and camera pipelines.\n+ *\n+ * This class is responsible for opening a DRI render node, creating a GBM\n+ * device, and providing access to the device and its associated pixel format.\n+ */\n+\n+/**\n+ *\\var GBM::fd_\n+ *\\brief file descriptor to DRI device\n+ */\n+\n+/**\n+ *\\var GBM::gbmDevice_\n+ *\\brief Pointer to GBM device structure derived from fd_\n+ */\n+\n+/**\n+ *\\var GBM::format_\n+ *\\brief Pixel format the GBM surface was created in\n+ */\n+\n+/**\n+ *\\brief GBM constructor.\n+ *\n+ * Creates a GBM instance with unitialised state.\n+ */\n+GBM::GBM()\n+{\n+\tfd_ = 0;\n+\tgbmDevice_ = nullptr;\n+}\n+\n+/**\n+ *\\brief GBM destructor\n+ *\n+ * Cleans up the GBM device if it was successfully created, and closes\n+ * the associated file descriptor.\n+ */\n+GBM::~GBM()\n+{\n+\tif (gbmDevice_)\n+\t\tgbm_device_destroy(gbmDevice_);\n+}\n+\n+/**\n+ * \\brief Create and initialize a GBM device\n+ *\n+ * \\todo Get dri device name from envOption setting\n+ *\n+ * Opens the DRI render node (/dev/dri/renderD128) and creates a GBM\n+ * device using the libgbm library. Sets the default pixel format to\n+ * ARGB8888.\n+ *\n+ * \\return 0 on success, or a negative error code on failure\n+ */\n+int GBM::createDevice()\n+{\n+\tconst char *dri_node = \"/dev/dri/renderD128\";\n+\n+\tfd_ = open(dri_node, O_RDWR | O_CLOEXEC);\n+\tif (fd_ < 0) {\n+\t\tLOG(GBM, Error) << \"Open \" << dri_node << \" fail \" << fd_;\n+\t\treturn fd_;\n+\t}\n+\n+\tgbmDevice_ = gbm_create_device(fd_);\n+\tif (!gbmDevice_) {\n+\t\tLOG(GBM, Error) << \"gbm_create_device fail\";\n+\t\tclose(fd_);\n+\t\treturn -errno;\n+\t}\n+\n+\tformat_ = libcamera::formats::ARGB8888;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * \\brief Retrieve the GBM device handle\n+ *\n+ * \\return Pointer to the gbm_device structure, or nullptr if the device\n+ * has not been created\n+ */\n+struct gbm_device *GBM::getDevice()\n+{\n+\treturn gbmDevice_;\n+}\n+\n+/**\n+ * \\brief Retrieve the pixel format\n+ *\n+ * \\return The PixelFormat used by this GBM instance (ARGB8888)\n+ */\n+\n+PixelFormat GBM::getPixelFormat()\n+{\n+\treturn format_;\n+}\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 575408b2c..e5b5330a8 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -70,6 +70,15 @@ libcamera_deps = []\n libatomic = cc.find_library('atomic', required : false)\n libthreads = dependency('threads')\n \n+libgbm = cc.find_library('gbm', required: false)\n+gbm_works = cc.check_header('gbm.h', required: false)\n+\n+if libgbm.found() and gbm_works\n+ libcamera_internal_sources += files([\n+ 'gbm.cpp',\n+ ])\n+endif\n+\n subdir('base')\n subdir('converter')\n subdir('ipa')\n@@ -178,6 +187,7 @@ libcamera_deps += [\n libcamera_base_private,\n libcrypto,\n libdl,\n+ libgbm,\n liblttng,\n libudev,\n libyaml,\n", "prefixes": [ "v9", "01/26" ] }