Patch Detail
Show a patch.
GET /api/patches/25537/?format=api
{ "id": 25537, "url": "https://patchwork.libcamera.org/api/patches/25537/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25537/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251212002937.3118-23-bryan.odonoghue@linaro.org>", "date": "2025-12-12T00:29:33", "name": "[v8,22/26] ipa: simple: Add a flag to indicate gpuIspEnabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c1bc586255c058c177ce219a907c9dbc875d561", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25537/mbox/", "series": [ { "id": 5657, "url": "https://patchwork.libcamera.org/api/series/5657/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5657", "date": "2025-12-12T00:29:11", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5657/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25537/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25537/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2094ABD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Dec 2025 00:34:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C411E6191A;\n\tFri, 12 Dec 2025 01:34:33 +0100 (CET)", "from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n\t[IPv6:2607:f8b0:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 750E761899\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 01:34:32 +0100 (CET)", "by mail-pf1-x430.google.com with SMTP id\n\td2e1a72fcca58-7e1651ae0d5so592571b3a.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 16:34:32 -0800 (PST)", "from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.34.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:34:30 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Jmu2sQwh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499671; x=1766104471;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vdieV2jp4Gung7/4hWVYp0Lav9rda27DBFfiiAcRIr4=;\n\tb=Jmu2sQwhj+KSwMr5a4pSMQn3Ucy6unGtn+CPwiqpbHw50swdmzdIWoC55QpDqeJXmy\n\tYOIRk2vb8PA4sD0+jDvnH96fMFyA87Dff7tftC9z8BUksKHd/JGB7S/om9PzAs8IiXS1\n\t07q3KFcibXhFJQJBaNHdPUZMP/BALukTwn7YvLSXi4KW507HMzdVS69/Askrr6BadXEZ\n\tO9rrcK7rpjjTDhO2DLgoO/4854qpoaqN1azJNYOlS+drJu5k/NqoIUs4GaOST0RHcq/d\n\tO7qDgRumjsATvI8OtoD6NmArcsCqVOMFKlZh1dK7g6lW66tPmP+MaCYqhh5wnSibf3Lf\n\tPCZg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499671; x=1766104471;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=vdieV2jp4Gung7/4hWVYp0Lav9rda27DBFfiiAcRIr4=;\n\tb=aPcocLd2zCDx1ZVM6TkZez2FiZmryTOoYsc+7ca2WWhy8TgJ/b/Xtq33QB+fs3CBuu\n\tSgUFGTCxYmx/I43pYlb0l/fqJJHORb9NAJd4slYNsG+bSfQhYUvh4GJJ9G8wloBa2mqy\n\tvVmWY9wscQNfM2Pf5vIQjKKIiqYmF8+TLaTcOaufkiZ7IY8N/qF0TnLgoXMTJ87IKpe4\n\t/fwFcFwpJvLEoSFxuZ0LZgowN2nhh+CL1ub+86sLABNjyd8YI4wBd5u3+wkvFwPNgi10\n\tPWR4QS4bx9SPUpqazBxUh4gLaxfoRNGIkxxOCudEkZ2kVgVDnAeKTzHT3VMR1QWHND+1\n\tqA6w==", "X-Gm-Message-State": "AOJu0Yx4ON6pe2RCNSvBfioWry+aUqITHvb3l3Y85npDN6jjedStCIeJ\n\tmNf8/kEOtFjbNT59P8v5BTT1MqT+2TZdcFHKe7V3LqPSSwx4Gnnw0MnyxPoesrB/nYVnrPpFz7M\n\tmEPWJ", "X-Gm-Gg": "AY/fxX4nLrDHbFl1gapB42e/uUNbvxFPRV3AtLfaRP2HBNhCCf3i/tbebenAdMfKv4D\n\tqR+DdfWvLpbOQDLNgiiSqwgk+gASv43gjWHDvbfapyY0LV04IB7CJlKdCg2Tzo2Px04rmg9tvB/\n\ts74QteuCL3EJoVLJZeSU1hjecr7HKUM6Zx7h9G+yc/19fa3AMIbnzagE4MzZ31OmUUplCv55fN7\n\tvo7sxd3HjyeDwm7yIOtvFRCuiG38x4FtI8V0APPlpZUibljc/Gz08cRxjGrj9HOe5ewuILkn5vQ\n\tI8HhUGTMo9WqZsn0vU+p9K02pcIISNb3RUbajk0+2jeJ5/Xa3qWfE5DoxoOKpMa8fJT+zJhLv/m\n\tFZdwfrhDJLSDSY7q3OT3n+De078+XgpXPIjszMTsRDATLM1/ug3W7rDbOO/h6184F7JjKpY+ohH\n\t0YRyXpmz9JIUK7gSAh20sbEokK+atmOXgizJGUFf8XX8NNEVFBkmDvWQt7TWs=", "X-Google-Smtp-Source": "AGHT+IHqwt5CAVe7ZDyfevN6c7WNCwRiQ1GiRyTnazLeT2F9Ubh2ivAeCIGvuB2HIlVsB+2En/YlNg==", "X-Received": "by 2002:a05:6a20:7f86:b0:366:14b2:30d with SMTP id\n\tadf61e73a8af0-369afff1ea6mr312858637.64.1765499670778; \n\tThu, 11 Dec 2025 16:34:30 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v8 22/26] ipa: simple: Add a flag to indicate gpuIspEnabled", "Date": "Fri, 12 Dec 2025 00:29:33 +0000", "Message-ID": "<20251212002937.3118-23-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "References": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/ipa/soft.mojom | 3 ++-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 3 +++\n src/libcamera/software_isp/software_isp.cpp | 8 +++++++-\n 4 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..aff8fcbd3 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -17,7 +17,8 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdStats,\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n-\t libcamera.ControlInfoMap sensorControls)\n+\t libcamera.ControlInfoMap sensorControls,\n+\t bool gpuIspEnabled)\n \t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n \tstart() => (int32 ret);\n \tstop();\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 03d8007ea..20c75de4e 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -104,6 +104,7 @@ struct IPAContext {\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n \tbool selfInitialising = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e..2bbe271d9 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -55,6 +55,7 @@ public:\n \t\t const SharedFD &fdParams,\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n+\t\t bool gpuIspEnabled,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n@@ -95,6 +96,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst SharedFD &fdParams,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n+\t\t\tbool gpuIspEnabled,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled)\n {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7fde57aec..5dbb0e3d6 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -121,6 +121,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \tif (softISPMode) {\n@@ -137,10 +139,13 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n \t\t\treturn;\n \t\t}\n+\t\tgpuIspEnabled = true;\n \t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tif (!debayer_) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n@@ -177,6 +182,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sharedParams_.fd(),\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n+\t\t\t gpuIspEnabled,\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_);\n \tif (ret) {\n", "prefixes": [ "v8", "22/26" ] }