Patch Detail
Show a patch.
GET /api/patches/25533/?format=api
{ "id": 25533, "url": "https://patchwork.libcamera.org/api/patches/25533/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25533/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251212002937.3118-19-bryan.odonoghue@linaro.org>", "date": "2025-12-12T00:29:29", "name": "[v8,18/26] libcamera: software_isp: debayer_egl: Make gpuisp default softisp mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4b3deb8e9a8a61532a512b6411bf0be2eb7e6938", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25533/mbox/", "series": [ { "id": 5657, "url": "https://patchwork.libcamera.org/api/series/5657/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5657", "date": "2025-12-12T00:29:11", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5657/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25533/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25533/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39223BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Dec 2025 00:34:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBDB461917;\n\tFri, 12 Dec 2025 01:34:22 +0100 (CET)", "from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com\n\t[IPv6:2607:f8b0:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C1B361866\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 01:34:21 +0100 (CET)", "by mail-pl1-x62e.google.com with SMTP id\n\td9443c01a7336-29d7b8bd6b0so4388875ad.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 16:34:21 -0800 (PST)", "from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.34.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:34:19 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Hxf4dfP5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499660; x=1766104460;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=enuSJNXFUuoTYs1Tq2LkRLCCtdszeCb+2wiWiBmGXZE=;\n\tb=Hxf4dfP5QFBLhX10/974KgsDZqCzDx6A2iPDJwsC4USIUm07AkCWp/JJ0OyswqEfgN\n\tFXbmUqle70Ms1dnspmMhKnA7+E78CwN1ZZpHGK+0JQSvT9vklnXokLrjQ2cqcKflED1u\n\tilcEbXMDIEDgcn2mZ44/PNH8nL2QMoZBiN9cJYnyfhJXnfAFpiHGu4df8Q6inz930nIN\n\tEcwJreciPv7dcuX+h4sWPXXooaQSCYjDfpoOE4ICuxGjDCdfnDevUYnhZ/pHpLYaMqOh\n\t2Pbz5WcYXBaIWh1pxJc6qYAcVymaoVEVWxjRZphHfL6Tc7f8dwts7MMaV8Yo+g6u6iLc\n\tjvJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499660; x=1766104460;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=enuSJNXFUuoTYs1Tq2LkRLCCtdszeCb+2wiWiBmGXZE=;\n\tb=bwbz4OzYYFufB8fBrRx/esDpKZTqaf2GQo98ezDXjKJ/fYh4q4skviNkjcsY3FgBtZ\n\t0X5hHFDwq+vU+915+Pw6n2t6eAZICEczjcg0IO6u1VZTsOSuu4eDp/Q0GH/jWCSmF9q3\n\tNAWe4hTWovW51Qzd8qOmlfMcW7JnoUWz7q5lIuNILTWjMh8Lo/cTgZGKk4Y+E2pzoiUL\n\tdQLdn6iyyzfG8dvB/sb609/72FiMxgWW/PRdqk2UtHj6D9wmQlNEWHXBKvxeIenm67VA\n\tNlCU/kUzzCKIvpLevsVLspkYKlXlrMaK2DFPz0dHLHpeLIsxio9WruVtCaVgleg453UL\n\t+Bpw==", "X-Gm-Message-State": "AOJu0YxoK0ObieFSElaQ6+Sg8qJi9WI5LTjJGrrJQ93Vvx0H/9KUf5GQ\n\tyl2RVlicjD0JJEgckp/j6dJ2eYqrDC0GCElu6tjbwex6hgT35IpfKDjFSHevWtIOJuuj2Mmf2M+\n\tlDAFh", "X-Gm-Gg": "AY/fxX6fcTSy/EJdMAenpwLw+VIC7/cMQQj3JwIHp8IFDQbz/jaPoPzWcsQ4XHDGUKu\n\tLEQYB+DGrDPDwpFpTz3Nh2OStS3/+uPSsW1RBAjXbg+u17q0umT7r/XIbLo5TNPt63FMWGjMpXG\n\tyMXIsShjm+ZKCCcoc2JfIW2vxF2tV3crlp/4qtfBcEp6beCxd6Gm4zv3uPGguenPlcs6kZ6vAUV\n\tiKRSelUDM1QVM/v1a5MHKYuBo2n+sNaDNnPQd6QcH9iDD4tex33iRRSeD6sGfOrAphOgcUwySuj\n\t0GJ/reKnwO1JcjeaAgXk6+GPOnhFJu1oeISovC8UV1CW/QduiUbVO0M1WaCzuycQH+WyoswEh5G\n\t/nCSNKXP39wGMvyaKKm5+LaU1YJkiS7D0l3yXKKFB+cDH68BKRlJsY/oCoi9Y4S4YqSZ+kw0qe9\n\tXcgeBtLVmAJBiCM+fDH1FLVkmA7XMbSlw8hFefM8CVK11SB3C98OzWRqPbMd0=", "X-Google-Smtp-Source": "AGHT+IGR5UQuOK5s0Yz6qgT74OAdEzZ0pk/Yc+NAzhk+P3EcujKsroruznjqPlMR2tlfkfJk3aDlwQ==", "X-Received": "by 2002:a17:903:2451:b0:295:5da6:5ff7 with SMTP id\n\td9443c01a7336-29f24e6f089mr3915865ad.15.1765499659940; \n\tThu, 11 Dec 2025 16:34:19 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v8 18/26] libcamera: software_isp: debayer_egl: Make gpuisp\n\tdefault softisp mode", "Date": "Fri, 12 Dec 2025 00:29:29 +0000", "Message-ID": "<20251212002937.3118-19-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "References": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In some cases the GPU can deliver 15x performance in Debayer with the\nCCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n\nGiven this large performance difference it makes sense to make GPUISP\nthe default for the Software ISP.\n\nIf LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\nlibcamera is compiled without gpuisp support, CPU Debayer will be used.\n\nIt is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex efe44e393..7fde57aec 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -123,8 +123,15 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \n #if HAVE_DEBAYER_EGL\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n+\tif (softISPMode) {\n+\t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n+\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n+\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n+\t\t\treturn;\n+\t\t}\n+\t}\n \n-\tif (softISPMode && softISPMode == \"gpu\") {\n+\tif (!softISPMode || softISPMode == \"gpu\") {\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n \t\tif (!debayer_) {\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n", "prefixes": [ "v8", "18/26" ] }