Patch Detail
Show a patch.
GET /api/patches/25527/?format=api
{ "id": 25527, "url": "https://patchwork.libcamera.org/api/patches/25527/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25527/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251212002937.3118-13-bryan.odonoghue@linaro.org>", "date": "2025-12-12T00:29:23", "name": "[v8,12/26] libcamera: software_isp: Add member variables to track selected input/output pixelFormat", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b4fac6e33025ac2fd4ced34f5a1a27850e3be870", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25527/mbox/", "series": [ { "id": 5657, "url": "https://patchwork.libcamera.org/api/series/5657/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5657", "date": "2025-12-12T00:29:11", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5657/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25527/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25527/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A293BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Dec 2025 00:34:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 408056168E;\n\tFri, 12 Dec 2025 01:34:04 +0100 (CET)", "from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n\t[IPv6:2607:f8b0:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59D74616A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 01:34:02 +0100 (CET)", "by mail-pf1-x434.google.com with SMTP id\n\td2e1a72fcca58-7bb3092e4d7so736513b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 16:34:02 -0800 (PST)", "from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:34:00 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"tS2Sclc1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499641; x=1766104441;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Gq8OF1ZTHYJ405oahlUP/ID9xX8JXtEW/1dvjN5qFO0=;\n\tb=tS2Sclc175vHGHUF9PKqXZs6kX86O2IXeEta+13JIuW7agr+0Zj6oQn1eenl5uA1Yy\n\tpKP5vArUnQmeYLaSOZx51a+jO9GMad8V/YYZZaG9LU+bUo4NuJu1rUEpaOgrSM7K2iAM\n\tv3NkKVrCtWNL9UZtJ9z63sV1/M2ghdDxMLJW/eyczVy0ceFjh/2Qj/yIAEB4cUWGFc6E\n\tr1buaJknEYD2QYJZPwoUK6EA289145vjZbTENnJN+l9of1BS/pJqApQ/annfsgmuXSgJ\n\talycR4NNJv7B1ueyBq1GTuzujJPBqFlkpxmLJQX5vMLdnFzxaX8eCa+ZnvYsXdIVeXmJ\n\t9Dng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499641; x=1766104441;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Gq8OF1ZTHYJ405oahlUP/ID9xX8JXtEW/1dvjN5qFO0=;\n\tb=utWBnCxpXh2Y5ohTokzyIHRVw/kOJ0UefDFLAN/ikpyqXZvw5NNyRXWCc9lJOpJpZ6\n\tbdMCWj3oebnRi0lIyS3p6ZfbJOg8JgH26gjoJNZ11+GdS+Ph8Yqc9ceNsqKBYOm0be26\n\trHWTd8wrXvt/eyY68SDx+Gwj8GArvnb/UqoJKLxJOJ9nTkZE2NtQaKzyo+jLjd/zkq+L\n\tB3BR0qlOKVtZCapFm4QoQNRHEanrPcSbsdbuTp3DbzDvF3dAVzgGLlhi63rtwmLUx4A0\n\t4tLYFPMZzvNCj0r3Wc3vZh5pnnhFKsJVsxNACXnyTEqZaFTiwQ8EjrrB08OoiSu5dGhi\n\tZMqg==", "X-Gm-Message-State": "AOJu0YzzVp3GmKRccNZ6cMLUQ4s0k1by6JQMg+cUPqIj/laHcULLgpKG\n\tReAHZxfQZBxtfLrSPSZFvAbG4ZVLX7sRBVZzIBryRZVt9rwNOhyrX7+z6WOYeD/GNIc5buVBh0T\n\tE5/Hl", "X-Gm-Gg": "AY/fxX7GT4sZwljeQRvkuw1ThO0PCqjsb+Vko6rv6cBar4F3g6ltaR+fMG1hy8LPN/9\n\tXkPmu8KY2BgcDmGjHADQZoVcmtHZ1hBnhAtZ3vQKoaVnwFHhN1a+gM3GcU+bcAgKzkrS/TDk1W2\n\tIvTgsiHWyaVzX+HGBVGi4muWBc4m7SvpIKfzmVsvPlK/09X7w6bA0+dPaN77gCRPYzXgAaJit/w\n\tHBSlBdahaL73Gn0UuFPy88COq33Z0DL6+GmfP7E7hguLTn/EIhwnkgmMaJpewrdbKrKKoA4SyjA\n\tQjNEMiNSd37zIqF6F0mbXkpB/ARCUncK8Zhmcd8QiPmhks0MoAUqD+TDq/817OBKV9b5zFjihG6\n\tYWierXKxjSccFT7fgCe5vRjmQuUBkh2Vh5/H5kY3ZEunsrE8C5g/UJYuSRdRhoi9nNg8P3qp32k\n\tsivjj+e2E2BBK+PzNYbLyHELK/4NQwmqYTOOpJGFVsK92/10sm3dDo9+MGWx4=", "X-Google-Smtp-Source": "AGHT+IGJw7ktuIRIhe011Q+dRTO1PrrcDwX/QttGohTh9LcfK/+2oAzm2Jfh1IUVvAPlvkjpzDh5sw==", "X-Received": "by 2002:a05:6a00:2883:b0:7e8:450c:61cc with SMTP id\n\td2e1a72fcca58-7f671f413b8mr260249b3a.60.1765499640694; \n\tThu, 11 Dec 2025 16:34:00 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v8 12/26] libcamera: software_isp: Add member variables to\n\ttrack selected input/output pixelFormat", "Date": "Fri, 12 Dec 2025 00:29:23 +0000", "Message-ID": "<20251212002937.3118-13-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "References": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to have Debayer::start() tell the eGL shader compilation routine what\nthe input and output pixel format is, we need to have a copy of the\nselected format available. Add variables to the inputConfig and\noutputConfig structures to allow tracking of this data for later use.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex b5b99d390..4e6fa3d74 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -290,6 +290,16 @@ Debayer::~Debayer()\n * output image buffer. Set during stream configuration.\n */\n \n+/**\n+ * \\var Debayer::inputPixelFormat_\n+ * \\brief The incoming pixel format\n+ */\n+\n+/**\n+ * \\var Debayer::outputPixelFormat_\n+ * \\brief The output pixel format\n+ */\n+\n /**\n * \\var Debayer::red_\n * \\brief Lookup table for red channel gain and correction values.\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 5c0cb3914..4a2ec3e53 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -75,6 +75,8 @@ public:\n \n \tDebayerInputConfig inputConfig_;\n \tDebayerOutputConfig outputConfig_;\n+\tPixelFormat inputPixelFormat_;\n+\tPixelFormat outputPixelFormat_;\n \tDebayerParams::LookupTable red_;\n \tDebayerParams::LookupTable green_;\n \tDebayerParams::LookupTable blue_;\n", "prefixes": [ "v8", "12/26" ] }