Patch Detail
Show a patch.
GET /api/patches/25523/?format=api
{ "id": 25523, "url": "https://patchwork.libcamera.org/api/patches/25523/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25523/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251212002937.3118-9-bryan.odonoghue@linaro.org>", "date": "2025-12-12T00:29:19", "name": "[v8,08/26] libcamera: shaders: Add support for black level compensation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e4d840dcfd8f9799dd645f70a5f669ba26f823b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25523/mbox/", "series": [ { "id": 5657, "url": "https://patchwork.libcamera.org/api/series/5657/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5657", "date": "2025-12-12T00:29:11", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5657/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25523/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25523/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52D85C326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Dec 2025 00:33:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1ADDF6166C;\n\tFri, 12 Dec 2025 01:33:51 +0100 (CET)", "from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9880A61635\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 01:33:48 +0100 (CET)", "by mail-pf1-x431.google.com with SMTP id\n\td2e1a72fcca58-7b6dd81e2d4so696588b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 16:33:48 -0800 (PST)", "from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:33:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"iKWpHqv/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499627; x=1766104427;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=iKWpHqv/7DcRhOGlktoHAWFS/MYdjodoqwQOkYIiMqMezEQMWiHuq+gZvplcMKp6H8\n\tG6uLiQn7JKdHBJXLhjLFCvw0F+KTCZx+Jc5VgeZvW1L7ZB8Rnhhc4Lt4KpiDpX2lcwn/\n\tK2iwFnDkeiGfel3loAabfJjXQdWxI2vwH8QggbC2pRpAx+zFQEajSOMepIk//Rk+aWff\n\teqqdsyeqfZEK9xP3aF6DNrjp8q88UBUnVx1fjjU9R7kF5RTPQrc442Ev0DikbGP6l1yk\n\tIs3hZWefBER075nxZNc5g2xNGUbY4eC+1u1ynAU4U0PaKUmeJmoQzV/x7zGWaaF2OpdX\n\tBHJA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499627; x=1766104427;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=ve7RyDyhI3rrMgYfXj6yc/7xGcwNmih7hYuRKPWIrki/uXkR3y73M9vok9MuScr+1D\n\tFgZ0cOf7yWgGxwcKQm+RfPQiOqHaJvc2iK6c4Q1373liUzw9ymPoTc5eI+wi6PH7wd3s\n\ttgUwavmAY0oQVpL25P/hjRVv5pw1oGzyFTppFIwBUCRv89/X7uiFcfLgq3AtHc902TBq\n\tLcw8rb408r0yW4rkIfLGfOs6ZK4L4Yue6M8COltl6riQG01qqK7VPZ3EqwcudHZ01WXV\n\taogxuYVpiuZTPqUxjsrITX9kz0ZMlvHShu/WcJgJnVIYi0p5NuHgJiLM8aRFkXl9t8hh\n\tSyQw==", "X-Gm-Message-State": "AOJu0YxwnMiCubqrsb+ikVcmzhJwlYSpoXQPm5ZORAPYuu+JrA3UfgrH\n\tiI/0ebYk1d7vtp93+wN0/nuvbqdzmhKv/rkucjp//FXH+kaTt+gz75QNA/+7wsURcSH/oK0q6r1\n\t42gV3", "X-Gm-Gg": "AY/fxX7w4ZOVyuG2giP8jwgzdFMJDlqE1EAsV6Uo+0hyIeuqFNKCBC5tqydD7ocxjed\n\t97vJeKzRqi9OvPdZ5D3DBP420GDvF6jb7oEsjui0suEFt+kn7nr/TD5XkkV0COv0FZX1MzNFIOq\n\t/yuvNVuMkXXF2Ji4gOwXYg17KV5kYwqR5zlXA7dsC197dhw5YOkS3taAtOa7+OPTRB2tnfsWa+G\n\t0nr5ZS0wbvH7KRpi6Xd+21TkzY1/jMHlEL7hs0UvoErrecAmu3XCR0PjtzIE0BBFPI/6BZ0Txz5\n\tmTB2Q3vpbJvHvutiMhu3DFMZcuGvTI1pejF0MwCsmj5/ntPOUkoVlfAvo+mZMVeKx1F3OYCEKUt\n\tWd9D3ATynU46n2FGxqeV4n2Z/r5JPENs7JXWFRGHe7sTINnVeeJekrWsKUuRNu7MrkLw89nVtfY\n\tFfd8RenHqDdn7bd50Mhh69IDgimr8fOa87ANX83qsyhyK+cZNh7c+fC0dutZPQQd2YNC/7TQ==", "X-Google-Smtp-Source": "AGHT+IHFdaAI1TlPzI5mnhQQqiVPYeiHHHbFB4r36z7dUCqQ5NUOE0dK6SJd0G9qHoQm9ReTdZ+mgw==", "X-Received": "by 2002:a05:6a20:7344:b0:35e:7605:56bb with SMTP id\n\tadf61e73a8af0-369b00eaa8bmr331731637.59.1765499626932; \n\tThu, 11 Dec 2025 16:33:46 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v8 08/26] libcamera: shaders: Add support for black level\n\tcompensation", "Date": "Fri, 12 Dec 2025 00:29:19 +0000", "Message-ID": "<20251212002937.3118-9-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "References": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the ability to apply a int blacklevel gain against the demosaiced data\nprior to application of colour correction data.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 3 +++\n src/libcamera/shaders/bayer_unpacked.frag | 3 +++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex db8c2a0b3..7036fe278 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red;\n \n uniform sampler2D tex_y;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void)\n {\n@@ -213,6 +214,8 @@ void main(void)\n \t\t\tvec3(patterns.y, C, patterns.x) :\n \t\t\tvec3(patterns.wz, C));\n \n+\trgb = rgb - blacklevel;\n+\n \t/*\n \t * CCM is a 3x3 in the format\n \t *\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 06d80f3dd..f0d8cd1e2 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -25,6 +25,7 @@ varying vec4 center;\n varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void) {\n vec3 rgb;\n@@ -108,6 +109,8 @@ void main(void) {\n vec3(PATTERN.w, C, PATTERN.z) :\n vec3(PATTERN.yx, C));\n \n+ rgb = rgb - blacklevel;\n+\n /*\n * CCM is a 3x3 in the format\n *\n", "prefixes": [ "v8", "08/26" ] }