Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2545,
    "url": "https://patchwork.libcamera.org/api/patches/2545/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2545/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200109232647.2068851-1-niklas.soderlund@ragnatech.se>",
    "date": "2020-01-09T23:26:47",
    "name": "[libcamera-devel] libcamera: ipa_interface: Document the ownership of dmabufs passed to mapBuffers()",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "8c5394648470c970afb9c2bf171db2741fb30a78",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": {
        "id": 16,
        "url": "https://patchwork.libcamera.org/api/users/16/?format=api",
        "username": "neg",
        "first_name": "Niklas",
        "last_name": "Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "mbox": "https://patchwork.libcamera.org/patch/2545/mbox/",
    "series": [
        {
            "id": 613,
            "url": "https://patchwork.libcamera.org/api/series/613/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=613",
            "date": "2020-01-09T23:26:47",
            "name": "[libcamera-devel] libcamera: ipa_interface: Document the ownership of dmabufs passed to mapBuffers()",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/613/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2545/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2545/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15F236045F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Jan 2020 00:26:57 +0100 (CET)",
            "from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 82e481a5-3337-11ea-b6d8-005056917f90;\n\tFri, 10 Jan 2020 00:26:53 +0100 (CET)"
        ],
        "X-Halon-ID": "82e481a5-3337-11ea-b6d8-005056917f90",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Fri, 10 Jan 2020 00:26:47 +0100",
        "Message-Id": "<20200109232647.2068851-1-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.24.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH] libcamera: ipa_interface: Document the\n\townership of dmabufs passed to mapBuffers()",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Thu, 09 Jan 2020 23:26:57 -0000"
    },
    "content": "The ownership of the dmabuf file handles passed to mapBuffers() is not\nclear. Explicitly document that they are borrowed from the callee and\nonly guaranteed to be valid for the duration of the mapBuffers() call.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/ipa_interface.cpp | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\nindex ee3e3622f39ae85f..25b075fef5a50db7 100644\n--- a/src/libcamera/ipa_interface.cpp\n+++ b/src/libcamera/ipa_interface.cpp\n@@ -429,6 +429,9 @@ namespace libcamera {\n  * handler that the IPA needs to access. It provides dmabuf file handles for\n  * each buffer, and associates the buffers with unique numerical IDs.\n  *\n+ * The dmabuf file handles provided in \\a buffers are borrowed from the callee\n+ * and are only guaranteed to be valid during the mapBuffers() call.\n+ *\n  * IPAs shall map the dmabuf file handles to their address space and keep a\n  * cache of the mappings, indexed by the buffer numerical IDs. The IDs are used\n  * in all other IPA interface methods to refer to buffers, including the\n",
    "prefixes": [
        "libcamera-devel"
    ]
}