Patch Detail
Show a patch.
GET /api/patches/25432/?format=api
{ "id": 25432, "url": "https://patchwork.libcamera.org/api/patches/25432/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25432/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-16-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:43", "name": "[v7,15/26] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4332d9c2287e66c06675e1d2dd88742998b215e1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25432/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25432/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25432/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C907CC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82B7F61489;\n\tWed, 10 Dec 2025 01:54:56 +0100 (CET)", "from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n\t[IPv6:2607:f8b0:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B40561487\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:54 +0100 (CET)", "by mail-pf1-x42b.google.com with SMTP id\n\td2e1a72fcca58-7bf0ad0cb87so7346426b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:54 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:52 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"hj1neJiy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328093; x=1765932893;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=;\n\tb=hj1neJiyk0pki55u+lEY42wkfhmOw/qNFrzFOAecHeFye9WvBMJttlbs6dplJk63B6\n\tsClRcbIvlVNEz7NCTVeNfQ4dix5NuuTzmYulrKK2iSHt7evV1IpHYBVMJT/IHoRcTVel\n\t/VhPjYTYavfTC/rRxA2SQWAKeGlhhUFR+UW5Uz2L3Yfd4o3h76cIGs7h7o0EOM2tStHF\n\tsiSVoMyJcvK1xE1xkl4aDiibd4lq2sHgEffmvolIp5AMDkb4xC9Iafwa57To2allh+8B\n\t/iG5sSHfWI4ymkdFwqT1qvcfNtKcCFrO2DRWfvjsZdLI3LggoNuDBeE/MOqQ8S3CRFQW\n\tIxqA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328093; x=1765932893;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=;\n\tb=SLi1vwJdpphw+fbA9xoj4+LWyz3bVcur+fQLTvjRt3x8Q8os5a4Fw2G2DcnnmFqB3L\n\tLUaJ9v9cRpBygj5h/ZGqbixT5K+C0PmjUPmXXipLNvVHB9gxf7yTQGP8aZhkZw4g/Xwt\n\tiVG6ZrZiHkV3K4aSHOIoYfRbQTsK5pO6belrYRReYzNtaPXq+kAA6HnjwHOhh4EtmpYY\n\tt6Psdj+9KEuicczM1Y+xVK1juOopKbwd+sp3wsmDS1x2524NsrcJA+zCkgbw/zqjHXOz\n\tzrzHsICjXEnvtDBiXqjU9fDSH/LBkHI8ckQF2mTcvlI3KQzy15IUBDGZl1B7Y/53/xw0\n\tRptA==", "X-Gm-Message-State": "AOJu0YziGqY4AfiYbG8W+l0E9rRNG09nm+QeCf21oSdzchB5k+0/z3tg\n\tV0oeVl890M5BjQDPXXelHA4W4XABRkEYErKf6Gj6bEo5y4H7Sd3mmFkIrZos0++ENE39v+4J/6k\n\tm7Ln6", "X-Gm-Gg": "ASbGnctIedH4fLBfMsQhp66T0jLEdz+/MOKjwMz36bhg/whxLJoKvDse+0VmgGLQfl0\n\tnwtSzpjzXhCbT9uuiuxhVqCrag4d6Si0i3BZA3fv1JUPSO7IDKNXKXlGN0GI+dOduodHjrgYIgU\n\tQSsV4sWwMswjVX9WzfMEITIjGMIUTLRmXnUZ+aUkqKeLQ8Aqe6OCr3Pc6U6LBM31JUC/KPi0Hm6\n\tm2OwAWzwaj2YlCuIWkoDVJ1zQEDLWY73gTo1mJJcPaRn7I1ALsYWWO9ZPew0eA1cB/ui8nEc190\n\ttBUZ1vH+iSnggsby01prDjspgB1KoTUHR9c2p6NIMfVFT3DEU21PAp6gamJ72nCYurKq7jIQhqI\n\tECMooBRoEoCohoz1+Sq4BjQ4uhVrGn9OiGlzZm2vMGIImjykiPdZoZjyGLgEYzVGWsYzEs5HJ8y\n\t8Vci45XlWTa3ckUy5QsbCkBBhjPzuDU1T6j5ktkahHCRvZLH/KQS9DykqMCzyV4rL7", "X-Google-Smtp-Source": "AGHT+IFS3r0aXGeuQX+5WEaVxsWyUys5Lez0i9IFe8KIleC4zLzTDOfP3kkPk+c8hs8CgVq0w/xptQ==", "X-Received": "by 2002:a05:6a20:548d:b0:366:14ac:e1e3 with SMTP id\n\tadf61e73a8af0-366e35c3d35mr428068637.73.1765328092596; \n\tTue, 09 Dec 2025 16:54:52 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v7 15/26] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static", "Date": "Wed, 10 Dec 2025 00:53:43 +0000", "Message-ID": "<20251210005354.44726-16-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurrently CPU ISP supports more diverse input and output schemes.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex ecc4f9dd0..67df2b93a 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -97,8 +97,8 @@ private:\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n", "prefixes": [ "v7", "15/26" ] }