Patch Detail
Show a patch.
GET /api/patches/25429/?format=api
{ "id": 25429, "url": "https://patchwork.libcamera.org/api/patches/25429/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25429/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-13-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:40", "name": "[v7,12/26] libcamera: software_isp: Add member variables to track selected input/output pixelFormat", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "205d988c43b8cdb6d15af878d5534abbdf023365", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25429/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25429/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25429/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E90D7C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6A8E6147D;\n\tWed, 10 Dec 2025 01:54:48 +0100 (CET)", "from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com\n\t[IPv6:2607:f8b0:4864:20::102f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4F5961472\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:47 +0100 (CET)", "by mail-pj1-x102f.google.com with SMTP id\n\t98e67ed59e1d1-340e525487eso4965013a91.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:47 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:45 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"hYMEXUlP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328086; x=1765932886;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yBXY86g8lO48WNEk1CRWNS0al2n3xfeUVM+ASK/7Rxw=;\n\tb=hYMEXUlPE+1ap5nQCILjylVoH69lSDFfifUjISfTkzeEWGuh6mfw857HVX+KqqtWOI\n\t0O8q7LKsNzxBpa1qiS4pUeJ9MpzsAmTuD/U823AAM19za4OpCQtqqM39zb9GB3wCGi4z\n\tkm04mflMP4k14oyi3IPHlLH30yxeIIm9RuIM4mkZsKi7hTQXYsbW00oqhdEc1X9AYRjl\n\tXStHOILA/I7dtyMtzz9jnnrz2Q3zHO1Y2Uznu+tPoTELmkK85Riawe5BY8YCmtYl1pfE\n\tULNoJFLoX2ZhA5slS7YI95gHxs6EyULWAT464cT8RtVdIOvAa49liVjtiOadFu+FO/IF\n\tcuJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328086; x=1765932886;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=yBXY86g8lO48WNEk1CRWNS0al2n3xfeUVM+ASK/7Rxw=;\n\tb=WlC6LLy9UdlOHSGqVWyZyi/0KJXz6L2RiGnZ3huliwijlF6yF/jr9GLFgfklZHTZW0\n\t/RW6d5wJLaREG2IqxWN0w2TZyl88qd9GviRWC5maOXz3nPIe3be2yxiUIzpm2atho0st\n\tGsf1pZaDI8A0TaxvUH4/hj/IIiSXT9BGi9vl8vz3htBCU+n2jmmcOfAsQjLdJUqN5Bhj\n\t5fULZ2fnXmDeHyDDwGyeOJzfEKw8dAgitJQ8UznJke1VS6q8ZFDgi/W0bkBouj/+W1/Y\n\tq9CK+ryUPOIB74c+4+XklZyoimWaSy9U3QaKjeRkUlvMQfUnUQfW9rB9fgUQGu/ox0AP\n\t9Clw==", "X-Gm-Message-State": "AOJu0YwD0rC6tHktfYfW0nCHUChyL+on/IGcu40gHw1IQACQEf6OX/gL\n\tcg6Icctq++mPfrYTECMQHrs3RwbZ4gCe8WpCAtqfl7aTQs4PoijMmcck4Pu3R0GYE0nvFmnIBeZ\n\tajBQ2", "X-Gm-Gg": "AY/fxX4vgjxF2eDOtTHeIO6hkzdfvj2UEtDq/ChIHa1WUm9Xc4MqsNME/COVQhw4us2\n\tt0rFL4c13hR6D2SmDY4+WW9FV7YgDjcufLt6hGPLo8+y3gKiNPZoYkcftEmC6DqAhS2Z+kUwpfX\n\t3ZxPVHDayFXayrAwxXsjZem9UAFv+sOZH+TWqdKYyRW/fVaJeyIKe2P3utItsdykfakLwq/Xtqe\n\tfL9WnzXSsr2Hb2O7a7CBB9z3wCY4SLzvJCrUGbHMox+iWdGiPUDq6BcRmxkNBo59AVQdtRa4Wcv\n\tT/fINQk/Vl6aL9pbioZnNLFY97hevkSX5Mv1gayG7KnydT1oZmdDpfeyBnGaIAmc6rjqFro5Ns6\n\tBTFZ/CWMpCRcyNG+0qc+tGnWMtTHTXFwdtD9qZDZ2ULa+GgmJLnllFjHrsjtajLQu+St3PwdsSJ\n\tpMVM/YrgzcWX+SMX89j+VaW8HlwMNN+oG+edpsEyV8BC+GbRMT/RqKP2yCxlQQ6kur", "X-Google-Smtp-Source": "AGHT+IEjCREWwBfHNqGxGIEAQcZ+8xVPdkGLwUACtyPxoAiKbaJ01Jg+4m9mZGw7VeF4ORhygOpXsg==", "X-Received": "by 2002:a17:90b:5790:b0:341:d265:1e82 with SMTP id\n\t98e67ed59e1d1-34a7288c12amr537865a91.29.1765328085942; \n\tTue, 09 Dec 2025 16:54:45 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v7 12/26] libcamera: software_isp: Add member variables to\n\ttrack selected input/output pixelFormat", "Date": "Wed, 10 Dec 2025 00:53:40 +0000", "Message-ID": "<20251210005354.44726-13-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to have Debayer::start() tell the eGL shader compilation routine what\nthe input and output pixel format is, we need to have a copy of the\nselected format available. Add variables to the inputConfig and\noutputConfig structures to allow tracking of this data for later use.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 63a61daf9..ebd3e3a8b 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -290,6 +290,16 @@ Debayer::~Debayer()\n * output image buffer. Set during stream configuration.\n */\n \n+/**\n+ * \\var Debayer::inputPixelFormat_\n+ * \\brief The incoming pixel format.\n+ */\n+\n+/**\n+ * \\var Debayer::outputPixelFormat_\n+ * \\brief The output pixel format.\n+ */\n+\n /**\n * \\var Debayer::red_\n * \\brief Lookup table for red channel gain and correction values.\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 5c0cb3914..4a2ec3e53 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -75,6 +75,8 @@ public:\n \n \tDebayerInputConfig inputConfig_;\n \tDebayerOutputConfig outputConfig_;\n+\tPixelFormat inputPixelFormat_;\n+\tPixelFormat outputPixelFormat_;\n \tDebayerParams::LookupTable red_;\n \tDebayerParams::LookupTable green_;\n \tDebayerParams::LookupTable blue_;\n", "prefixes": [ "v7", "12/26" ] }