Patch Detail
Show a patch.
GET /api/patches/25426/?format=api
{ "id": 25426, "url": "https://patchwork.libcamera.org/api/patches/25426/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25426/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-10-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:37", "name": "[v7,09/26] libcamera: shaders: Add support for Gamma", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b84f0f5b603856659bfecac8e4eaaab2a6d7aa8", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25426/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25426/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25426/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38FF5C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0085461473;\n\tWed, 10 Dec 2025 01:54:43 +0100 (CET)", "from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D5056144D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:41 +0100 (CET)", "by mail-pj1-x102e.google.com with SMTP id\n\t98e67ed59e1d1-34381ec9197so5405066a91.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:41 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:39 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"AOH8BfSc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328079; x=1765932879;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=RJJStRXEZYCXo1I2NiOJvRenJYpqtZFEk2eWTmXAnZI=;\n\tb=AOH8BfScsydTcKix+Sg/vwMZM0MTxfCmqLKgazUiUWyJpkpcjeKSJwh6njm9hG/aUU\n\t/LTM+gb7W3cOL8Uu+Cm/FhJIUA+TmXo/+E678gj5CDCLE9mZ+Irl7Dwzf1osHauVU+rN\n\tdEVqzmJNAWlt2/963U8ahUnzbV9sj9Jp0xME10ZvVQFqGJ2mDV0HZE+Pq9wgg/1Uf+hu\n\tocJxM2icFTzN8XdnsTup0aURT9x1RvN9VeZery2QwHhL962DhdtMidZaYYv5Py4ekgV/\n\t0OwB7zXLe+/UCIXqEHluouzCnQK9XzZF5DNPk+6eRRXZLRV7i2kNJni325mzR4GFI1+5\n\tUvQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328079; x=1765932879;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=RJJStRXEZYCXo1I2NiOJvRenJYpqtZFEk2eWTmXAnZI=;\n\tb=R8KnPAI0053zUsDatMLMaCMPlfgs/wwPfbnIvUMqZYbPmFUbF1J1OcFq1DmUTnwFBA\n\twQXc6axG4fW06sxHed0ZhcQCDAF1hMirretBj6iF7e1uldYQT5LODQzA4/FAfieb63BE\n\t7a5Rb3EtlQ59QBdiijCq+1b4drvEUGMElEF71DsrJJ4ou+pCB+Sk9apXF/9oNw+tfj5P\n\ti82o1CqIT+T+9Hk7AC+yyW4Ypyo2Ss9GHknqtUmNcDzohQovPliUzw+M8SRtFH3b/4xj\n\tJNL+00Ns8LDM8LC5TB5ynRreQezFXeqswwVfbDB1889UY1i8MngUHKPmtDALVwZUrMOE\n\toHXA==", "X-Gm-Message-State": "AOJu0YwmU/vdaevLFAryPf0LWg39j4PqqdiRtJIQoIKGDprtePD803vV\n\tZvjmV8stN6piEBzBZVLtg/SQCU9XooyQQRkWStBr2vFuF8G9eIGfVSDBHmM/Wzcn9X5CWTJakTY\n\tOZorH", "X-Gm-Gg": "AY/fxX4cVtA/XMjnPeAjs57G878MoYnlwAiGlM0pEPhIx+n2MxgblFdlaI7iByZG5vc\n\tZKhnwDMU/BKyuX4/0xfmUiXIvvoFnwEsl7XiOHTg3U5SVZQHUnfM+jRRvThFbigCbP+0etk16w1\n\t6NBahytUN8/JKZ3cCErye2GQphRdQtF2j1ixOrEs1IaNTuTex+2I2YMgRmm/0+oQ8kehBjvBiMV\n\t2DV/B4YB9YIW7y22Z1MsvKGcUCQKsOgt3dORp4pmNnNJv0MCOSfSHSTnW38XhAbFfYQnhK7yZdh\n\tvzHWusMUvuSCSLIAdIiBhvn6TQ3kcbo1e2hw0m5njLxgao7csIAyMretKIsPtQ24ZeM4yQJRjjE\n\tkLAbHL/ickhbOyM3Y4qYqzAWX6stjPbev4uAmCSxZzjoZqcS2oRyuWgPTKNqshD95AjzcG/Nd7g\n\tLiFT7XU/BQu29cE0lXuIHKupXxQVkj9X8tkCi//3tEENS/qjwyNHXp2hezVgvAqJKo", "X-Google-Smtp-Source": "AGHT+IHERH7FkIpRUMhsXyTI2AwkDTxPd7kwURcn8LdsMuHsL38B090/HW36yr1nDws/7N/Jja2CBA==", "X-Received": "by 2002:a17:90b:258b:b0:340:54a1:d703 with SMTP id\n\t98e67ed59e1d1-34a728d52ffmr566068a91.35.1765328079482; \n\tTue, 09 Dec 2025 16:54:39 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v7 09/26] libcamera: shaders: Add support for Gamma", "Date": "Wed, 10 Dec 2025 00:53:37 +0000", "Message-ID": "<20251210005354.44726-10-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add gamma compensation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 7036fe278..77d9fbfa7 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n uniform sampler2D tex_y;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -260,6 +261,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n \tgl_FragColor = vec4(rgb.bgr, 1.0);\n #else\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex f0d8cd1e2..aba11a87f 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -26,6 +26,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -155,6 +156,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n gl_FragColor = vec4(rgb.bgr, 1.0);\n #else\n", "prefixes": [ "v7", "09/26" ] }