Patch Detail
Show a patch.
GET /api/patches/25424/?format=api
{ "id": 25424, "url": "https://patchwork.libcamera.org/api/patches/25424/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25424/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-8-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:35", "name": "[v7,07/26] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c8fe7f0d90359367374670fccaad26c63fe1bcac", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25424/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25424/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25424/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29290C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAADB6144E;\n\tWed, 10 Dec 2025 01:54:38 +0100 (CET)", "from mail-pf1-x432.google.com (mail-pf1-x432.google.com\n\t[IPv6:2607:f8b0:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15C676142A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:37 +0100 (CET)", "by mail-pf1-x432.google.com with SMTP id\n\td2e1a72fcca58-7aae5f2633dso6813338b3a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:37 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:34 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"W5DhNGHS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328075; x=1765932875;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=W5DhNGHSyV3I996uac6M2zL2cLbr72nY+syXoC4fZd4w0zTxlLWRPyUCIggMI0mdqw\n\thKo5GDrA440tRGlYBOAqgFv0AcCKoVzgB71NJBj/KLLtlEvc3NtBtmWwbNALoSIO4A6Q\n\twR3SD9FmKWU/Iy5o8ndiSKfL6fjqLCeSmRRx5Evx0D5ovZAsXp3djBN8RowwZlJrONlK\n\tqj83pkWivP5FldwVWd1JZPfbW/Dft5vH6OHfyRUxTrQMnidQFkbpx9VP5uxtdyL63Uya\n\tuo6w5FA0lhmWBy/1g/KaA/UqsqDfjlRaxVa4ZOCL4atvxKwezkzQu9wdu8WOT5jHM6b7\n\twUJQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328075; x=1765932875;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=vTe1U1mw3xihSkoj3UsL8WaIgB/Y/wMlQS3GwPovbM6i0wmoxbjSfytYQCX2w9i3Ep\n\tHBWRiYUNOo0rpiSXT/agQRUpTm9/nn3p0gjKNjMSVjzLQ35NIpKXJsCWVCRF9u2fTTqC\n\tQ5wD3VM818bmDDCf81kAoLGcs5MhLeu9O+IuJwwpBsPyGPPaQlxBklROn8yHIdna9k9F\n\tow8KY7vF4KcedIcc5Ox7c/lvZsKiWVwbOok1Of0a4SN7Gbu0JTai+VCgJVCJTGecoDJo\n\ta62tX864i1k3R97hjL4VwKo04RpaTQtu8xe+7qQ+ZYD4LmNq50Lx3gxqKLr+UJs3Vfkk\n\tGXVg==", "X-Gm-Message-State": "AOJu0Yzq5tdSRjtAUDwVl2I9sKg12G/05Yg4ORwN3j4r992vcPabrS0j\n\t3C+KskPsqMVhVO+NgH7GGq1ulMLCBO+bypYiyGZdNhr/jleraYiunX3C+ySQD5hoKw9WwbD/4lF\n\tFQqQs", "X-Gm-Gg": "ASbGnctHvzJi+AiSsrAlrhZs6YjTUm20Tk1mev050F199Ly0FCp9DoL+GmKxF7Revh/\n\tO70VAI0C8ZiAr9yQ0TIVcT8C2DHCjXlRoK2JSqtzZmJyfE+9s9wIm5P4Piv2bm0iuZXjyc05Qaz\n\t+A9QrwnPB5U6aP8a0flZPS0Pxdh3nrLVVz1chUosbQtuwY/4TOrAKQFG4hmmCXmFNxYZTW1rJYy\n\tnHX240ekOVvp2J1BP7dB764RYf5tyPfciptZ6nEqILa1G2y7+sg2le4yNz87TnNoiA0tKLBG6fw\n\taG09pvhrTg29fDrpMyWZRrkPDHZeGZJp2dAQJ6Ku0zUEpXcqjkrDk36GwVkGhWwZ+zKPFVC6yOZ\n\tAdhbfHOvyZ923IH1v08SgYOVm1agdUsL19YOun+L9TNJC3opJR2+0gAesfnIIWhedK2QSEGoEnN\n\tlx6zWl2uibho6wNrKakAUqNq5C+5RoJXHHYg1ZGswnBdk8b2jIs+A3a1SgAk2wTHoM", "X-Google-Smtp-Source": "AGHT+IEnVttcMbF7FXioSmUcmZF0H41PerhuSkePWMhn7/xE+RzVl+4oGsYBBwJhvAFEzC8XHyxEdQ==", "X-Received": "by 2002:a05:6a20:9188:b0:364:be7:6ffa with SMTP id\n\tadf61e73a8af0-366e1217ed6mr518599637.36.1765328075335; \n\tTue, 09 Dec 2025 16:54:35 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v7 07/26] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Wed, 10 Dec 2025 00:53:35 +0000", "Message-ID": "<20251210005354.44726-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 171a928c2..db8c2a0b3 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -257,5 +257,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex c41d72f4f..06d80f3dd 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -152,5 +152,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+ gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+ gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v7", "07/26" ] }