Patch Detail
Show a patch.
GET /api/patches/25412/?format=api
{ "id": 25412, "url": "https://patchwork.libcamera.org/api/patches/25412/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25412/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210003139.43606-17-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:31:33", "name": "[v4,16/20] libcamera: software_isp: debayer: Make the debayer_ object of type class Debayer not DebayerCpu", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "00cb24c2259f1fa42548d27252359da091be1156", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25412/mbox/", "series": [ { "id": 5644, "url": "https://patchwork.libcamera.org/api/series/5644/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5644", "date": "2025-12-10T00:31:17", "name": "GPUISP precursor series", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5644/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25412/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25412/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EEA8BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:32:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E80CC6145F;\n\tWed, 10 Dec 2025 01:32:40 +0100 (CET)", "from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com\n\t[IPv6:2607:f8b0:4864:20::102f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E61FB61450\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:32:38 +0100 (CET)", "by mail-pj1-x102f.google.com with SMTP id\n\t98e67ed59e1d1-343dfb673a8so6335009a91.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:32:38 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:32:36 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"bZNGlaYe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765326757; x=1765931557;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+PkMvzCnM9G5wbdm2DgdHRiNaN/qiCPxWjNd922vzx0=;\n\tb=bZNGlaYe83XDuyn2+h6mDw40pa7r+jRwzZJgR+8ZQ4SOJDrsAugypfFn1FPImgcNGJ\n\tmw4ov1HeYHlxhVj9joxiGSiMvNrejQh6i8Jy88SYpBKgXiMfWqmGF771eIrd9BOVcEFf\n\t7fvqX2/OILKeZ1qB6EGKoEiuVBXKMQF9s7BLp2sjr/MQIRPCNXmAzoR/16ZFir//lyW4\n\tmGVbFxfniTkVv+98Cl1GnZqUodIbMQJ91AggaCaHL1Hu5IxY186+poqRst3Br4fsX+7+\n\tfjK+BJzwfYH6a7L1v51jvCdwabynnDmH2ruxx2Yso2yC7TJCZbVIGe3Lub13Miy5XfVv\n\tuTbw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765326757; x=1765931557;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=+PkMvzCnM9G5wbdm2DgdHRiNaN/qiCPxWjNd922vzx0=;\n\tb=bIaVnnQ+MEaHzC5yUNRZb5yksnLzrB9TRmyyN9GMTfjoYiMQfnZ8PZcH64uBCWIQEr\n\tnG5hIL6vtiJGhEJoxFZOkzln6x1tyCuS+fxmX8eaS69pln6NQ4fVxyCAPl+i48w/pow3\n\tqV/bypmRDSB+QZMSPc+T+9QezeNR/WkCiI+c0J27tu51EGQcQnvzdzURyRuIeBv2f2rk\n\thWlPgBwjduht/zHIC/eDC6QZU9P4aLV/OKvxmIJM6zoVDBBJbrPZ6uTw+CQFkfBV/qQ5\n\tIWfwKf+IW4TD4ByHnl6qyQiAXy3EwzGisM1ku0hHgNZMU0U+pK+9JhUZm5JkdzC8EhdQ\n\tPDIw==", "X-Gm-Message-State": "AOJu0YxMSlYWyF9dQvvGb/BuIo7pJkLwm72ooczwXuEHyx/UEX1HybN3\n\tZ/HxahA6o/m0BQ0Ximm1J4tWTynako/ax3wGK7MVfru0xHHTwDKN5zT5YIUuAYLeBidNHc+JWYB\n\tj9tRc", "X-Gm-Gg": "AY/fxX42Hq4fYpw/P1Y5zA/mc6mAQb99MgSvtL27asasm4RTUd1Q+0olbNHdD84CnE3\n\tK7JDjeeuomOtnyEGxVEs+SIJRhIQWKjW3PAcEmJT/zt6NFFWfOkz+cwVl2dBPbZU76QDkI5GQWS\n\t3RhLnu+MqrjoSkrwgRqEn0+0wcVXaPEfhyKkMyJJ8ERe+Dvr41WlbpRWxgSV+8dorXPus7YFLxW\n\t7sOgvYa9qnyH7QW52oKizTu6oVsKwmckq+ioYtLZgO5X1ZwzSlNVw1thlTrElXON3vnic2iAsra\n\tHWuf77H0DpYb7w7Mma2/3lf8SA/yIArzMxMk3DvL+S/SKQdY4jx2BOMaaw1O0Mhnn2t2yLOZFHW\n\t07z32mRVZCI3fXwWEVBIvUM+lSJ0Kl4w3AZOLNz7F6OfD77Dk/hBdMdre+z5x6ObKoR3M2yxTcy\n\ttJfABxVa3Dfiggd66gHW72I/uXdUjeNjdUZFE+6Ql2KrRtQcSrdy8bUpyDC74Ap/to", "X-Google-Smtp-Source": "AGHT+IF5FbmLerbJDwuDom+J2hLRXmYO6e2U51570nu+Ud3t5HAruhuaKAu3T84AIzb43Dnz2HSHlA==", "X-Received": "by 2002:a17:90a:d44d:b0:341:8ca8:ae64 with SMTP id\n\t98e67ed59e1d1-34a7289e773mr496227a91.35.1765326757254; \n\tTue, 09 Dec 2025 16:32:37 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v4 16/20] libcamera: software_isp: debayer: Make the debayer_\n\tobject of type class Debayer not DebayerCpu", "Date": "Wed, 10 Dec 2025 00:31:33 +0000", "Message-ID": "<20251210003139.43606-17-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "References": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make the type of object Debayer not DebayerCpu thus allowing us to assign\nthe object to either DebayerCpu or DebayerEGL.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 2 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 786246592..ad89c9b3c 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -37,7 +37,7 @@\n \n namespace libcamera {\n \n-class DebayerCpu;\n+class Debayer;\n class FrameBuffer;\n class PixelFormat;\n class Stream;\n@@ -94,8 +94,7 @@ private:\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\n \tvoid outputReady(FrameBuffer *output);\n-\n-\tstd::unique_ptr<DebayerCpu> debayer_;\n+\tstd::unique_ptr<Debayer> debayer_;\n \tThread ispWorkerThread_;\n \tSharedMemObject<DebayerParams> sharedParams_;\n \tDebayerParams debayerParams_;\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7c9ad9160..b31a374d8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -348,7 +348,7 @@ int SoftwareIsp::start()\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->invokeMethod(&DebayerCpu::start,\n+\treturn debayer_->invokeMethod(&Debayer::start,\n \t\t\t\t ConnectionTypeBlocking);\n }\n \n@@ -360,7 +360,7 @@ int SoftwareIsp::start()\n */\n void SoftwareIsp::stop()\n {\n-\tdebayer_->invokeMethod(&DebayerCpu::stop,\n+\tdebayer_->invokeMethod(&Debayer::stop,\n \t\t\t ConnectionTypeBlocking);\n \n \tispWorkerThread_.exit();\n@@ -394,7 +394,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n", "prefixes": [ "v4", "16/20" ] }