Patch Detail
Show a patch.
GET /api/patches/25409/?format=api
{ "id": 25409, "url": "https://patchwork.libcamera.org/api/patches/25409/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25409/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210003139.43606-14-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:31:30", "name": "[v4,13/20] libcamera: software_isp: Make output DMA sync contingent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bbc24e3404e986b0c8daa2edfa4d9c57eda948ad", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25409/mbox/", "series": [ { "id": 5644, "url": "https://patchwork.libcamera.org/api/series/5644/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5644", "date": "2025-12-10T00:31:17", "name": "GPUISP precursor series", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5644/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25409/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25409/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F5B2BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:32:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58B5761440;\n\tWed, 10 Dec 2025 01:32:34 +0100 (CET)", "from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 106B161440\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:32:32 +0100 (CET)", "by mail-pf1-x42f.google.com with SMTP id\n\td2e1a72fcca58-7bb710d1d1dso9835503b3a.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:32:31 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:32:29 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"fcrmwljK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765326750; x=1765931550;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Kob/ToaFoFnln8JxOvYeUhkJB1Nasllbl3ZD4CR3Ky8=;\n\tb=fcrmwljKvbPc07hCSe8GLT4xGUkRLzP9o3dvlVAlwlJBACgl7M3xgruKt5C7h3wkci\n\tMAqI6go69+RpiFgLA8yC0Bzt+dSoT1YrA36W7z9Qx0nfWgeq2Yvn9vyyfQF36DoYhB6p\n\tzXllZDu1T1nFEc62dtWm61OER9Vhp3NYX91nZNuan5mKVEiMnT33rp4UX1SpZ3AZsfLm\n\tXj+UV8Yc4/MqgMB/6oPoORQr5hgo5POSg8yQ3izEBg1eriKZiN2QFYiF1uchkewugr65\n\tF9RZJDv/I34S3yb7k5iwIniblLN5dYJ8/cNNGK2suVKeTOlgEhumEEjms7f0Y0NoW+FP\n\t/JrQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765326750; x=1765931550;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Kob/ToaFoFnln8JxOvYeUhkJB1Nasllbl3ZD4CR3Ky8=;\n\tb=WLMG6oqYwHOQabU0yYZFsRKoHLxm/2zDG0+Q1NinwwPtByKGaPcKdSjhDWhpbHWq/i\n\tJx1CZeKpOi+dAs8K4eZQ9nraHN7Yz4Gha3tIhCZf/1tYpJtKXicJbRxImGsSlhNKGXQy\n\twqEt6voIHPqrg1lMfk23NpgFyyhOI6QVBQNNoCKJH/LMCBvaYo0p5YwkLJENcyeDxEy7\n\t+ZIAe6clrk7JMlHopSGuOqMQZMrSDuS6WonKIcnhYnDNA7M+uNO00CigkilMJoNpRpy0\n\t31k2uKOtYadHJbrLxa6xrNxwRT0TDeZHoO1cpV6N0tT65t3+XvArIchRv6/9BVpvk1ll\n\t/TJg==", "X-Gm-Message-State": "AOJu0Ywn51iKb5dMF4PjDlUGsUt5GsK8ts136YpEFfUMfG0t4JZNOw4j\n\tQU59FIpuiebVQZVemHesnhKhC/5w3k/n92f3HPO0/0OD63YFdVtifu8Jn3IdBtSgRWJH0JWyaka\n\tRlS+6", "X-Gm-Gg": "ASbGnctnC6D7Ih385u18Pd1I9ag7HmYpS82itUxr3KGDAnr9jzLgLKDHXL/WbKX6j/n\n\tZcT9F6uxkZM5R1ohYWfWJBw7+L1nN/Yw0n4gF5BC/OWRRlhtX3iBR6rBg6jJPkC4FzR34L/zdyK\n\tr3EaZgIho3wnTXbEQ4NmoZLpV4GQyysGnVxOwiyUP/cA4l9ZjbJlGyY5v67zLaw0yVRAByzIYXs\n\tCFmB2Auuzz1dG66Jm3L003RkouehZcBlCegLJ0DDFmRwynAfqmP0Pm56Pxz9Ys9uxau00F4pkf6\n\tA9CqQzPvSzfaaDz+0pNph0hi0P9jAf/gLW9I9wYmmHgrW45CxXondv/wXzGuhjWRRDhTDtJ1GQy\n\tId2X449sjrucyrCcIf8avAO8HD80WJHi+k/NQ9qveE32sUw0pndnLEFgSUGa6vnk1+uJJVAPk8p\n\t5h2BCkx7sm1wX8wnNjaFQcN7IgQkXajXYoDcTi5muWTlk7AxK+2T7oxGj5qLg8rJAB", "X-Google-Smtp-Source": "AGHT+IGKx1qi/wEHeP1G1K/SbzYebMbCKQ9EOziGrQDB7xHsypg8TkCpybXOeoh1cG+Q2qqti7/UTA==", "X-Received": "by 2002:a05:6a20:12c1:b0:34e:7bef:e820 with SMTP id\n\tadf61e73a8af0-366e28890f5mr499598637.41.1765326750358; \n\tTue, 09 Dec 2025 16:32:30 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v4 13/20] libcamera: software_isp: Make output DMA sync\n\tcontingent", "Date": "Wed, 10 Dec 2025 00:31:30 +0000", "Message-ID": "<20251210003139.43606-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "References": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The DMA sync output buffer from the GPU need only have its cache\ninvalidated if the CPU is going to modify the buffer. Right now this is\nnot required for gpuisp so only act on the output buffer if it is\nnon-null.\n\nSuggested-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 544921656..158128f30 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -373,8 +373,10 @@ void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *inpu\n \tfor (const FrameBuffer::Plane &plane : input->planes())\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tif (output) {\n+\t\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\t}\n }\n \n } /* namespace libcamera */\n", "prefixes": [ "v4", "13/20" ] }