Patch Detail
Show a patch.
GET /api/patches/25406/?format=api
{ "id": 25406, "url": "https://patchwork.libcamera.org/api/patches/25406/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25406/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210003139.43606-11-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:31:27", "name": "[v4,10/20] libcamera: software_isp: Move Bayer params init from DebayerCpu to Debayer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc98b0414802a4f733a0902cf99234a261030282", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25406/mbox/", "series": [ { "id": 5644, "url": "https://patchwork.libcamera.org/api/series/5644/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5644", "date": "2025-12-10T00:31:17", "name": "GPUISP precursor series", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5644/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25406/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25406/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92226BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:32:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A82461440;\n\tWed, 10 Dec 2025 01:32:27 +0100 (CET)", "from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com\n\t[IPv6:2607:f8b0:4864:20::1033])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8961361440\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:32:24 +0100 (CET)", "by mail-pj1-x1033.google.com with SMTP id\n\t98e67ed59e1d1-34a4078f669so1884839a91.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:32:24 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:32:22 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"i8WWyzvv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765326743; x=1765931543;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KQPTsn/KLpLpdnxwrT8L2zFzJbbxCaiz8WDvZQ7olVM=;\n\tb=i8WWyzvvopEgmPr21fKyyJ5jkEirQbW5u2FLYibu60XJ4OXhsXdpl+CkFcx0K0CvWi\n\tsa90f7aLnuG46tcURQyuw8ZEMZwgc7clH+W4iMt1zse0Vo9v3Tl3Pq3m8XnEK4jEZK1m\n\tzefJuCfS72BrCKbbs3WH8X5xZFvo40csENNtexFDQWWsfHgjuh3yKD6hfEtIAdlblzGQ\n\tnc/ciwTC6Gp5pPUmYkOLO3E7agD4NSKJXHHuvF5RStHtBOuY7wGXPYo4Fab/EG8Ba8jE\n\tepqNL9UgxM9yskkv+e6SpxjM77Ot0PBHldFTQuIAwDPY8Bt8VZsNrsdl8GFHoHk1DRey\n\tWBNw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765326743; x=1765931543;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KQPTsn/KLpLpdnxwrT8L2zFzJbbxCaiz8WDvZQ7olVM=;\n\tb=Q9Slq77U9dY10w/BD+oeB0qo8VncvaUY9uiPBQyz/orhhr7b1+hvpcq9OlOL++v76f\n\thNMYEddkJfGD4GIGs3F8770GEnd/7tXAPCaNlWrRi9JOyPceC6oBcXerlcIrMTs+/t08\n\tqWFLQ7QZ1YMu3fzeqT8T377/KmWItEI/bLBf27MGWrRi2xNcYVRn6LNFIXQFaS8ywzto\n\tajV3RzSSDj3hJ4a0bnnlqoDWp/YizKz3OrIPX3DF2ekeLyt1vIpsX0xHyrEuVX7ubF3f\n\tdlYjLg+NntavjynBmIgNnOva9TzPH/OJ0RI06vRMVHeoAxIfL7YSDqZLQjD7DPGtggkv\n\tZwlQ==", "X-Gm-Message-State": "AOJu0YxYeqlSR4K7O1LQMTbXpXdMndtRDCIlSOjreQem0OOBMy4kx6/i\n\tl/brqK/saQEOB67pbktQrtU9M0wEZ0rpegnn4S8tL8ODUGp4ToAhnlKdKN+gMiU4j5yg4XqG//a\n\tt3CmW", "X-Gm-Gg": "AY/fxX5d+DeUn5Xyj9MpiA1ZSpADihFXGdfQdMVemR1g0+GLS5PkDtbbcuhwrwgEQfU\n\tHnO7FTbWUbxhcjmaHJK3ff8l3lGxM6ebBGcpJDhuNtwxeSXQijFPqNCEP+7XWs6y6S2ngCreGm8\n\tAXS+lUc7YOzUesh5HSkRY/t3Cx4bjrMLPe0/FXTwmp/ZxY5rtB4atGP5pxv+EMtaHLC+OEWrUOt\n\txLladF2I+0ICylgQIKpF4VK40COjOh5Qn+W6ptBpaVacH+u+/YrCikKxmJz/+MT0Q6pdw7Nx41n\n\tsKei53Cl1rwrY4xXN/i5ASHF1TJg0Zduf6p6uj+uqMCxf6URo/C/SR2p+rZbn7TwJtzUrSlQyMj\n\tBnd5mXwFjlH+mVCknb2UJQ5pY+XpdJgoQDYDtpBVxRtfiT/MJeX1BNrpBlb0gAdDUA/x1o4G6Xe\n\tyUBm3kGlz+D1Ov9iCa/B0HYcChvnMO6UevpiF7VUPamlQSW66ygvDI8v4usPiPVNZBdnejx52a+\n\tps=", "X-Google-Smtp-Source": "AGHT+IFVa4xUbYp1E2+SS8o4xvaEu3X8wDTAtQMN4cpw6Z8awnzTFunJQvgS4EULItKO0tbiWFkL+w==", "X-Received": "by 2002:a17:90b:1d02:b0:343:6108:1706 with SMTP id\n\t98e67ed59e1d1-34a728c6d92mr511419a91.17.1765326742745; \n\tTue, 09 Dec 2025 16:32:22 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v4 10/20] libcamera: software_isp: Move Bayer params init\n\tfrom DebayerCpu to Debayer", "Date": "Wed, 10 Dec 2025 00:31:27 +0000", "Message-ID": "<20251210003139.43606-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "References": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the initialisation of Bayer params and CCM to a new constructor in the\nDebayer class.\n\nEnsure we call the base class constructor from DebayerCpu's constructor in\nthe expected constructor order Debayer then DebayerCpu.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 11 +++++++++++\n src/libcamera/software_isp/debayer.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 8 --------\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 1e3f08673..8cadfaadc 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -109,6 +109,17 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n+Debayer::Debayer(const GlobalConfiguration &configuration) : bench_(configuration)\n+{\n+\t/* Initialize color lookup tables */\n+\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n+\t\tred_[i] = green_[i] = blue_[i] = i;\n+\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n+\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n+\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n+\t}\n+}\n+\n Debayer::~Debayer()\n {\n }\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex b562985a6..f4373ddeb 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -33,7 +33,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n class Debayer : public Object\n {\n public:\n-\tDebayer (const GlobalConfiguration &configuration) : bench_(configuration) {};\n+\tDebayer (const GlobalConfiguration &configuration);\n \tvirtual ~Debayer() = 0;\n \n \tvirtual int configure(const StreamConfiguration &inputCfg,\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex e55599f09..8f42d706b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -57,14 +57,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats, const GlobalConfigurat\n \t */\n \tenableInputMemcpy_ =\n \t\tconfiguration.option<bool>({ \"software_isp\", \"copy_input_buffer\" }).value_or(true);\n-\n-\t/* Initialize color lookup tables */\n-\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\tred_[i] = green_[i] = blue_[i] = i;\n-\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n-\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n-\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n-\t}\n }\n \n DebayerCpu::~DebayerCpu() = default;\n", "prefixes": [ "v4", "10/20" ] }