Patch Detail
Show a patch.
GET /api/patches/25387/?format=api
{ "id": 25387, "url": "https://patchwork.libcamera.org/api/patches/25387/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25387/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251208110035.248881-2-barnabas.pocze@ideasonboard.com>", "date": "2025-12-08T11:00:34", "name": "[RFC,v2,2/3] libcamera: device_enumerator_udev: Disable copy/move", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "308cf9844dae0a3479a07d3a3d409e83ace71b83", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25387/mbox/", "series": [ { "id": 5642, "url": "https://patchwork.libcamera.org/api/series/5642/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5642", "date": "2025-12-08T11:00:33", "name": "[RFC,v2,1/3] libcamera: device_enumerator_udev: Add `override`", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5642/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25387/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25387/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37115BDDFC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Dec 2025 11:00:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C6B5613F7;\n\tMon, 8 Dec 2025 12:00:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D58E613CB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Dec 2025 12:00:40 +0100 (CET)", "from pb-laptop.local (185.221.142.68.nat.pool.zt.hu\n\t[185.221.142.68])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E82E9316;\n\tMon, 8 Dec 2025 11:58:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pwXc0AZG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765191501;\n\tbh=vlBc1qomo9o4cxv2PWDUw4PNI1OIU4+NIHXkZfK5Q/I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pwXc0AZGCrhz454lPskr1d2Viwupnfmc9BEYzsWVtj4JRaSIoStAX84yD6RqT0heG\n\tx64eKQht4ZpS+WE/pLtNpR0frz6moVr1yktEkA9iwmPusr9YVftQTZ0t7fvPrqWvvw\n\ta/OVO8PMA1E4BCU2YaCnL4g2VwxfO8PpSKXnhgos=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[RFC PATCH v2 2/3] libcamera: device_enumerator_udev: Disable\n\tcopy/move", "Date": "Mon, 8 Dec 2025 12:00:34 +0100", "Message-ID": "<20251208110035.248881-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>", "References": "<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default implementations generated by the compiler are not appropriate.\nSo disable them.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/device_enumerator_udev.h | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\nindex fb0005921a..c2f7154b6b 100644\n--- a/include/libcamera/internal/device_enumerator_udev.h\n+++ b/include/libcamera/internal/device_enumerator_udev.h\n@@ -14,6 +14,8 @@\n #include <string>\n #include <sys/types.h>\n \n+#include <libcamera/base/class.h>\n+\n #include \"libcamera/internal/device_enumerator.h\"\n \n struct udev;\n@@ -54,6 +56,8 @@ private:\n \t\tDependencyMap deps_;\n \t};\n \n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(DeviceEnumeratorUdev)\n+\n \tint addUdevDevice(struct udev_device *dev);\n \tint populateMediaDevice(MediaDevice *media, DependencyMap *deps);\n \tstd::string lookupDeviceNode(dev_t devnum);\n", "prefixes": [ "RFC", "v2", "2/3" ] }