Patch Detail
Show a patch.
GET /api/patches/25333/?format=api
{ "id": 25333, "url": "https://patchwork.libcamera.org/api/patches/25333/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25333/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202134544.662446-25-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:45:44", "name": "[v6,24/24] libcamera: software_isp: Add a gpuisp todo list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f01a647225d31b1e58537e0a907e0236cc568a95", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25333/mbox/", "series": [ { "id": 5631, "url": "https://patchwork.libcamera.org/api/series/5631/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5631", "date": "2025-12-02T13:45:20", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5631/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25333/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25333/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0DF7C3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:46:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4FF861009;\n\tTue, 2 Dec 2025 14:46:34 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9517760D36\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:46:28 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-477770019e4so46200895e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:46:28 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:46:26 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"c8cgNY2a\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683188; x=1765287988;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iKJW+qI1D70zuWFggqa2ta4Vy4rY99zX/Wr7gC8b7TM=;\n\tb=c8cgNY2aiE97JeKabvZquTpqaCc31i/DQ0tyUCEW9wIoIGiMmd3dBztYgoVdMAgUjb\n\tSmWsT2AUBdI2fa+8nwnTUxhBtRrr1Lsb8wGPOVVVrPKi3fTEsb896T2WWfWfdZRNm3C8\n\t2dKb8GFsYPZV++d2YsFvO+f4IaFFmIyySxNf8gdciZ/yNzu5nI8w2FwCPTTSIKhhbjG6\n\tx5bJqIMyKbqHJXmG/nQsF92zhpnP0pOTaostXXJq66n+Ze3CAUSWsiEuaptoLF3Xntq8\n\t8vDDGTO+NThciLxBq0lmIJjUPmyjuO6C5vqPodB5gj0805u1xbPfOghz/r5WTBHnAsVs\n\tqwoQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683188; x=1765287988;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=iKJW+qI1D70zuWFggqa2ta4Vy4rY99zX/Wr7gC8b7TM=;\n\tb=HKiACh76tc9PcdE1CQXqoojj4qD56Vodp4sCaSncd+ErpFtJlXezMcF7j3pXNBhZZM\n\tl0En7opFxc10PuJu4LUdJ+fZ7r8hhdk9ea9ONmr7uu5hr8VaBpMTQ360EUnE6HbX8ZAF\n\tXcICJOtsV+cstNbbG2JNWlOU5wYZhwz37QjmRy0VOE7g75V3LXcVff23yvREZV0nmsPT\n\ts1aNYyajZGNsaLeD1praT1+PMzxTxfD3AM9hMFk2KT8/bEn6qjKSajU6ac72LZix5jVA\n\tDHueK29Dc2iz2gnFpbtyLkIAF2Vt2Ov3cO3vvKmmR/2PbG0vJtOkH0O4cxuiDmGgXNgz\n\tDBYw==", "X-Gm-Message-State": "AOJu0Yz4uSahjbd7EzeRerBD/2IFpsIjafRm5u5lzgMIPeqlwZ3mp+lV\n\toIj1T8ZRAAumkmcyCrfG+B/Pnw+y6z5DRTsYt3R5fCf5omNKKgj8su238QTrPitUpe7632ZFyrz\n\tzc99L", "X-Gm-Gg": "ASbGncv2VQwl+ztqHesG8tFhPRtbFn96ZwEcS0HBJ5RzeSoRRwuYv+FmgnVO320BY1R\n\tCizEwQELEFkyeIaRGFl++RE5dvMOZ7XLw5aFFkpxqKrkH4gD77rwL1lPRmXWYf2eKmRaSPF67H1\n\tjwycBRT0/e8xk4xWHaXSEKz19GFMq1POdwv9zHCM5464ZILThun0ya+TrdHtY0B2al+xgTyayn1\n\tq5mNbkcigaptcg5WNSP2m+dGOSZfclWkaIWG+VsfXps15fJZF/wi67WivqmXWXxnODnMyc5+J1N\n\tGUUSg0s9e4ZEle5DqNc4bwjbTW/ZJOQB8NvS+pLJNMcQouEtRYW2gmAv9g60V6Hi9v7LLvoykof\n\thL4eCEHdciFX5xWJZ1BhyK22UDRrhprzj/zffDa0G5YpTln3NUEMCtBwLAQFHDRD35x5/tFrHJT\n\to/I6OxrjwLJpz72IWNArvBQ3eiNRr3TSpbFIPs6bEx7Ji0FV6fO+NuKRPI4OzYdwiHHtc=", "X-Google-Smtp-Source": "AGHT+IHz2/XT49PRMxU/vKG2gW16uJDgt0WfXXwcJ1HuEP2BZT7w6AX55MOMdUfuv9MEAgfqIdTGzQ==", "X-Received": "by 2002:a05:600c:c48e:b0:477:58:7cf4 with SMTP id\n\t5b1f17b1804b1-47904acef07mr289061985e9.4.1764683187777; \n\tTue, 02 Dec 2025 05:46:27 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 24/24] libcamera: software_isp: Add a gpuisp todo list", "Date": "Tue, 2 Dec 2025 13:45:44 +0000", "Message-ID": "<20251202134544.662446-25-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "References": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/gpuisp-todo.txt | 83 ++++++++++++++++++++++\n 1 file changed, 83 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt", "diff": "diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 000000000..768dcc320\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,83 @@\n+List the TODOs in perceived order of ease.\n+\n+Version 3:\n+Use dma-buf handle to generate upload texture:\n+\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n+\t to feed the bayer data into the GPU.\n+\n+Denoising:\n+\t- As below still TBD\n+\n+Dead pixel correction:\n+\t- As below still TBD\n+\n+Lense shading correction:\n+\t- This is WIP but as yet still TBD\n+\n+Lense flare correction:\n+\t- Not WIP still TBD\n+\n+processFrame() to run in its own thread:\n+\t- processFrame() runs in the context of the Debayer::process()\n+\t thread. Robert Mader suggested and it seems like a good\n+\t suggestion too to run processFrame() in its own thread.\n+\n+Version 2:\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Denoising:\n+\t- Run a denoise algorithm in the shaders\n+\t- Supply a control to influence the noise-floor ?\n+\n+Dead pixel correction:\n+\t- Add logic to correct dead pixels in the fragment shaders\n+\n+Version 1:\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\t- Version 2:\n+\t This is not possible.\n+\t gl_FragColor expects vec4 not vec3 on the output.\n+\t If you really want RGB888 run cpuisp.\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\t- Version 2:\n+\t Complete GBM surface removed, memcpy() phase removed also\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\t- Version 2:\n+\t Complete sm8250 test platform shows 20x performance increase\n+\t with CCM.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\t- Version 2:\n+\t Done in version 2\n", "prefixes": [ "v6", "24/24" ] }