Patch Detail
Show a patch.
GET /api/patches/25296/?format=api
{ "id": 25296, "url": "https://patchwork.libcamera.org/api/patches/25296/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25296/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202133157.661407-11-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:31:41", "name": "[v3,10/22] libcamera: software_isp: Move Bayer params init from DebayerCpu to Debayer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc98b0414802a4f733a0902cf99234a261030282", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25296/mbox/", "series": [ { "id": 5630, "url": "https://patchwork.libcamera.org/api/series/5630/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5630", "date": "2025-12-02T13:31:31", "name": "GPUISP precursor series", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5630/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25296/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25296/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FE0FC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:32:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6410A60D16;\n\tTue, 2 Dec 2025 14:32:21 +0100 (CET)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19B9D60C88\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:32:13 +0100 (CET)", "by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-4779cb0a33fso57734675e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:32:13 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:11 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Z6dClsls\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682332; x=1765287132;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KQPTsn/KLpLpdnxwrT8L2zFzJbbxCaiz8WDvZQ7olVM=;\n\tb=Z6dClsls72P/CDnOVHWrmJHSWm/2rNvmZ1Ohf/2+IVeY7nMDcLi6qU0s2/liOEbukp\n\tQ2AFVSF63Ndo8G0qLsnme71cVUrzMJqziSR7FNLCrnhvomMOokLDqBQHI/vg99Ckwtzi\n\tzM94Sct6+m7QMiyWYkCs6/Qn8T5dEH5d1TiydlTjznejEqS2U5p8zQSjanbPk71L0i8/\n\twy82JZsk2eKyXmibiRmqZ3axxeMN8Bozg3ZZaWyWeP26Xa8WlIcR5ghmuRx6L13L3STX\n\tAo++/N0VT1MpjuK2mTRekH05lbXorhyMZp8XQwl01bRp9VuWwwmw42BCppNkQboJTP4E\n\tAeyw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682332; x=1765287132;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KQPTsn/KLpLpdnxwrT8L2zFzJbbxCaiz8WDvZQ7olVM=;\n\tb=QAlNn90XYuuoDr0vl2yQ+eGmuumz99S8xWDBq0La7wSqJUY6tnAAXbJe/T635ReHIl\n\tCXZe+G7Rw7j6dDHmuRi+s3JtbQFWbqyQPDspsdZIGWYW7o3t4SUvApZ9e53UnigK2OAg\n\tOkADrzw6FhpV2PsS28wunwxsCXAjgYIECIlZRFZiQE5AWk3NwBYqjYLvUyIaI2YJQi8P\n\t0mDWJ6Rdv0pLdb6BhPTBCSszjtm+N9tsp0yQiPLQm274oozFka0mZQ5Em5nszM+AVd+t\n\tXX9m2tmywqYNlzW9aWe7TMaqMwNCvanwhJRgN9WyE5kCeCKrMkKZuCyWKlhg3vokq97N\n\t9Dgw==", "X-Gm-Message-State": "AOJu0YxT7IaGWUZGIw8KGHzRohxSc5I/q0Y8xIh1b8hAlfa/UGh3AttU\n\tbAi3YQzpWu00eH2SdftQTows90OKA5sEWA4yv1POSOynQiUWRDrnLqw8wb+w2B3GCdvXoXWKrNo\n\tga7nP", "X-Gm-Gg": "ASbGncsE2m9i+hI7wV3SYjF5ICOMzHE6HDk852/+0UZ9FmRpTfL6lMMc4md3CydqEyX\n\tqyFyhbW7MDA4RX/FW6/UhIVEV4qka9iVEsieawv5YbCkRbbZW8FF90DFzVGZvw9v3/zNvIiwZQZ\n\tZFK1/IkqvcSH0LdjxYMbqo6pFhzdnUBH2H8FGhUrMiylqsWYCAg4UC2VF5WqdqwBoF86bqxxInF\n\tOqek36fcknLQp/Z740E2hKwPVr87CnhM3R44VJzZxKfZfKQINL29SYmhXSiSyaa72iS+d7DnAO0\n\tz1h1W1Z70pL+1AlzXPRFtsAdWg3kZOr7/fgyuCVIuuDUK4ViVtEfZfjtMAeHR30+01q4IQZijOy\n\thH3HrqbcG/h4+Mv8Nm9x2+1tK1vKn4DkAgHJHs8oeDSEjJ+HmjSbpZPpDGhu27KfE9Lc+YBMnEe\n\tMdeG3niVgAkAm66jP3Nd3KPcgoylHWm7ArvqWkkc3NPdwxsgDu5ma/H3UMgUWhHzfzpS8=", "X-Google-Smtp-Source": "AGHT+IHboZ31W7T4jzanYYc591RzQoc78FjKsMHQrrxgjf5eAJy4cYgKcX12+cCHmliK65gF0Kz3ZA==", "X-Received": "by 2002:a5d:5d83:0:b0:42b:3257:f175 with SMTP id\n\tffacd0b85a97d-42cc1d0cd34mr45406119f8f.28.1764682332250; \n\tTue, 02 Dec 2025 05:32:12 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v3 10/22] libcamera: software_isp: Move Bayer params init\n\tfrom DebayerCpu to Debayer", "Date": "Tue, 2 Dec 2025 13:31:41 +0000", "Message-ID": "<20251202133157.661407-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "References": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the initialisation of Bayer params and CCM to a new constructor in the\nDebayer class.\n\nEnsure we call the base class constructor from DebayerCpu's constructor in\nthe expected constructor order Debayer then DebayerCpu.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 11 +++++++++++\n src/libcamera/software_isp/debayer.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 8 --------\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 1e3f08673..8cadfaadc 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -109,6 +109,17 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n+Debayer::Debayer(const GlobalConfiguration &configuration) : bench_(configuration)\n+{\n+\t/* Initialize color lookup tables */\n+\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n+\t\tred_[i] = green_[i] = blue_[i] = i;\n+\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n+\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n+\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n+\t}\n+}\n+\n Debayer::~Debayer()\n {\n }\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex b562985a6..f4373ddeb 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -33,7 +33,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n class Debayer : public Object\n {\n public:\n-\tDebayer (const GlobalConfiguration &configuration) : bench_(configuration) {};\n+\tDebayer (const GlobalConfiguration &configuration);\n \tvirtual ~Debayer() = 0;\n \n \tvirtual int configure(const StreamConfiguration &inputCfg,\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex e55599f09..8f42d706b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -57,14 +57,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats, const GlobalConfigurat\n \t */\n \tenableInputMemcpy_ =\n \t\tconfiguration.option<bool>({ \"software_isp\", \"copy_input_buffer\" }).value_or(true);\n-\n-\t/* Initialize color lookup tables */\n-\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\tred_[i] = green_[i] = blue_[i] = i;\n-\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n-\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n-\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n-\t}\n }\n \n DebayerCpu::~DebayerCpu() = default;\n", "prefixes": [ "v3", "10/22" ] }