Patch Detail
Show a patch.
GET /api/patches/25291/?format=api
{ "id": 25291, "url": "https://patchwork.libcamera.org/api/patches/25291/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25291/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202133157.661407-6-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:31:36", "name": "[v3,05/22] libcamera: swstats_cpu: Drop patternSize_ documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "59741e75c523b0031de9169f512623c1b3987ba1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25291/mbox/", "series": [ { "id": 5630, "url": "https://patchwork.libcamera.org/api/series/5630/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5630", "date": "2025-12-02T13:31:31", "name": "GPUISP precursor series", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5630/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25291/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25291/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98E41C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:32:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F186960D13;\n\tTue, 2 Dec 2025 14:32:14 +0100 (CET)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A79C60C8C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:32:07 +0100 (CET)", "by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-42b3c5defb2so3807288f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:32:07 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:06 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Zkl3B7cB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682327; x=1765287127;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=Zkl3B7cBVJwhIynnC0RoJTgUcovfzGNo3oaSu+eyCpVM6t1lvwn/Tr+ubu5lryAohx\n\txZ5RKhQXo+KA7j6fPT8aa4OVOFjL3r/jvNm20lT37a4bgNNuYlwohxob3r5IPVa6U9RV\n\tLsdEYSZJ8mwwl5YlqkwZdPo7+g3qRUz5XQ88iI86c8kbap8zcf7EfWuwwjCLdygjv5FX\n\t3EEk6mL6iVtuTZwKwknzGQDdzcU5b+CjhWLzvahcj9c6Wfag8wU65XcE8J2p2fV+tl3i\n\tSaxTsNyuXAQEiTUU7f97VT1nqDLAidp0Yywyv0N6f0EPXhG77S00vGVYM+m60m6YcMfR\n\ta9Sw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682327; x=1765287127;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=sd1RekaoiKMtNO2fZ5TqAeBGtzPgih6zqeUoLIoqyNMxiMWSnW8FRT6GONgSHpVeHp\n\t6fIfxPw59W3EOAptRBHuk/5PgyRxJTOu1k7bAddTZNFnRXmxnEicUcNzF4fdvcreEs11\n\tvXT9lh+wimWXsMqPOOgaE+lyB6TPV5em/graRIJGCv/xQ91jS9T2BZQD7QadRnm8VfqU\n\tHzfMRY6UAdDxzFL3aKm3LLT8EryvgWMZZshuMvo494Arf7m1Zz4xvUPcpvKQfEocjYie\n\tcGhPb2bQdoUe7MZa47CwG8C1y3jz3d95kd7S6nVPsp1RjNQSibECVPyrawM0lnQOZPDC\n\t5+RQ==", "X-Gm-Message-State": "AOJu0YzVcVgzWax/QeBX4amajASRtOrSnNcdhSuRNL/XBq4K1cQnk3D6\n\teiokuxkvx84Odr97Yje+8o3bGLfZUoOZWIk18tR7ba/znZPTlaVkEy+ylIx0MBPPzzv9oCKWHXE\n\tGIamk", "X-Gm-Gg": "ASbGncvEzuJ3l1ZOWJZqJEpRm8ndjEG4Uhu2YSDcoqJVRSEE9oCha92HKDu8HcvmE25\n\trLlpULuPETsCL7YBbevaZbW7siEGcsNhktn4bVvX5V+j7BHIW/qYqdWC3ifBrUjmWNcHqOXDHeF\n\tj9d8OICcNSloXV2NdWFbHdgbJTObSuBfNTbKLGhlgbMuyRKf9GcpMipWqYbVUM9R8HuE8u/tmFU\n\tplPCqZEBSnq0QFX50fIxk4Se7Hk5i7XGS1+VTm+sqYLy96jMQ2mibLBT5uk59DF+If3hrI+Pjm0\n\trgcLZBVSIL6N52jl7hOhN857SZO2oosKDlC7LfSWRw+rgT+4jEMGwmKLIltEzGf1dV4Czh9bscC\n\t83QRKkEg+FCcYxSqjarVFIyllKPs/XyjiqVQzStP6/lJpx6IJCFKq0VepXyVUhHkkQXozSDJCEe\n\tJfUQtMyzZhqmx+pvlGMFPFCPrW44oKReJpYLw9QPx/TbZEoeWd6gdpwIaZ+427u6Xhh5PBPZ27J\n\t6KPRQ==", "X-Google-Smtp-Source": "AGHT+IFXvtEu6zKc/G1giIZYkGrAl2i+PdofnQGuJdkiRgnxPvJledxm0ZTilJ/QrcOMspb51CGxWg==", "X-Received": "by 2002:a05:6000:4304:b0:42b:55a1:2158 with SMTP id\n\tffacd0b85a97d-42cc1cbd202mr45490558f8f.17.1764682326595; \n\tTue, 02 Dec 2025 05:32:06 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v3 05/22] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation", "Date": "Tue, 2 Dec 2025 13:31:36 +0000", "Message-ID": "<20251202133157.661407-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "References": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a0..1b33ffa71 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n", "prefixes": [ "v3", "05/22" ] }