Patch Detail
Show a patch.
GET /api/patches/25289/?format=api
{ "id": 25289, "url": "https://patchwork.libcamera.org/api/patches/25289/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25289/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202133157.661407-4-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:31:34", "name": "[v3,03/22] meson: Automatically generate glsl_shaders.h from specified shader programs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "78bfd4997334c20c8a02b8d8be329e8c31927538", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25289/mbox/", "series": [ { "id": 5630, "url": "https://patchwork.libcamera.org/api/series/5630/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5630", "date": "2025-12-02T13:31:31", "name": "GPUISP precursor series", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5630/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25289/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25289/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EBE9BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:32:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8049F60C90;\n\tTue, 2 Dec 2025 14:32:09 +0100 (CET)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DBD360C7C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:32:04 +0100 (CET)", "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-477619f8ae5so38509275e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:32:04 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:03 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"wuMWU6Wx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682324; x=1765287124;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CzxKgbIUkNM+BfaM3eBJB+kd44Z0ws3zBBlfjb3fc6Q=;\n\tb=wuMWU6WxmGfpAiOcGKdnlxkrrWyg6S9R8STOdP0674gz8amPIa1tpGNMSlJhkOXSe+\n\tJCTeOdidPtIx/ozMDHs/1FgX7UZWp1uONnDCt/rk8ycccVBtov0sQuI1bQpRm+qAO+w2\n\tNCZ1N3tF8m2DZmss0Np0KI43y8YTCvNgxamGiCdR6pH0ScZa5ZjCAjaSqApWaFReDuKT\n\tgHBmxS+uxPUsEMPz0DYtGFVRuC0j7aHAngaVN5xzK5Tq5XcmU79z4ET4f9517osxVlSr\n\tfyEdDb30zs0HjzmTB3FJUuFg84KKDZGnyD733j+YhYw1kwH2eCOYcnjppe0HYrKF3kLx\n\tEX9g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682324; x=1765287124;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=CzxKgbIUkNM+BfaM3eBJB+kd44Z0ws3zBBlfjb3fc6Q=;\n\tb=si41N3aXxMkhEmFHoAsKGZWcIeyUX6s+SSRzryWJmVAorArpEPj0P8EN/hgPqPJjym\n\tdRkfrGeLRnMKiEyceQ/Oo1SPsHp+VbiUE5k2dmQAEYNfh0HwPMWFXo2iM7olveeVKanB\n\tr+qqJq6pxT8BOh+/N+L9NMgohWqAyn4BMWY9akdsDw1UoWqTXObglhycILrCPbXOmP7P\n\tKzSaH/wixY0CY8201CX02WT0ykmgSRFNxVE2wb0WFvxHzfXrU1rGrhHuTfpJgwTiJvXQ\n\tHMcUXT5g0fE+Z8+W/wsPiNM0velxG0ALcF3R6TVfoBv2URaboDJ+QgjJjuTT/MPOCBsR\n\tYwaQ==", "X-Gm-Message-State": "AOJu0YzY/mKTyGyMtBCgqFX31F9b8xXGUho7HvT7zvjC+5+4ezuBtgSy\n\tx6agOndrBNBhtN+x1HsHS3/udMKovfXpvuvKNclZqnkezGs2MMwj0zsROvR6azoAvd0YwUj05vh\n\t0unAP", "X-Gm-Gg": "ASbGncsa5LFYkNKUvAyU79kNT3fimHarYKoAhqLjbRM5la3RgCLVe46jjHpXOpoB62s\n\toKJApdUBtUHTfHHNhJtqhCazKZqwO1RrZy0xnRkh9b3x72+E2FOidL/T+MI26MkdDT3ydSVjlnK\n\talcSljjYmMF/0JUhsjXc0PWDrLx+8+GoS4XhOvWwLlQXX2wg18jhZPYI/kh7TaBZwAIFzFhinvR\n\teDR4x5ohbKd35rEdniYy/VF4nGZnTJBsJ9qS3sH5SuZC9sZXz1vXIIRb3wfYgS+bN36rKkommze\n\tdP3glGYJrlZHs6DnJJIu7EeJtSEFzGFRDg2uQ0+8ZekIe0o1vi85VOdhxdbzTtP7LJEFwqkFWG1\n\tNfUdK95OA+eMvyi+cTm3tpri2rdZyLPUQ0yQhwMbiqgiIA7ZRPTGAIDmdI8zG8LlQsPJNgYvVlb\n\tD7CUl3wOIfpjG2n7sc5ao2vBer7SAxqvv4B/am0wK62GobCzlAztE+4exApmCWqpiT6d4=", "X-Google-Smtp-Source": "AGHT+IEocgbaTzgsj6kQhUGnEvNjtNF7bate3Ak9XrknE2ZaR2EgXQ5gNgecTptCFrk/paovlK1Mug==", "X-Received": "by 2002:a05:6000:22c9:b0:42b:2eb3:c910 with SMTP id\n\tffacd0b85a97d-42cc1cd9466mr44452320f8f.3.1764682323814; \n\tTue, 02 Dec 2025 05:32:03 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 03/22] meson: Automatically generate glsl_shaders.h from\n\tspecified shader programs", "Date": "Tue, 2 Dec 2025 13:31:34 +0000", "Message-ID": "<20251202133157.661407-4-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "References": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Encode the bayer shader files into a header as part of the build process.\nQcam already compiles the shader files down into a QT resource file which\nit references internally.\n\nIn order to share the debayering shader programs outside of qcam create a\ngeneric header which both qcam and libcamera can operate from.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/meson.build | 11 +++++++++++\n src/libcamera/shaders/meson.build | 10 ++++++++++\n utils/meson.build | 2 ++\n 3 files changed, 23 insertions(+)\n create mode 100644 src/libcamera/shaders/meson.build", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 34e20f557..90d434a5a 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -76,6 +76,7 @@ subdir('ipa')\n subdir('pipeline')\n subdir('proxy')\n subdir('sensor')\n+subdir('shaders')\n subdir('software_isp')\n \n libdl = dependency('dl')\n@@ -182,6 +183,16 @@ libcamera_deps += [\n libyaml,\n ]\n \n+# Generate headers from shaders\n+libcamera_shader_headers = custom_target(\n+ 'gen-shader-headers',\n+ input : [shader_files],\n+ output : 'glsl_shaders.h',\n+ command : [gen_shader_headers, meson.project_source_root(), meson.project_build_root(), '@OUTPUT@', '@INPUT@'],\n+)\n+\n+libcamera_internal_headers += libcamera_shader_headers\n+\n # We add '/' to the build_rpath as a 'safe' path to act as a boolean flag.\n # The build_rpath is stripped at install time by meson, so we determine at\n # runtime if the library is running from an installed location by checking\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nnew file mode 100644\nindex 000000000..386b342d0\n--- /dev/null\n+++ b/src/libcamera/shaders/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+# List of shader files to convert to header hex\n+# for the purposes of inclusion in OpenGL debayering\n+shader_files = files([\n+ 'bayer_1x_packed.frag',\n+ 'bayer_8.frag',\n+ 'bayer_8.vert',\n+ 'identity.vert',\n+])\ndiff --git a/utils/meson.build b/utils/meson.build\nindex 95d657ac9..3deed8ad4 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -3,5 +3,7 @@\n subdir('codegen')\n subdir('ipu3')\n \n+gen_shader_headers = files('gen-shader-headers.sh')\n+\n ## Module signing\n gen_ipa_priv_key = files('gen-ipa-priv-key.sh')\n", "prefixes": [ "v3", "03/22" ] }