Patch Detail
Show a patch.
GET /api/patches/25246/?format=api
{ "id": 25246, "url": "https://patchwork.libcamera.org/api/patches/25246/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25246/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127023739.179652-10-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:37:24", "name": "[v5,09/24] libcamera: shaders: Add support for Gamma", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "04bf695fdca5d4be73e3c2aec1d36a542b4f01d8", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25246/mbox/", "series": [ { "id": 5617, "url": "https://patchwork.libcamera.org/api/series/5617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5617", "date": "2025-11-27T02:37:15", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25246/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25246/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09AEEC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:38:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4AEF60AA0;\n\tThu, 27 Nov 2025 03:38:08 +0100 (CET)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6E4D60A86\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:38:06 +0100 (CET)", "by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-4775ae77516so3296355e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:38:06 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:05 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"O1+BvDT6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211086; x=1764815886;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZkyPq4yV0BnWPF44d9dM8L8EGZ/L/3PzRMm8vBWSZ0k=;\n\tb=O1+BvDT6i9SG2Cs7My5pApMdwE4NWQaYNuvqs3jqgXlfiiToKOI1l87MqLV+HEvavb\n\toGYf+q4Ty8kJx5VDHZyt1eXMKCCNaU5EtMIzDLi9vqPz3BiPAayf2jwIQG8iaonszLtl\n\tJSbTEk9v2gBvhvnjNqe+FCEpfhdbWWD6WSStrMPLLVhFPSlrS+7dgwidIdThNLceklU3\n\tbikvHL2kKBqeUJO3gHUPCrYDyxGB7q9t3jKBkILIKYYbZ9XG4OU57kXxl/ytjp2Cymo0\n\tRjq2syYH3TB1HOs37ybHk39nt5IOLk4F+azUE9Nkpi4zoG5hgUekGazT8dax7lAfCtQk\n\tTA+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211086; x=1764815886;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZkyPq4yV0BnWPF44d9dM8L8EGZ/L/3PzRMm8vBWSZ0k=;\n\tb=IVwybg27a9T2+OQHK2Vf0wXqt62DL2E1CONWNprvr2KvNyd8ryJTe9Y0EvKPZH89QF\n\tIhjKIVa0OB8V3FyQJeL1e4JEEqoV8plSOdVaan7zu8T6Qw8buCK5XNN5/K8IEbyrZ1Os\n\tg/0kHYoCAuR138rBXPVo1yBNA3rJjfgR3lny5qs+jtH0NscGz7vuBxZjOV/APHyK3UDN\n\tFAfXQFD5Jv3DRftVGA65i814Atg0LtWV/HtmZjc6zb9IPOmoOZeXT/3Dh8Z8rPmzmXbR\n\td99XrMVmnXblws0tMPoGtuYLs9MEhue4L4awd0C5ChXFlu+R6J0uadpJxOnWDeAwrXLC\n\tJlHw==", "X-Gm-Message-State": "AOJu0YxDs8dAYSgWC3zPBjjXA/VI7gSyodi3QuppIj0+UXAnmeijzuLh\n\t6AeCQ02jfZ5xvY5DKk1CKsiG3yfuYqeYWKtjXZYOPE1+n5FO6NnSHGe/8C02FzHrNG3UIaYviX9\n\thjxFYTW0=", "X-Gm-Gg": "ASbGncsL1vBSMZGjQLL7cTG+OXU8DeNKfkcKPeKZcX0ReiSj9wQlH4ZHh9aNT1jk+ff\n\tPFavy86vaKlSDsSmo1lYd6d3IVFX+x96wSt4HON7JRkbTQW3UwfeJ/m3p87ITxA2NqQiKYQf3M/\n\tg3flb+1poA7w3UKxWGyx3UVqmtBBTb+2DBNCaTiXnw5kvvahqETqwXhbl0i+TH4qMwfKp9ds4po\n\t/wmrV/SZbabCYA8ja0Shs9Pcnb4087MoJ27vii+hx6SEkT/dKp/df9xVriEZHXfvBICUhGP76Dg\n\tYehBTluVZSq4FNJY9RMUcdBCDmq/Ccj0JTevkXbUEgbVUTDZtk0cRLxB/WhFjPjqR8pEDMRj2XV\n\tV8IFF22rPDhSpnJ81XvAX1A6k27DVUOZGGJ4iL1WRjadtd3kitwddCuS9XXppbnw0a0+a8Nj4nH\n\tBldnZfnnnXLQNfMtoaE3qOAzmwo0UkkppwB9DsUUjWR3MFu9yGRdW9bUiFAqU6MVSU44c=", "X-Google-Smtp-Source": "AGHT+IE0W1RU1Gyhc1RrfQY54hRlrfCJclreb9PIhB6kT/aqGxy+AnSiqnMK4iKTBPoYin2YO/Wlig==", "X-Received": "by 2002:a05:600c:3ba1:b0:475:dd89:acb with SMTP id\n\t5b1f17b1804b1-477c11160cdmr222093625e9.22.1764211086320; \n\tWed, 26 Nov 2025 18:38:06 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 09/24] libcamera: shaders: Add support for Gamma", "Date": "Thu, 27 Nov 2025 02:37:24 +0000", "Message-ID": "<20251127023739.179652-10-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "References": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add gamma compentation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 6bca07b6e..069b880ff 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -70,6 +70,7 @@ uniform sampler2D green_param;\n uniform sampler2D blue_param;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -265,6 +266,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #elif defined(APPLY_RGB_PARAMETERS)\n \t/* Apply bayer params */\n \trgb.r = texture2D(red_param, vec2(rgb.r, 0.5)).r;\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 66cece56b..86bf2c31c 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -29,6 +29,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -160,6 +161,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #elif defined(APPLY_RGB_PARAMETERS)\n /* Apply bayer params */\n rgb.r = texture2D(red_param, vec2(rgb.r, 0.5)).r;\n", "prefixes": [ "v5", "09/24" ] }