Patch Detail
Show a patch.
GET /api/patches/25241/?format=api
{ "id": 25241, "url": "https://patchwork.libcamera.org/api/patches/25241/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25241/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127023739.179652-5-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:37:19", "name": "[v5,04/24] libcamera: shaders: Rename bayer_8 to bayer_unpacked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "35a6d78fdb97510d821282384ecb89af3e2b1926", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25241/mbox/", "series": [ { "id": 5617, "url": "https://patchwork.libcamera.org/api/series/5617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5617", "date": "2025-11-27T02:37:15", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25241/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25241/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30ADEC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:37:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3FDF60AB1;\n\tThu, 27 Nov 2025 03:37:56 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8E62609DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:37:54 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-47796a837c7so1861955e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:37:54 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.37.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:37:53 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"TdpOOZze\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211074; x=1764815874;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=H5BShESTnB/MbwTFxOodjFsYW/bRikVrhmyhH5umiF8=;\n\tb=TdpOOZze7obc7NMTqFuM+WwvQkHO980oM7GUTLJ2GFvT71iI5ivvZGhaXRzcGeyj2J\n\t1HuaF+GSC1AZdhBZMzVrikTIaQrvE38lQ/lTf5Qnj01lIi+ksmfBz9VYjbCa1ayus/0k\n\tkyJIUjrSZKygIe9du/G3fzE3LBe8+yRByE0uTvn0bGHNf+Pu3cSYfyCGphzO9WTFr37Q\n\tsPW8zWdd2UGxg2+D5g43/k/M6AB7s0XYnpPIEEcKyJu70g1r8DyJqKOPZqrk/EaJZmsA\n\tq4ZldhbNNYxeXcKJTWouTfj84JmLx9RaP5i8F9fpJddIaFlcpNQaNQ+0qVk8umSkyHH8\n\tB+3A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211074; x=1764815874;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=H5BShESTnB/MbwTFxOodjFsYW/bRikVrhmyhH5umiF8=;\n\tb=uQaVw+IEGM0RPdjZM21MkqxerKrWogRHVehZQA4otsvTaaOo638/1UkW/50GI+4rPJ\n\tYPfcKKmMnucf8w/mMOWyTueOzaiJ12VLoUUSwkvTezndv2r5mYrtmmrmzeuKjhJLj5XC\n\tGzfB9m65IWfd3NlAZG+H/vAAcVzDFqKCYJthDXx7/ZGEt4iVgWJt3IkIR/BJkzMyuAv1\n\tvI/KhdtOCLDIC/LqMHWrdwXwlfANGeijnAByRUfiKYyU4VObW6HWiDcHz0s+huk3YHYj\n\tPV95LWXzm5kWgbGTokrR0MPJ1x2D7J7z5fnfDG2AoK8kc/+akaEB05t51eaUWFDguThg\n\teKOg==", "X-Gm-Message-State": "AOJu0YzPZ3MxBFA3pTWYkVQSZhAvr7Oq/eRfPl3ZEOKkkmJxcxQ9yAI2\n\t/dKp5rslQU/hZsk//aC6eD/4Qg/PKQo7x91DS9OZjd+EW8bAcYAmvyBePAmaD0So/Pv9R4W5+FO\n\tukZ5zzes=", "X-Gm-Gg": "ASbGncup4arawJTadrCdchE2Ved51QylpGUAsv/zAooklEOxc8/UNie4LehoWgHZngG\n\t7G73eKV6V5he0MO0QSjJBKgFNTBhNDAERMUhP31nO++yrANgc1hOEyYHGNYOXjdyoPhzUNdktsR\n\ttlpiJaiCLczphMAsw8sPbWLDoDD8qb6bJBlUWovv/Fb4liwOVdaDTb8/eg+XfNJrodDsYB8lYBo\n\tYmUBik+ZKkAjr49lm6eTiJg9WouZ7iUqCL8lubOMuKIF9iXj2qgidQ8yP3CW1tGHAWM/vNWnm9L\n\toYVixO1WStzpT0IHB5wm3MKFWtxr9heEGcxRKS5jwInJbU7TpM3uAr/siRW5DX0vcHOPNJvqVcQ\n\tMu3PIjptUq8OJ51ZZvolxrDbF589XZ8YneEnDCF1vmXAPhqiW9VuScqR2Q83dAwNdLFtZAJJnDS\n\tEEzJKrIcmrOZjo8hBEuz+zrHvWjQiLDNyo9+iDRxu6+YAzqrtE93xZv69igH81HteOm+Uz22E1e\n\taD1NA==", "X-Google-Smtp-Source": "AGHT+IEL/kmIbL+KeAF1if82xyP20U6ve1NzbERLhte1Yh7aUs38gS7/IjndlaaXMmUVHPF8dM6MHg==", "X-Received": "by 2002:a05:600c:2296:b0:477:73e9:dbe7 with SMTP id\n\t5b1f17b1804b1-477d24871d6mr86409195e9.35.1764211073989; \n\tWed, 26 Nov 2025 18:37:53 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v5 04/24] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked", "Date": "Thu, 27 Nov 2025 02:37:19 +0000", "Message-ID": "<20251127023739.179652-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "References": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)", "diff": "diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t<file>../../../../../src/libcamera/shaders/YUV_3_planes.frag</file>\n \t<file>../../../../../src/libcamera/shaders/YUV_packed.frag</file>\n \t<file>../../../../../src/libcamera/shaders/bayer_1x_packed.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.vert</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.frag</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.vert</file>\n \t<file>../../../../../src/libcamera/shaders/identity.vert</file>\n </qresource>\n </RCC>\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 1554c94d5..b0c8ecaf8 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n", "prefixes": [ "v5", "04/24" ] }