Patch Detail
Show a patch.
GET /api/patches/25219/?format=api
{ "id": 25219, "url": "https://patchwork.libcamera.org/api/patches/25219/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25219/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-6-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:37", "name": "[v2,05/22] libcamera: swstats_cpu: Drop patternSize_ documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "59741e75c523b0031de9169f512623c1b3987ba1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25219/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25219/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25219/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45F5FC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E322A60AA9;\n\tThu, 27 Nov 2025 03:23:17 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB6860AA9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:14 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-47775fb6c56so2184105e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:14 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:12 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"b3FKNia/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210193; x=1764814993;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=;\n\tb=b3FKNia/pTL8Gzzs3m6538qLSVZViF3rBTyjAJNBXrWpzc4ir5Lo2bLxgw9o6PkuZ+\n\tqXLZy8Mu3hJEfswJwEH6xr9aC6GmTPlSIUOckP6dI+uh+c/oLNMEH8HkDvi6X0bmZPHq\n\tax8HwH14llrsfYK6NO6aBEY6FxCYRyFVs0FuBY3ue+roekO+t0kr2oFasCg6HDSeY6Ko\n\tNbb2TgiQJe/3BWB6LRKWvorbgnBTyUOJp2hrmFT6Yia7gxIeAP9DauBSkO3jIncF93yd\n\tvp64cWx2lwM6WhQ+gSdnzBXH6MYluNxb6i79WMAPqUQdyB4V8g+Kb1IVKoCXDcB7Tc7j\n\tOVbw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210193; x=1764814993;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=J/rNUy6IT8Dq/gobx75Pygy+h2VMr98GtCcoWBBrzZU=;\n\tb=a4jNbat7gkavwi8g+Whti/bF5EquB7N6QzPyVt/gWpF3GrPqIt7nf9vaRNcyxEEl5J\n\tndgRJ28Nv0MVEo+gHVp3zvb+GbNv0Wauy6T6WiZzRhFYBOWz5O1wdBd4bzM3JIdcWiyi\n\t+ubfhM3sBmIQuvgn8zBtjmkZ3pJr/qyr6hpvP5gijwFXH5gQkNSh1ClltqUkRLkc6VHX\n\t9Pbw2icet6BWvkKmuRG4D88VsJpNDLpa0tu6TgM9HLTXdEe8v935mEWtCxE9DdkYDTZE\n\tRp5b5TnT6tuPkckst8jkl+03AGVfuPEJ7/+CPE+k0tPgqn8n4T40wxI7Q+1YTcxuwZqk\n\tI47Q==", "X-Gm-Message-State": "AOJu0YzgLtr6Xqq+d39uZR1i35NC+Ogjhcd9PmHVs/6jsznulYGBjD+x\n\tuhsk3/fzmCZIjRxy+eSzqXDqnt6ZJv8AKmPSSPjBGP2DCby6Y+iy3AV2xsjxPCUbWXpj4iik1p0\n\thr3kXbDs=", "X-Gm-Gg": "ASbGncvbJE9seKIIm00DJOHoFVKzxJo6+kU/tEpp2z5y7TpkciMvB+AadPXxLoWKSD4\n\towt7sNrL3l5o22VXLQzSNki/yIU+szidb09ANS2MUdYiHfdBHIeMmlDeRs2twPazGkr/UHJA81+\n\tZdPx1ilryK2qXByma2tQVQ21D4zp5pZAQBsszbRx8V5B/qfdP4tP0OJ1hR+yB443/JVFcLpTahR\n\tzLzFexMnAnCXecNkc5WKZ32eH7WvmmA8BYOUhjxrxKBDPl6pzipUOuMfKf5xioQznKQ5aerfpR6\n\teI9fW70JlVBuAZqjDy2Ks1p3eWOYzgfHcsxCZVLfelPbJw9/w6OcUZct4BZ0TqQcV8/bEo6I86E\n\t7KbPwmVz8WajbDGTZ6dBkrDRZW9XGWNwY9spF7H//e2h/s6bgiU7M5nx8Fa80hePytd403pr64D\n\tZLPyGl0g+K66RN2eTJIgBh+qCk8MO/YI5aumYAQNQWo10EgMaEErY7x+akt9PAd3Mc160=", "X-Google-Smtp-Source": "AGHT+IG+4HDeeBVqUG2ryDEThUnIMvZatnZ5f5PM9BLVIoidVrjQyXDW4ExQUOkiA7TrK1Buyc0pDg==", "X-Received": "by 2002:a05:600c:35c6:b0:477:a36f:1a57 with SMTP id\n\t5b1f17b1804b1-47904acae1fmr99492535e9.3.1764210193528; \n\tWed, 26 Nov 2025 18:23:13 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v2 05/22] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation", "Date": "Thu, 27 Nov 2025 02:22:37 +0000", "Message-ID": "<20251127022256.178929-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a0..1b33ffa71 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n", "prefixes": [ "v2", "05/22" ] }