Patch Detail
Show a patch.
GET /api/patches/25200/?format=api
{ "id": 25200, "url": "https://patchwork.libcamera.org/api/patches/25200/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25200/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125162851.2301793-22-stefan.klug@ideasonboard.com>", "date": "2025-11-25T16:28:33", "name": "[v3,21/29] libcamera: internal: camera_sensor: Add accessor for mountingOrientation_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f710b2a139a27e5396522d93ea4ab28c7a7e7adb", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25200/mbox/", "series": [ { "id": 5613, "url": "https://patchwork.libcamera.org/api/series/5613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5613", "date": "2025-11-25T16:28:12", "name": "Full dewarper support on imx8mp", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25200/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25200/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0204EC333C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 16:29:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B715A60AA9;\n\tTue, 25 Nov 2025 17:29:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0585E60AA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 17:29:57 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 11EB218CB; \n\tTue, 25 Nov 2025 17:27:48 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RbZ0nz3r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088068;\n\tbh=ixG83Iqpe2OIzb2G9wcrpsacCxtaL9lyfr55i2vN5vw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RbZ0nz3ri+u81sgpb/+VxGHPvrb+NeJx0K2GfwC+W+i9mcsb2cuMbEW5UhB54Ltff\n\tpfo6LgvAsPeCLc4BQif+KuUytH3WNIEeqrLjd77KaZjT9Z8m8KgD8ebFXePG3XB+Y1\n\toHliuWcekwZH0qh7cPXakJW2lPMT7H8HnVxTlR10=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 21/29] libcamera: internal: camera_sensor: Add accessor\n\tfor mountingOrientation_", "Date": "Tue, 25 Nov 2025 17:28:33 +0100", "Message-ID": "<20251125162851.2301793-22-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "References": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To properly handle the orientation in the dewarper, the mounting\norientation of the sensor needs to be queryable. Add that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Collected tag\n\nChanges in v2:\n- Collected tag\n- Add documentation\n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/sensor/camera_sensor.cpp | 7 +++++++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 1 +\n src/libcamera/sensor/camera_sensor_raw.cpp | 1 +\n 4 files changed, 10 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex f6ef4df170d4..e6b72d22ac21 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -73,6 +73,7 @@ public:\n \tvirtual int sensorInfo(IPACameraSensorInfo *info) const = 0;\n \tvirtual Transform computeTransform(Orientation *orientation) const = 0;\n \tvirtual BayerFormat::Order bayerOrder(Transform t) const = 0;\n+\tvirtual Orientation mountingOrientation() const = 0;\n \n \tvirtual const ControlInfoMap &controls() const = 0;\n \tvirtual ControlList getControls(Span<const uint32_t> ids) = 0;\ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex 4f2fd2690eb5..05390d1e1b60 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -331,6 +331,13 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable)\n * \\return The Bayer order produced by the sensor when the Transform is applied\n */\n \n+/**\n+ * \\fn CameraSensor::mountingOrientation()\n+ * \\brief Fetch the mounting orientation of the sensor\n+ *\n+ * \\return The mounting orientation of the sensor\n+ */\n+\n /**\n * \\fn CameraSensor::controls()\n * \\brief Retrieve the supported V4L2 controls and their information\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex f9e685a9acc4..39c34200b0ff 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -88,6 +88,7 @@ public:\n \tint sensorInfo(IPACameraSensorInfo *info) const override;\n \tTransform computeTransform(Orientation *orientation) const override;\n \tBayerFormat::Order bayerOrder(Transform t) const override;\n+\tOrientation mountingOrientation() const override { return mountingOrientation_; }\n \n \tconst ControlInfoMap &controls() const override;\n \tControlList getControls(Span<const uint32_t> ids) override;\ndiff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\nindex 8ea4423698cd..759cccafe4a9 100644\n--- a/src/libcamera/sensor/camera_sensor_raw.cpp\n+++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n@@ -94,6 +94,7 @@ public:\n \tint sensorInfo(IPACameraSensorInfo *info) const override;\n \tTransform computeTransform(Orientation *orientation) const override;\n \tBayerFormat::Order bayerOrder(Transform t) const override;\n+\tOrientation mountingOrientation() const override { return mountingOrientation_; }\n \n \tconst ControlInfoMap &controls() const override;\n \tControlList getControls(Span<const uint32_t> ids) override;\n", "prefixes": [ "v3", "21/29" ] }