Patch Detail
Show a patch.
GET /api/patches/25193/?format=api
{ "id": 25193, "url": "https://patchwork.libcamera.org/api/patches/25193/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25193/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125162851.2301793-15-stefan.klug@ideasonboard.com>", "date": "2025-11-25T16:28:26", "name": "[v3,14/29] pipeline: rkisp1: Fix number of buffers imported into the dewarper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5ac7507ae8cf6e7a0d33e1c035a0424192826ab6", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25193/mbox/", "series": [ { "id": 5613, "url": "https://patchwork.libcamera.org/api/series/5613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5613", "date": "2025-11-25T16:28:12", "name": "Full dewarper support on imx8mp", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25193/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25193/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8B8CC333C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 16:29:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 928EE60AB4;\n\tTue, 25 Nov 2025 17:29:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94AF360AC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 17:29:36 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F7D86AF;\n\tTue, 25 Nov 2025 17:27:27 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DsKPn+nv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088047;\n\tbh=h3miCZmgaN6PDBGl9AKd+RDzNgW3R0M2XkJkpFniOyU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DsKPn+nvZcEDXxlDGKwe7sbtZZTAd1M/6lbirqy9gNNjqOhAeAh++PPM9rO/tUlc9\n\tsDW+sE2gzoO8LXMz4+bFT/Wrz95nKg13hw0W26RRYwmhRCvl5dkgYzA5k+BA4yjknk\n\tSVy9NzsPK+P+yQMrJM377HM0mFRdr7zw9K+n2ha4=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 14/29] pipeline: rkisp1: Fix number of buffers imported\n\tinto the dewarper", "Date": "Tue, 25 Nov 2025 17:28:26 +0100", "Message-ID": "<20251125162851.2301793-15-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "References": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the dewarper is used, an addition buffer loop with\nkRkISP1MinBufferCount buffers is created between ISP and dewarper. When\nthe dewarper is configured, it stores the bufferCount value of the\nrequested stream configurations. This number of buffers is then imported\nwhen the dewarper is started.\n\nOn the input stream of the dewarper the bufferCount is currently left\nunchanged, meaning it carries the bufferCount as supplied by the user\ninstead of the bufferCount of the additional loop. Fix that by setting\nthe bufferCount to kRkISP1MinBufferCount.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Added this patch\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 79c8717c839a..138e1d5bf06b 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -954,6 +954,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t\tif (data->usesDewarper_) {\n \t\t\t\toutputCfgs.push_back(const_cast<StreamConfiguration &>(cfg));\n \n+\t\t\t\tispCfg.bufferCount = kRkISP1MinBufferCount;\n \t\t\t\tispCfg.size = format.size;\n \t\t\t\tispCfg.stride =\n \t\t\t\t\tPixelFormatInfo::info(ispCfg.pixelFormat)\n", "prefixes": [ "v3", "14/29" ] }