Patch Detail
Show a patch.
GET /api/patches/25177/?format=api
{ "id": 25177, "url": "https://patchwork.libcamera.org/api/patches/25177/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25177/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125000848.4103786-11-rui.wang@ideasonboard.com>", "date": "2025-11-25T00:08:47", "name": "[v1,10/11] ipa: rkisp1: algorithms: dpf: expose DPF control map", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eea4c9532ea29ead0f46ef9eca9b7d5ff34082c4", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25177/mbox/", "series": [ { "id": 5612, "url": "https://patchwork.libcamera.org/api/series/5612/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5612", "date": "2025-11-25T00:08:37", "name": "ipa: rkisp1: DPF refactor and tuning improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5612/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25177/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25177/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 354E8C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 00:09:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C177660AAF;\n\tTue, 25 Nov 2025 01:09:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A92160AB3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 01:09:20 +0100 (CET)", "from rui-Precision-7560.local (unknown\n\t[IPv6:2607:fea8:935b:7220:cb34:a7b8:53d:5466])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B0E317EB;\n\tTue, 25 Nov 2025 01:07:11 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F+3PjRHh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764029231;\n\tbh=cUkuco0HyARjPcIJhprL+7A1ioaxF2RRM0C2yQDtPxE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=F+3PjRHh7OcM+nVUvo7WP3CM1jckwLLvIkz8hC4RjcufXdZrHLO5LKVCA8a+0tumX\n\t7WIDhMEfb2IrUzaNRIfrYzMaoVnl4wJgbQdRYr4Dg8G62epGoANrS1c7OlTvpzdJFF\n\tvAHB/zRM7yFYqpy/zYiNd1dFHd3XY4rQAxJlJk4U=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 10/11] ipa: rkisp1: algorithms: dpf: expose DPF control\n\tmap", "Date": "Mon, 24 Nov 2025 19:08:47 -0500", "Message-ID": "<20251125000848.4103786-11-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251125000848.4103786-1-rui.wang@ideasonboard.com>", "References": "<20251125000848.4103786-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement getControlMap() to provide the RkISP1 DPF controls with tuning-\nderived defaults. The map includes:\n- DpfMode (auto/manual/disable/reduction mode selection)\n- DpfChannelStrengths (R/G/B strength values)\n- Developer mode controls when enabled:\n - Spatial coefficients (green and RB)\n - RB filter size (9x9 or 13x9)\n - NLL coefficients and scale mode\n- DpfExposure (read-only exposure indicator)\n\nThis control map is registered during init() to expose DPF controls to\napplications.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/denoise.h | 9 +++++\n src/ipa/rkisp1/algorithms/dpf.cpp | 63 +++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 1 +\n 3 files changed, 73 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex f07c14fe..c532b7eb 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -70,6 +70,7 @@ protected:\n \t\t\t\t\t[[maybe_unused]] RkISP1Params *params)\n \t{\n \t}\n+\tvirtual ControlInfoMap::Map getControlMap() const;\n private:\n \t/**< Developer mode state for advanced controls */\n \tbool devMode_ = false;\n@@ -99,6 +100,14 @@ uint32_t DenoiseBaseAlgorithm::selectExposureIndexBand(unsigned exposureIndex,\n \treturn idx;\n }\n \n+inline ControlInfoMap::Map DenoiseBaseAlgorithm::getControlMap() const\n+{\n+\tControlInfoMap::Map map;\n+\tmap[&controls::rkisp1::DenoiseMode] =\n+\t\tControlInfo(controls::rkisp1::DenoiseModeValues);\n+\tmap[&controls::rkisp1::ExposureGainIndex] = ControlInfo(0, 6400, 0);\n+\treturn map;\n+}\n } /* namespace ipa::rkisp1::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex e3293241..a3a8e789 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -84,6 +84,9 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n \t\t\t<< \" mode(s) from tuning\";\n \t}\n \n+\t/* Init controls value from YAML */\n+\tauto dpfMap = getControlMap();\n+\tcontext.ctrlMap.insert(dpfMap.begin(), dpfMap.end());\n \treturn 0;\n }\n \n@@ -690,6 +693,66 @@ void Dpf::logConfigIfChanged(uint32_t exposureGainIndex,\n \thaveLast = true;\n }\n \n+ControlInfoMap::Map Dpf::getControlMap() const\n+{\n+\tControlInfoMap::Map map = DenoiseBaseAlgorithm::getControlMap();\n+\n+\tstd::array<int32_t, 3> strengthDefault = {\n+\t\tstatic_cast<int32_t>(baseStrengthConfig_.r),\n+\t\tstatic_cast<int32_t>(baseStrengthConfig_.g),\n+\t\tstatic_cast<int32_t>(baseStrengthConfig_.b),\n+\t};\n+\tmap[&controls::rkisp1::DpfChannelStrengths] =\n+\t\tControlInfo(0, 255, Span<const int32_t, 3>(strengthDefault));\n+\n+\tif (!isDevMode())\n+\t\treturn map;\n+\n+\tconst auto copyCoefficients = [](const auto &src, auto &dest) {\n+\t\tfor (size_t i = 0; i < dest.size(); ++i)\n+\t\t\tdest[i] = static_cast<int32_t>(src[i]);\n+\t};\n+\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS> greenCoeffs{};\n+\tcopyCoefficients(baseConfig_.g_flt.spatial_coeff, greenCoeffs);\n+\tmap[&controls::rkisp1::DpfGreenSpatialCoefficients] =\n+\t\tControlInfo(0, 63,\n+\t\t\t Span<const int32_t,\n+\t\t\t\t RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(greenCoeffs));\n+\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS> rbCoeffs{};\n+\tcopyCoefficients(baseConfig_.rb_flt.spatial_coeff, rbCoeffs);\n+\tmap[&controls::rkisp1::DpfRedBlueSpatialCoefficients] =\n+\t\tControlInfo(0, 63,\n+\t\t\t Span<const int32_t,\n+\t\t\t\t RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(rbCoeffs));\n+\n+\tint32_t rbSizeDefault = baseConfig_.rb_flt.fltsize ==\n+\t\t\t\t\t\tRKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9\n+\t\t\t\t\t? 1\n+\t\t\t\t\t: 0;\n+\tmap[&controls::rkisp1::DpfRbFilterSize] =\n+\t\tControlInfo(controls::rkisp1::DpfRbFilterSizeValues,\n+\t\t\t ControlValue(rbSizeDefault));\n+\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS> nllCoeffs{};\n+\tcopyCoefficients(baseConfig_.nll.coeff, nllCoeffs);\n+\tmap[&controls::rkisp1::DpfNoiseLevelLookupCoefficients] =\n+\t\tControlInfo(0, 1023,\n+\t\t\t Span<const int32_t,\n+\t\t\t\t RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS>(nllCoeffs));\n+\n+\tint32_t scaleModeDefault = baseConfig_.nll.scale_mode ==\n+\t\t\t\t\t\t RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC\n+\t\t\t\t\t ? 1\n+\t\t\t\t\t : 0;\n+\tmap[&controls::rkisp1::DpfNoiseLevelLookupScaleMode] =\n+\t\tControlInfo(controls::rkisp1::DpfNoiseLevelLookupScaleModeValues,\n+\t\t\t ControlValue(scaleModeDefault));\n+\n+\treturn map;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 86085cf9..e62882f2 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -102,6 +102,7 @@ private:\n \t\t\t\t RkISP1Params *params) override;\n \tvoid prepareEnabledMode(IPAContext &context, const uint32_t frame,\n \t\t\t\tIPAFrameContext &frameContext, RkISP1Params *params) override;\n+\tControlInfoMap::Map getControlMap() const override;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n", "prefixes": [ "v1", "10/11" ] }