Patch Detail
Show a patch.
GET /api/patches/25157/?format=api
{ "id": 25157, "url": "https://patchwork.libcamera.org/api/patches/25157/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25157/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251123202816.3460261-1-rui.wang@ideasonboard.com>", "date": "2025-11-23T20:28:16", "name": "[[PATCH,v1] ] ipa: rkisp1: filter: Fix sharpness enable/disable logic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c1758796152905affe3e613f12180434bb32d483", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25157/mbox/", "series": [ { "id": 5607, "url": "https://patchwork.libcamera.org/api/series/5607/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5607", "date": "2025-11-23T20:28:16", "name": "[[PATCH,v1] ] ipa: rkisp1: filter: Fix sharpness enable/disable logic", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5607/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25157/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25157/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 570A9C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Nov 2025 20:28:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C6B060A8B;\n\tSun, 23 Nov 2025 21:28:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD569608CF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Nov 2025 21:28:26 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.171.85.75])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37017606;\n\tSun, 23 Nov 2025 21:26:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UoimuY8n\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763929578;\n\tbh=40POMfb/Qziu/+9FDbfW/fRo660d+MIkfsa9/2YkZrg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UoimuY8n2La7l3aOMgyskZOHFC0/ExnJrjnqwMgqDujq0E/woWu/ulNO+Ag3rOObK\n\tgwb+TYz2JG0XKGmGBR5HnLqeNH8dglIpyN9I9o/FNinLk8woys+tMd2/MFLXUfCf1O\n\t4xUbBZI1PpqJNX2mjs+aqfY2w5hykVf/00DFnu0M=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[[PATCH v1]] ipa: rkisp1: filter: Fix sharpness enable/disable logic", "Date": "Sun, 23 Nov 2025 15:28:16 -0500", "Message-ID": "<20251123202816.3460261-1-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sharpness enable bit in the filter mode register was not being\ncontrolled correctly based on the sharpness level. Add explicit code\nto enable sharpness when sharpness > 1, and disable it otherwise.\nThis ensures the hardware register is set properly to activate\nsharpness as intended.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/filter.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 8ad79801..017618e4 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -216,6 +216,11 @@ void Filter::prepare([[maybe_unused]] IPAContext &context,\n \t\t\tconfig->fac_bl1 /= 2;\n \t\t}\n \t}\n+\t/* Set bit 0 of the config->mode to toggle on/off sharpness\n+\t * if sharpness > 1, enable sharpness, viseverse disable it\n+\t */\n+\tconfig->mode &= ~(1u << 0);\n+\tconfig->mode |= static_cast<uint32_t>(sharpness > 1) << 0;\n }\n \n REGISTER_IPA_ALGORITHM(Filter, \"Filter\")\n", "prefixes": [ "[PATCH", "v1" ] }