Patch Detail
Show a patch.
GET /api/patches/25144/?format=api
{ "id": 25144, "url": "https://patchwork.libcamera.org/api/patches/25144/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25144/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120233347.5046-21-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:33:44", "name": "[v4,20/23] ipa: simple: Add a flag to indicate gpuIspEnabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e389da87426486dff5b12b760ca3e8ec246863de", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25144/mbox/", "series": [ { "id": 5600, "url": "https://patchwork.libcamera.org/api/series/5600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5600", "date": "2025-11-20T23:33:24", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25144/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25144/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68B76BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:34:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D55360B2C;\n\tFri, 21 Nov 2025 00:34:32 +0100 (CET)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C609160B0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:34:29 +0100 (CET)", "by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-477aa218f20so9456615e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:34:29 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:28 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"hIVrk7IG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681669; x=1764286469;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iNwDqYtrwFynDjTjOkZDZulmG3M2dsjYpQnAK/LBTzY=;\n\tb=hIVrk7IGumWN1kaHw7Pa+N4PbPveAcnZrTxYWIpR1bUYU3mv1qwrNg2D3wr5RxzFZz\n\tkgI5FXcFGgj/l8fbNFUVV8aIB+4tHDjeGlZZkzR3G7z6N+aiPMIF8javq+VsLRD0Y6IZ\n\ttMcMm3IBwRobubHyLskDUrU3ca9lgE8TjQ5raUAa3tN2jUA58qoBUIbtfei2M7dhDOTD\n\tsebtSj8M9K072wZ3DjYwOmiFhLDrZ1z3YtcOXotSOzO00P7X9SHIvvq7dKPVWZYdLPGp\n\txEcJHB6AQ5jGtof9fNhoOT7VqawxZngDI+U9QpO/mkBU/OHPrK5w6mGWGmI5XqjIKFL4\n\tRGpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681669; x=1764286469;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=iNwDqYtrwFynDjTjOkZDZulmG3M2dsjYpQnAK/LBTzY=;\n\tb=qYFm7dq0A5viFADhqsBYk4npMivcIiIAmvLBuF6ba3f3nNq2mXFPMfJUn5/jsrSXIu\n\tnRBMs95u21/0QxYnB7cHOCyiY58FYIlN7f3sIPV8wj5QGqsVZW8Au/n+BstBdpn+4B1M\n\tGxsz7bLauR467EPbaZ1Sottg7+JMQhNeBciZmrb+bYNv7DwwmFVYc6N0Ijwg/xqDNUTd\n\t1z6EN3OUhe9Bsc6Fukr8U2UFw1EA9UeGXz9c3YpgsHuS4Ny6EgvLQy4cIzkrTaWTrTJ2\n\tu4nob4HGE5oOKtXDsRRZ+P2sPwN8XeHdgtSHFwH37fCVIWiV6N1VdMLDGYbfZQcEKUNX\n\tyFAg==", "X-Gm-Message-State": "AOJu0YxDNboiXJsCeGR31q1eQk+SQtkEqiaLzrEDL0R1msoG97rqkz6K\n\tyf4EJYJ32IAVmxGx6T+b4ukNJ4geFzq3FR/7v0Y3Nho3NY2tczsMI1CeHQduAyN5eifcfDlDyqT\n\tPUkCfVyI=", "X-Gm-Gg": "ASbGnctfklBRcNbcqG/LlPa/eMM87ffk9TQm+BsPPJSUONcydhgQPs0rtJO3Jq5gtZm\n\tpuRzAesFxlvKlvk99v2SON4bFlwBIK8M2SPro2CEFEoezcpdMIqiOjOuVMvcOLsmGEuRjyXcuEj\n\tINg96fOU/PscuOuTTprDnnXkL4lRwPpv03WgVRoeakHoWOfAr3l8LoC4usJiI90pdHOTCmczbeT\n\tTkWjVsHK0bgHdk6H9X1iyLJ0rQ/1DWGxpq33bL/FtyeSpDuzq07T83FcHCmWUS5BIFbzJSoqi+6\n\tmfJhBcQQIU1Mq0RkgWBbo2Fd89usUbbxSiXeYY/+cJenpFvX48yEzIjQpnUvd7kjJrv/Iya7TXU\n\tmoKrcQ1vghtSqinJwgI/BjitFgA8fetidPZ4cTy5tTzvphYYICMldpzEM5w7Sw500O7Wq5RQjn7\n\tenlVHKbFQc+lk36A7GXXZUTTLSQSDpy8yIx6jZoA4Sg55PzbS1iFS5SgBVVRoGMsRtXwSP5RVAX\n\toPBGg==", "X-Google-Smtp-Source": "AGHT+IEr4H/IWiEHFlIVyWI5PyR0HKNEGfOBV9nuxkrror6iFpjv7btoXKRNMQHSMrg8E0icV9mvyQ==", "X-Received": "by 2002:a05:600c:4694:b0:477:7a1a:4b81 with SMTP id\n\t5b1f17b1804b1-477c0170599mr3060255e9.9.1763681669131; \n\tThu, 20 Nov 2025 15:34:29 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v4 20/23] ipa: simple: Add a flag to indicate gpuIspEnabled", "Date": "Thu, 20 Nov 2025 23:33:44 +0000", "Message-ID": "<20251120233347.5046-21-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "References": "<20251120233347.5046-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/ipa/soft.mojom | 2 +-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 7 +++++--\n src/libcamera/software_isp/software_isp.cpp | 13 ++++++++++---\n 4 files changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..ab7eeb5d5 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -18,7 +18,7 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n \t libcamera.ControlInfoMap sensorControls)\n-\t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n+\t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled, bool gpuIspEnabled);\n \tstart() => (int32 ret);\n \tstop();\n \tconfigure(IPAConfigInfo configInfo)\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex c3081e306..ee8fb6b03 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -103,6 +103,7 @@ struct IPAContext {\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e..523ff07b3 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -56,7 +56,8 @@ public:\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n \t\t ControlInfoMap *ipaControls,\n-\t\t bool *ccmEnabled) override;\n+\t\t bool *ccmEnabled,\n+\t\t bool *gpuIspEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n \n \tint start() override;\n@@ -96,7 +97,8 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n \t\t\tControlInfoMap *ipaControls,\n-\t\t\tbool *ccmEnabled)\n+\t\t\tbool *ccmEnabled,\n+\t\t\tbool *gpuIspEnabled)\n {\n \tcamHelper_ = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!camHelper_) {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = *gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 9944ca573..7f3f7b0bc 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -130,12 +130,18 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t}\n \t}\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n-\tif (!softISPMode || !strcmp(softISPMode, \"gpu\"))\n+\tif (!softISPMode || !strcmp(softISPMode, \"gpu\")) {\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = true;\n+\t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tif (!debayer_) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n@@ -173,7 +179,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n \t\t\t ipaControls,\n-\t\t\t &ccmEnabled_);\n+\t\t\t &ccmEnabled_,\n+\t\t\t &gpuIspEnabled);\n \tif (ret) {\n \t\tLOG(SoftwareIsp, Error) << \"IPA init failed\";\n \t\tdebayer_.reset();\n", "prefixes": [ "v4", "20/23" ] }