Patch Detail
Show a patch.
GET /api/patches/25103/?format=api
{ "id": 25103, "url": "https://patchwork.libcamera.org/api/patches/25103/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25103/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251120232019.3590-3-bryan.odonoghue@linaro.org>", "date": "2025-11-20T23:19:59", "name": "[02/22] utils: gen-shader-headers: Add a utility to generate headers from shaders", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "272e0b02b0e89ff5247aa2924f3bd52c1f097477", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25103/mbox/", "series": [ { "id": 5599, "url": "https://patchwork.libcamera.org/api/series/5599/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5599", "date": "2025-11-20T23:19:57", "name": "GPUISP precursor series", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5599/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25103/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25103/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9748EC3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Nov 2025 23:20:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4117C60AA0;\n\tFri, 21 Nov 2025 00:20:33 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6224B609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Nov 2025 00:20:29 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-42b32a3e78bso1197199f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Nov 2025 15:20:29 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:28 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GzEj5XeX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680829; x=1764285629;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=9Tia+XY9MrQ6HrF0RJpqLjs2LQN6nlxpbG5nPfwV5EE=;\n\tb=GzEj5XeX5PXmpIPWZXo1OV4H/ev6RtEggqFvxYfJ4k9lpcJL/60s3tNaVgEVjyWYCj\n\tyKeIXxzZ9AlM7A7eykBDixEL2AwcSuQ8qadtha2BQ9xyoFtQC5A3O8Aq9586ZkI/dOeE\n\ttwt8LfO2l+olCJhISRExRjalqbG75HNSJLYyNca3CeQCMp03S/6w4YUb59s4AAy7PkV0\n\tfn7DV/xsfDOg8LJQrbdgNPFgApg+hjKK33HWJyXTDSA5S2Gh8/KAXOrX3QuavgAGm1HZ\n\tvWIollwXWCe+F1LarUJPafWLDz0BAVkbx8nxL2x+yIps6Kj+k/JsvbMveY02zkUvxNQO\n\tRloQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680829; x=1764285629;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=9Tia+XY9MrQ6HrF0RJpqLjs2LQN6nlxpbG5nPfwV5EE=;\n\tb=tg9xSUSuQcClvl4b5qDduhQgfdxNEJ4nI1BQWxLCT8NWyQ+yJVEcvdX/+FJql/8mM1\n\tuTM1cZHO2FpojE89WgO2/P9Vjqvmt6/QOi8FEqIdUU+LNls+gBxAcCu2ESenv/wAXzb+\n\tk+cWbP3ZrMCSG6lySWD6uCYw8bnOC0lOYg8LlP5VAuzpa8moeo8VMddI68/Tx+hJHIhj\n\t6zfIOvMviVTgAA4uxvtLRRDnUfdLoeq3cI3ij2FEuWiCPrPdN0c1q8Edti2DslM3cO2W\n\tduzuX+JAhrMuDcyWCnaM+zQRlfxT4uwH7z7jpYBXKFcT+CUjhVGSqiiqMZqFbJEYsxDN\n\tazjw==", "X-Gm-Message-State": "AOJu0Ywzcg6EjZChp39h1Zr1QhSgXtUEQ/dkb2d9Gr6xP16X2rWI5H0N\n\tsI2DOM6CYMefOTd4HfvsSfjvjXZ8aB29jTpE4QHv/8r561+dahFTPAmIlMu/jd6v0fz7vf0bmBR\n\tvkTE1CWI=", "X-Gm-Gg": "ASbGncsths5qtyCqwAqDMsx6afuRDK7oBozrGY+aeKcVVc9DKXr6uDrN8JnyjnTdBRm\n\t777PrOETlxmocmnDR7LsGB9AsbRv1xPY2i0oMfPC7M9VWs3y2atip8WoqTP6F1+Q1CL/LMjm/2b\n\tn1A7sv3OrLa/Dy0YtOgS+KGWS19Mzalf8kMHhwa96V98En4hy3it7J9Nhi7Kmbq5dURWDKPZIZK\n\tdkgs0+H1C65nHE86sTRdqqNR/8wHedlsVKpIgpYuHJ8QioS+wRLgUA5P6HuUCjp00QtOkCrfH5h\n\tosnb578dH71YkvU9sCMYqriqkj28gi6nO/UffbxuvPBmvKu2fXLxTOJgbN6aao+7yoayKMtjYlJ\n\tiBh7Ok8JKCmxd4g3yfLHvsiqTDvjBHJODB8tb+WXFB4Egu1gy/cH4ono0VKakOkq7T0cV1HvGXF\n\tp5/kTsvtZlUK/0y4DuYA3UEYRzqkctAFIAi6shBB/5Hde7ZquZuYZG+Nl+4LbCLP1k3ow=", "X-Google-Smtp-Source": "AGHT+IEYNYL/5VAIuFh6pckUzAy7H9Z8ahhpX0FRnzspqeRKkwXp/Gslg8UjicPM+9hU9XgXYsS7AQ==", "X-Received": "by 2002:a5d:64e6:0:b0:429:bac1:c7f5 with SMTP id\n\tffacd0b85a97d-42cc1d19907mr73114f8f.44.1763680828720; \n\tThu, 20 Nov 2025 15:20:28 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 02/22] utils: gen-shader-headers: Add a utility to generate\n\theaders from shaders", "Date": "Thu, 20 Nov 2025 23:19:59 +0000", "Message-ID": "<20251120232019.3590-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251120232019.3590-1-bryan.odonoghue@linaro.org>", "References": "<20251120232019.3590-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Two simple script to generate a header that contains GLSL shaders translated\nto C arrays.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n utils/gen-shader-header.py | 38 ++++++++++++++++++++++++++++++++\n utils/gen-shader-headers.sh | 44 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 82 insertions(+)\n create mode 100755 utils/gen-shader-header.py\n create mode 100755 utils/gen-shader-headers.sh", "diff": "diff --git a/utils/gen-shader-header.py b/utils/gen-shader-header.py\nnew file mode 100755\nindex 000000000..6668e648f\n--- /dev/null\n+++ b/utils/gen-shader-header.py\n@@ -0,0 +1,38 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2025, Bryan O'Donoghue.\n+#\n+# Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+#\n+# A python script which takes a list of shader files and converts into a C\n+# header.\n+#\n+import sys\n+\n+try:\n+ with open(sys.argv[2]) as file:\n+ data = file.read()\n+ data_len = len(data)\n+\n+ name = sys.argv[1].replace(\".\", \"_\")\n+ name_len = name + \"_len\"\n+\n+ j = 0\n+ print(\"unsigned char\", name, \"[] = {\")\n+ for ch in data:\n+ print(f\"0x{ord(ch):02x}, \", end=\"\")\n+ j = j + 1\n+ if j == 16:\n+ print()\n+ j = 0\n+ if j != 0:\n+ print()\n+ print(\"};\")\n+\n+ print()\n+ print(f\"const unsigned int {name_len}={data_len};\")\n+\n+except FileNotFoundError:\n+ print(f\"File {sys.argv[2]} not found\", file=sys.stderr)\n+except IOError:\n+ print(f\"Unable to read {sys.argv[2]}\", file=sys.stderr)\ndiff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\nnew file mode 100755\nindex 000000000..ca4f19f07\n--- /dev/null\n+++ b/utils/gen-shader-headers.sh\n@@ -0,0 +1,44 @@\n+#!/bin/sh\n+set -x\n+\n+if [ $# -lt 4 ]; then\n+\techo \"Invalid arg count must be >= 5\"\n+\texit 1\n+fi\n+src_dir=\"$1\"; shift\n+build_dir=\"$1\"; shift\n+build_path=$build_dir/\"$1\"; shift\n+\n+cat <<EOF > \"$build_path\"\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+/*\n+ * Copyright (C) 2025, Linaro Ltd.\n+ *\n+ */\n+\n+#pragma once\n+\n+EOF\n+\n+cat <<EOF >> \"$build_path\"\n+/*\n+ * List the names of the shaders at the top of\n+ * header for readability's sake\n+ *\n+EOF\n+\n+for file in \"$@\"; do\n+\techo \"file is $file\"\n+\tname=$(basename \"$build_dir/$file\" | tr '.' '_')\n+\techo \" * unsigned char $name;\" >> \"$build_path\"\n+done\n+\n+echo \"*/\" >> \"$build_path\"\n+\n+echo \"/* Hex encoded shader data */\" >> \"$build_path\"\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\")\n+\t\"$src_dir/utils/gen-shader-header.py\" \"$name\" \"$build_dir/$file\" >> \"$build_path\"\n+\techo >> \"$build_path\"\n+done\n", "prefixes": [ "02/22" ] }