Patch Detail
Show a patch.
GET /api/patches/2509/?format=api
{ "id": 2509, "url": "https://patchwork.libcamera.org/api/patches/2509/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2509/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200104050947.7673-14-laurent.pinchart@ideasonboard.com>", "date": "2020-01-04T05:09:46", "name": "[libcamera-devel,13/14] test: signal: Test connecting to non-void slots", "commit_ref": "94f62f6b590857e9bcee379aec8e818625aebdf8", "pull_url": null, "state": "accepted", "archived": false, "hash": "9212ab28b3dd9171bc17a5bb708eca3734a9d939", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2509/mbox/", "series": [ { "id": 600, "url": "https://patchwork.libcamera.org/api/series/600/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=600", "date": "2020-01-04T05:09:33", "name": "object: Propagate return value of invoked method", "version": 1, "mbox": "https://patchwork.libcamera.org/series/600/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2509/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2509/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4448460608\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:10:07 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9964A49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jan 2020 06:10:06 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578114607;\n\tbh=Fzd4jZSgzcaD4adAa9bjYFqCaUVOdLkOoPsYlANy21A=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=C70anl/Sa8O2lTyLlOZOp7DjP4awfqg3zBvSYqyArDq018b4sAwHqAdzi0cjom4Kr\n\txL884avRWeMB+ZSiO5e3psj7Cqc4rM5PUtoETHeuOJqQosgVqzjdf95RXfghc/iPaa\n\tRKjgdGghrMFylkTa7g1P8DCI6YfYIt37C/f4s88E=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jan 2020 07:09:46 +0200", "Message-Id": "<20200104050947.7673-14-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>", "References": "<20200104050947.7673-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 13/14] test: signal: Test connecting to\n\tnon-void slots", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 04 Jan 2020 05:10:08 -0000" }, "content": "Test that a signal can be connected to non-void static and member slots.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/signal.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/test/signal.cpp b/test/signal.cpp\nindex 9d8f985d15e5..0054ed5a380d 100644\n--- a/test/signal.cpp\n+++ b/test/signal.cpp\n@@ -23,6 +23,11 @@ static void slotStatic(int value)\n \tvalueStatic_ = value;\n }\n \n+static int slotStaticReturn()\n+{\n+\treturn 0;\n+}\n+\n class SlotObject : public Object\n {\n public:\n@@ -85,6 +90,11 @@ protected:\n \t\tname_ = name;\n \t}\n \n+\tint slotReturn()\n+\t{\n+\t\treturn 0;\n+\t}\n+\n \tint init()\n \t{\n \t\treturn 0;\n@@ -174,6 +184,13 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Test connecting to slots that return a value. This targets\n+\t\t * compilation, there's no need to check runtime results.\n+\t\t */\n+\t\tsignalVoid_.connect(slotStaticReturn);\n+\t\tsignalVoid_.connect(this, &SignalTest::slotReturn);\n+\n \t\t/* ----------------- Signal -> Object tests ----------------- */\n \n \t\t/*\n", "prefixes": [ "libcamera-devel", "13/14" ] }