Patch Detail
Show a patch.
GET /api/patches/25060/?format=api
{ "id": 25060, "url": "https://patchwork.libcamera.org/api/patches/25060/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25060/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251114-exposure-limits-v3-8-b7c07feba026@ideasonboard.com>", "date": "2025-11-14T14:17:03", "name": "[v3,08/19] ipa: libipa: agc: Remove unused accessors", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8c00e9dc3294b2b43bcb9e07a09150427d8cc7f9", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25060/mbox/", "series": [ { "id": 5590, "url": "https://patchwork.libcamera.org/api/series/5590/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5590", "date": "2025-11-14T14:16:55", "name": "libipa: agc: Calculate exposure limits", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5590/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25060/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25060/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1D9CC3317\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 14 Nov 2025 14:17:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41A3560AB6;\n\tFri, 14 Nov 2025 15:17:32 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B7060A85\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Nov 2025 15:17:20 +0100 (CET)", "from [192.168.1.101] (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB79419AD;\n\tFri, 14 Nov 2025 15:15:19 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uUF9nate\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763129720;\n\tbh=MkyAuTFUvynNr2wv/aJybpKRRVV0Ti2Z7sUQF8pUMoo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=uUF9nateHiXmp/cF/cekjyfJnvMjkFDBhJpnRYQ+kJbjtOsndPrDasoSVgqKfua7f\n\tNOEa2zOXaQhp7B95ZVECeFdpWirWTzzpCwBVpqM4gXPbLxYBhSy4kv6G/lDd1xfNCk\n\tAODfCmr8PEmtY1j/ragFTtFNbD/ZlShSFbYmagXY=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 14 Nov 2025 15:17:03 +0100", "Subject": "[PATCH v3 08/19] ipa: libipa: agc: Remove unused accessors", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251114-exposure-limits-v3-8-b7c07feba026@ideasonboard.com>", "References": "<20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com>", "In-Reply-To": "<20251114-exposure-limits-v3-0-b7c07feba026@ideasonboard.com>", "To": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,\n\tRobert Mader <robert.mader@collabora.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2342;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=MkyAuTFUvynNr2wv/aJybpKRRVV0Ti2Z7sUQF8pUMoo=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpFznrF/GZbFsNXTHVwL9B+ZI0WH5EgqHN+Y7QM\n\tyMcjGea5JyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaRc56wAKCRByNAaPFqFW\n\tPMIxEACsUTXA/jehYw0+xrcB1hQnKDfLzFcYxlgq48yWiXJdJuagESRmmlQjPzD0fnbf+iJjdWf\n\tVZJoeNbX6MOqFfbdRCiei22VDdjM5ubkhFSIw+Wkr8+tCxuwmfyve2peSg6mrhj2pP9/1u9eyvs\n\tIXod7wzVSQz+GyBtoJ7nl8HZhLlUTU4/eFpSz3WVFWbWCrxMAGgtet2WN3cWWEM/MOY653Rhh7k\n\to4yEJOZnAwF9mio+g/bfIvkJmwMhzqb7cl8T+0TH9YQFjmnehb+zgtnYv1it3cqiYLQRgNyiSoU\n\tpJNM9pIDeCVJR05iMYQbm/d9ru6+IpJZDarCLyCVo6MrqOIAB/+zGZEq459xHbHzknR77YfceTM\n\t7PC2zH2ZQ6y3jMpRYpvT3/GrUo1iQFJKh9c3zCZdjQjUYr9kK5GmfnDb5dYPj16ZKctDHVqzOd2\n\t+/y+Nm1jTLIGhOMnoPVPDoa57riSV9XH0YgRt5yUplig3uxvfxP/RPxu/ZnkLCpYhkA4xgOFaX0\n\tphriiUPTwrO65bwdcO0a7a6OI9jcEqijjt9OYPOLOjDcKqx4iJamCYxTjhhZcuE3cfbcUXIblvU\n\tk34Xwg+DZEO89iS3SSQ52ky0yBTa4VFplxHXrxXO8cSDUmRXYCTUNhefNC3xF00khljeW3EDhTw\n\tH6rHupaS148sJFw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove unused accessors. They're not only unused but it is not even\nclear what the purpose of accessing the fields is.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/exposure_mode_helper.cpp | 25 -------------------------\n src/ipa/libipa/exposure_mode_helper.h | 5 -----\n 2 files changed, 30 deletions(-)", "diff": "diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\nindex 29e316d9d09181cd65cb08f26babb1a680bee62a..962ce1b1b7503e0f86f3857b484b249cb6383fde 100644\n--- a/src/ipa/libipa/exposure_mode_helper.cpp\n+++ b/src/ipa/libipa/exposure_mode_helper.cpp\n@@ -266,31 +266,6 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n \t\t exposure / (exposureTime * gain * quantGain) };\n }\n \n-/**\n- * \\fn ExposureModeHelper::minExposureTime()\n- * \\brief Retrieve the configured minimum exposure time limit set through\n- * setLimits()\n- * \\return The minExposureTime_ value\n- */\n-\n-/**\n- * \\fn ExposureModeHelper::maxExposureTime()\n- * \\brief Retrieve the configured maximum exposure time set through setLimits()\n- * \\return The maxExposureTime_ value\n- */\n-\n-/**\n- * \\fn ExposureModeHelper::minGain()\n- * \\brief Retrieve the configured minimum gain set through setLimits()\n- * \\return The minGain_ value\n- */\n-\n-/**\n- * \\fn ExposureModeHelper::maxGain()\n- * \\brief Retrieve the configured maximum gain set through setLimits()\n- * \\return The maxGain_ value\n- */\n-\n } /* namespace ipa */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/libipa/exposure_mode_helper.h b/src/ipa/libipa/exposure_mode_helper.h\nindex 968192ddc5af768ae0de58aca6c7230c7b3bd507..f8b7a4aa4800b59459f8fc80f502b83647547f51 100644\n--- a/src/ipa/libipa/exposure_mode_helper.h\n+++ b/src/ipa/libipa/exposure_mode_helper.h\n@@ -33,11 +33,6 @@ public:\n \tstd::tuple<utils::Duration, double, double, double>\n \tsplitExposure(utils::Duration exposure) const;\n \n-\tutils::Duration minExposureTime() const { return minExposureTime_; }\n-\tutils::Duration maxExposureTime() const { return maxExposureTime_; }\n-\tdouble minGain() const { return minGain_; }\n-\tdouble maxGain() const { return maxGain_; }\n-\n private:\n \tutils::Duration clampExposureTime(utils::Duration exposureTime,\n \t\t\t\t\t double *quantizationGain = nullptr) const;\n", "prefixes": [ "v3", "08/19" ] }