Patch Detail
Show a patch.
GET /api/patches/25039/?format=api
{ "id": 25039, "url": "https://patchwork.libcamera.org/api/patches/25039/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25039/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251114005428.90024-10-kieran.bingham@ideasonboard.com>", "date": "2025-11-14T00:54:13", "name": "[v4,09/21] ipa: libipa: Provide Q4.8 FixedPoint support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1df7f2d971f1c882595124900ab6cc68737db8c4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25039/mbox/", "series": [ { "id": 5589, "url": "https://patchwork.libcamera.org/api/series/5589/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5589", "date": "2025-11-14T00:54:04", "name": "libipa: Introduce a Quantized type", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5589/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25039/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25039/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C455AC3263\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 14 Nov 2025 00:55:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3087E60A9D;\n\tFri, 14 Nov 2025 01:55:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1026560AAD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 14 Nov 2025 01:54:51 +0100 (CET)", "from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 827C61AED;\n\tFri, 14 Nov 2025 01:52:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o/vHTcWa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763081570;\n\tbh=N9XX3MGD8XPi40ZBAJ/UtIUyiZ3FR/uTa+qPdmjcRvw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o/vHTcWa4a5+62OQHOVeCC6/nulVJCI+8yWbjXQ/9zcE3Gl6f4pP6I9Ta6D7fWUfh\n\tRWBS3ZakmWPLHPv0keYvNLyCf9l8lOcAAoNQ749OJAoVn1wAHcOl6fiO/BgZZM+ugs\n\tpd/k1cLzC8jE04l96R4qsnlt4gbHkm3zfCClX7Ps=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 09/21] ipa: libipa: Provide Q4.8 FixedPoint support", "Date": "Fri, 14 Nov 2025 00:54:13 +0000", "Message-ID": "<20251114005428.90024-10-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1", "In-Reply-To": "<20251114005428.90024-1-kieran.bingham@ideasonboard.com>", "References": "<20251114005428.90024-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a FixedPoint Quantized type to support the Q4.8 format\nrepresenting values in the range [0 .. 15.9961] with a resolution of\n1/256.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nThis type is used by the Mali-C55 AWB Gains\n\n src/ipa/libipa/fixedpoint.cpp | 9 +++++++++\n src/ipa/libipa/fixedpoint.h | 2 ++\n test/ipa/libipa/fixedpoint.cpp | 5 +++++\n 3 files changed, 16 insertions(+)", "diff": "diff --git a/src/ipa/libipa/fixedpoint.cpp b/src/ipa/libipa/fixedpoint.cpp\nindex a6f8ef351c32..03053668ed79 100644\n--- a/src/ipa/libipa/fixedpoint.cpp\n+++ b/src/ipa/libipa/fixedpoint.cpp\n@@ -139,6 +139,15 @@ namespace ipa {\n * values in the range [0.0, 1.992] with a resolution of 1/128.\n */\n \n+/**\n+ * \\typedef UQ4_8\n+ * \\brief 4.8 unsigned fixed-point quantizer\n+ *\n+ * A Quantized type using 4 bits for the integer part and 8 bits for the\n+ * fractional part, stored in an unsigned 16-bit integer (\\c uint16_t). Represents\n+ * values in the range [0.0, 15.9961] with a resolution of 1/256.\n+ */\n+\n /**\n * \\typedef Q5_4\n * \\brief 5.4 signed fixed-point quantizer\ndiff --git a/src/ipa/libipa/fixedpoint.h b/src/ipa/libipa/fixedpoint.h\nindex 8f095210a918..05dd97e64f40 100644\n--- a/src/ipa/libipa/fixedpoint.h\n+++ b/src/ipa/libipa/fixedpoint.h\n@@ -105,6 +105,8 @@ struct FixedPointQTraits {\n using Q1_7 = Quantized<FixedPointQTraits<1, 7, int8_t>>;\n using UQ1_7 = Quantized<FixedPointQTraits<1, 7, uint8_t>>;\n \n+using UQ4_8 = Quantized<FixedPointQTraits<4, 8, uint16_t>>;\n+\n using Q5_4 = Quantized<FixedPointQTraits<5, 4, int16_t>>;\n using UQ5_8 = Quantized<FixedPointQTraits<5, 8, uint16_t>>;\n \ndiff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex c830b5f05a19..f3773dfe6ad4 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -190,6 +190,11 @@ protected:\n \t\tfails += quantizedCheck<Q4_7>(-0.4f, 0b1111'1001101, -0.398438f);\t/* 0x7cd */\n \t\tfails += quantizedCheck<Q4_7>(-1.4f, 0b1110'1001101, -1.39844f);\t/* 0x74d */\n \n+\t\t/* UQ4_8(0 .. 15.9961) Min: [0x0000:0] -- Max: [0x0fff:15.9961] Step:0.00390625 */\n+\t\tintroduce<UQ4_8>(\"UQ4_8\");\n+\t\tfails += quantizedCheck<UQ4_8>( 0.0f, 0b0000'00000000, 0.00f);\n+\t\tfails += quantizedCheck<UQ4_8>(16.0f, 0b1111'11111111, 15.9961f);\n+\n \t\t/* Q5_4(-16 .. 15.9375) Min: [0x0100:-16] -- Max: [0x00ff:15.9375] Step:0.0625 */\n \t\tintroduce<Q5_4>(\"Q5_4\");\n \t\tfails += quantizedCheck<Q5_4>(-16.00f, 0b10000'0000, -16.00f);\n", "prefixes": [ "v4", "09/21" ] }