Patch Detail
Show a patch.
GET /api/patches/25024/?format=api
{ "id": 25024, "url": "https://patchwork.libcamera.org/api/patches/25024/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25024/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251113122450.287633-10-kieran.bingham@ideasonboard.com>", "date": "2025-11-13T12:24:44", "name": "[v3,09/14] test: libipa: Provide ScaledFixedPoint tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d470eaf0a5dad044ccec4067d78246bf45f1d438", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25024/mbox/", "series": [ { "id": 5587, "url": "https://patchwork.libcamera.org/api/series/5587/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5587", "date": "2025-11-13T12:24:35", "name": "libipa: Introduce a Quantized type", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5587/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25024/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25024/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AD05C32DC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Nov 2025 12:25:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5ED1360805;\n\tThu, 13 Nov 2025 13:25:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7C0F60A8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Nov 2025 13:24:56 +0100 (CET)", "from Monstersaurus.infra.iob\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57D54BD2;\n\tThu, 13 Nov 2025 13:22:56 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ARCwpB7z\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763036576;\n\tbh=a0T0rNpO96qZ72c43aVQyVLO7b6p8OzoDNxvMb2ivJk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ARCwpB7zGuBDuXng+XU2RqEb33WNgErdl1RLyoelzGRSBKymW97Hobys+RdtU4U2B\n\tEyD0tUO29ChSCieEiYtoTHnMGbzXdUhiGyipU5ssn0OVAAJhK61comX+JCbVbVE9nh\n\tp5fVVyzFnk4TrGyVXWyDVrFYxcuGVxX/c7O0GdbE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 09/14] test: libipa: Provide ScaledFixedPoint tests", "Date": "Thu, 13 Nov 2025 12:24:44 +0000", "Message-ID": "<20251113122450.287633-10-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20251113122450.287633-1-kieran.bingham@ideasonboard.com>", "References": "<20251113122450.287633-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the new ScaledFixedPointQTraits to create a HueQ representing\nthe equivalent scale used by the RKISP1 Hue control to validate\nthe scaling capabilities of the new quantized type.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/ipa/libipa/fixedpoint.cpp | 30 ++++++++++++++++++++++++++++++\n 1 file changed, 30 insertions(+)", "diff": "diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 61ad487fd950..7d1aeebc06da 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -225,6 +225,33 @@ protected:\n \t\treturn TestPass;\n \t}\n \n+\tint testScaledFixedPointQuantizers()\n+\t{\n+\t\tunsigned int fails = 0;\n+\t\tcerr << std::endl\n+\t\t << \"Scaled Fixed-Point Quantizer tests:\" << std::endl;\n+\n+\t\tusing HueQ = Quantized<ScaledFixedPointQTraits<Q1_7::TraitsType, 90>>;\n+\n+\t\t/* HueQ (Scaled Q1_7 * 90) (-90 .. 89.2969) Min: [0x80:-90] -- Max: [0x7f:89.2969] Step:0.703125 */\n+\t\tfails += introduce<HueQ>(\"HueQ (Scaled Q1_7 * 90) \");\n+\n+\t\t/* clang-format off */\n+\n+\t\tfails += quantizedCheck<HueQ>(-90.0f, -128, -90.0f);\t/* Min */\n+\t\tfails += quantizedCheck<HueQ>(-45.0f, -64, -45.0f);\t/* Mid negative */\n+\t\tfails += quantizedCheck<HueQ>( 0.0f, 0, 0.0f);\t/* Zero */\n+\t\tfails += quantizedCheck<HueQ>( 45.0f, 64, 45.0f);\t/* Mid positive */\n+\t\tfails += quantizedCheck<HueQ>( 90.0f, 127, 89.2969f);\t/* Max */\n+\n+\t\tfails += quantizedCheck<HueQ>(-99.0f, -128, -90.0f);\t/* Clamp low */\n+\t\tfails += quantizedCheck<HueQ>( 99.0f, 127, 89.2969f);\t/* Clamp high */\n+\n+\t\t/* clang-format on */\n+\n+\t\treturn fails ? TestFail : TestPass;\n+\t}\n+\n \tint run()\n \t{\n \t\tunsigned int fails = 0;\n@@ -236,6 +263,9 @@ protected:\n \t\tif (testFixedPointQuantizers() != TestPass)\n \t\t\tfails++;\n \n+\t\tif (testScaledFixedPointQuantizers() != TestPass)\n+\t\t\tfails++;\n+\n \t\treturn fails ? TestFail : TestPass;\n \t}\n };\n", "prefixes": [ "v3", "09/14" ] }