Patch Detail
Show a patch.
GET /api/patches/25000/?format=api
{ "id": 25000, "url": "https://patchwork.libcamera.org/api/patches/25000/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25000/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251112082715.17823-3-mzamazal@redhat.com>", "date": "2025-11-12T08:27:10", "name": "[RFC,2/7] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ac9c86f8826622fd9d9726c3b5a09cd420c8bbd", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25000/mbox/", "series": [ { "id": 5582, "url": "https://patchwork.libcamera.org/api/series/5582/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5582", "date": "2025-11-12T08:27:08", "name": "Simple pipeline IPA cleanup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5582/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25000/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25000/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DD8BC32DB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 12 Nov 2025 08:27:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8E7860A8B;\n\tWed, 12 Nov 2025 09:27:30 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56AEE609D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Nov 2025 09:27:27 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-618-Wsnkzed8PeOewHyxSy1ReQ-1;\n\tWed, 12 Nov 2025 03:27:24 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 1FE9D1800350 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 12 Nov 2025 08:27:24 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.149])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DFC291800451; Wed, 12 Nov 2025 08:27:22 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UvpxBjl0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1762936046;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=8ZQnlUEp8MjCfjuSJC9gqY4AhnGFBE8C4/zMTaHd5HU=;\n\tb=UvpxBjl0ZNBMwKzAdsG6YfvCBbv8GcRGQfQVTmYn/1ryi/AJm6mYGZDfLEGfXdK40KGBp1\n\t/NCkR/B17iabgkNnxnYtOZ6eVtbsYelhDPKt3xMPSfnkPWrDqoLdHblGM1nC9ZYI3JtnxY\n\tkHmNK++XygWUC+phSvCIoQkQL/q6ZzE=", "X-MC-Unique": "Wsnkzed8PeOewHyxSy1ReQ-1", "X-Mimecast-MFC-AGG-ID": "Wsnkzed8PeOewHyxSy1ReQ_1762936044", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH 2/7] libcamera: ipa: simple: Unwrap IPAFrameContext::ccm", "Date": "Wed, 12 Nov 2025 09:27:10 +0100", "Message-ID": "<20251112082715.17823-3-mzamazal@redhat.com>", "In-Reply-To": "<20251112082715.17823-1-mzamazal@redhat.com>", "References": "<20251112082715.17823-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "O-2Cc3bJvanoNutjspaZA2iQT0dlcbyWXH5TY78J4v0_1762936044", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The struct has only one member and there is no immediate need to add\nmore. Let's use the member directly, to make things a bit simpler.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/ccm.cpp | 6 +++---\n src/ipa/simple/ipa_context.h | 4 +---\n 2 files changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\nindex 0a98406c1..d7d3dda76 100644\n--- a/src/ipa/simple/algorithms/ccm.cpp\n+++ b/src/ipa/simple/algorithms/ccm.cpp\n@@ -94,7 +94,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \tif (frame > 0 &&\n \t utils::abs_diff(ct, lastCt_) < kTemperatureThreshold &&\n \t saturation == lastSaturation_) {\n-\t\tframeContext.ccm.ccm = context.activeState.ccm.ccm;\n+\t\tframeContext.ccm = context.activeState.ccm.ccm;\n \t\tcontext.activeState.ccm.changed = false;\n \t\treturn;\n \t}\n@@ -106,9 +106,9 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n \t\tapplySaturation(ccm, saturation.value());\n \n \tcontext.activeState.ccm.ccm = ccm;\n-\tframeContext.ccm.ccm = ccm;\n \tframeContext.saturation = saturation;\n \tcontext.activeState.ccm.changed = true;\n+\tframeContext.ccm = ccm;\n }\n \n void Ccm::process([[maybe_unused]] IPAContext &context,\n@@ -117,7 +117,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n \t\t [[maybe_unused]] const SwIspStats *stats,\n \t\t ControlList &metadata)\n {\n-\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.ccm.data());\n+\tmetadata.set(controls::ColourCorrectionMatrix, frameContext.ccm.data());\n \n \tconst auto &saturation = frameContext.saturation;\n \tmetadata.set(controls::Saturation, saturation.value_or(1.0));\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex c3081e306..330fe39cb 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -73,9 +73,7 @@ struct IPAActiveState {\n };\n \n struct IPAFrameContext : public FrameContext {\n-\tstruct {\n-\t\tMatrix<float, 3, 3> ccm;\n-\t} ccm;\n+\tMatrix<float, 3, 3> ccm;\n \n \tstruct {\n \t\tint32_t exposure;\n", "prefixes": [ "RFC", "2/7" ] }