Patch Detail
Show a patch.
GET /api/patches/25/?format=api
{ "id": 25, "url": "https://patchwork.libcamera.org/api/patches/25/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20181204221123.571-4-laurent.pinchart@ideasonboard.com>", "date": "2018-12-04T22:11:23", "name": "[libcamera-devel,3/3] libcamera: Use the logger instead of cout", "commit_ref": "cc7d204b2c51853f7d963d144f5944e209e7ea29", "pull_url": null, "state": "accepted", "archived": false, "hash": "5dd7a7372f3b1b1df2089bcde387041f6044a83a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25/mbox/", "series": [ { "id": 13, "url": "https://patchwork.libcamera.org/api/series/13/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=13", "date": "2018-12-04T22:11:20", "name": "libcamera: Add initial logger support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/13/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2D4D600CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Dec 2018 23:10:53 +0100 (CET)", "from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 774C8591\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Dec 2018 23:10:53 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1543961453;\n\tbh=5CqUjiDVKX4h7W8J0vG8BzWTIMAq2CPRuez/NSGND1w=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=R2af1enrf97TiiNVa8D8fFc7OC5AWiNmsRipw4quqeZvbMfDu8bEgjbRyuj+fBmx1\n\tgycc8K4VtE1o5dpVEY2XoeG9BZjFI/N/rkt31xfvcJ4JkTMvhPHIEtUyZi86AaJexF\n\t1PyDsLnknOuR4ZN7OTWMo0toryhV3FnY3FUVFIwA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 5 Dec 2018 00:11:23 +0200", "Message-Id": "<20181204221123.571-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181204221123.571-1-laurent.pinchart@ideasonboard.com>", "References": "<20181204221123.571-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: Use the logger instead of\n\tcout", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 04 Dec 2018 22:10:54 -0000" }, "content": "Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/libcamera.h | 4 ++++\n src/libcamera/main.cpp | 10 ++++++----\n test/init.cpp | 2 +-\n 3 files changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/libcamera.h b/include/libcamera/libcamera.h\nindex 64857326a0b0..790771b61e41 100644\n--- a/include/libcamera/libcamera.h\n+++ b/include/libcamera/libcamera.h\n@@ -7,10 +7,14 @@\n #ifndef __LIBCAMERA_LIBCAMERA_H__\n #define __LIBCAMERA_LIBCAMERA_H__\n \n+namespace libcamera {\n+\n class libcamera\n {\n public:\n \tvoid init_lib(void);\n };\n \n+};\n+\n #endif /* __LIBCAMERA_LIBCAMERA_H__ */\ndiff --git a/src/libcamera/main.cpp b/src/libcamera/main.cpp\nindex 0059e0c91571..7ed37dfcfd5b 100644\n--- a/src/libcamera/main.cpp\n+++ b/src/libcamera/main.cpp\n@@ -5,13 +5,15 @@\n * main.cpp - libcamera main class\n */\n \n-#include <iostream>\n #include <libcamera/libcamera.h>\n \n-using std::cout;\n-using std::endl;\n+#include \"log.h\"\n+\n+namespace libcamera {\n \n void libcamera::init_lib(void)\n {\n-\tcout << \"Lib Camera Init\" << endl;\n+\tLOG(Info) << \"Lib Camera Init\";\n }\n+\n+};\ndiff --git a/test/init.cpp b/test/init.cpp\nindex 8c8ec9adfb83..278169cdbf1e 100644\n--- a/test/init.cpp\n+++ b/test/init.cpp\n@@ -2,7 +2,7 @@\n \n int main(void)\n {\n-\tlibcamera l = libcamera();\n+\tlibcamera::libcamera l = libcamera::libcamera();\n \tl.init_lib();\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "3/3" ] }