Patch Detail
Show a patch.
GET /api/patches/24964/?format=api
{ "id": 24964, "url": "https://patchwork.libcamera.org/api/patches/24964/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24964/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251104075609.94310-3-antoine.bouyer@nxp.com>", "date": "2025-11-04T07:56:09", "name": "[v5,2/2] pipeline: imx8-isi: Delay ISI routes config to acquire() time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1852abc4252b78d911ed2998527a31841304f7b2", "submitter": { "id": 218, "url": "https://patchwork.libcamera.org/api/people/218/?format=api", "name": "Antoine Bouyer", "email": "antoine.bouyer@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24964/mbox/", "series": [ { "id": 5561, "url": "https://patchwork.libcamera.org/api/series/5561/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5561", "date": "2025-11-04T07:56:07", "name": "imx8-isi: Move isi routing into acquireDevice", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5561/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24964/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24964/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 853A1C3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Nov 2025 07:54:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A15960AA3;\n\tTue, 4 Nov 2025 08:54:56 +0100 (CET)", "from DU2PR03CU002.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 407D0606E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Nov 2025 08:54:53 +0100 (CET)", "from GVXPR04MB9831.eurprd04.prod.outlook.com (2603:10a6:150:11c::8)\n\tby DBAPR04MB7448.eurprd04.prod.outlook.com (2603:10a6:10:1a6::6) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9275.16;\n\tTue, 4 Nov 2025 07:54:51 +0000", "from GVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a]) by\n\tGVXPR04MB9831.eurprd04.prod.outlook.com\n\t([fe80::4634:3d9c:c4a:641a%6]) with mapi id 15.20.9298.006;\n\tTue, 4 Nov 2025 07:54:51 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"m2/g52az\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=iDYrQQVjztjDt7K4FpaPGBe+dhhP9kIqfsg0RngE/PMvYyx+RboNBvQUYgVXWCFnCRalWVKsaA0ucrIuEQbzA4J1LVnsGeZfAHmVQtCncf31VXyracwGRQEKimAE3hBWNlWK63A2N0KmEoqup1vkYK1vlQOf9RfMue5wdYit7583KATDXiXL06aCQdnApibWmKzWFwerUkYpP7ePrM4ogpULYQkbQjfiykAY0vJCee0v74Q0l3EYylWANk/IzgUfbZZLBb320btKZFiKq2ac37RsEtB0OxuqUv40ZU029MOSSD2zAu7tL7qmmR7XWIOLJyKeqrQrkqWi9V2W6wN7+w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=1b49cJk4OUjdjqUcefuMC5NBjxGHx01SkWH6araqw9k=;\n\tb=BsPUsZgsYHZc4Fa2Z7VhLrYzUahp2TzFtKGj1tydyWr0VsA14q9TWpBPWvvTTP+ORfPhWtvr7ThG+gxJ93gv3ktlJXZ+HlVBriLPLh2Z20YDp/63YSlaAxYSV8YvMvYoaSIMfCODuyhFQtvfvigXvDY/7no4woUKKkLdL1mvcciduAEdyqdfKxBGIWybu7L3d+3SnAolqGUqKDVG0LWtAjPIYXOyXSlM0fAgKQwhjVSsH9mC/QG86vnbxi3Y4P8eKzuCZk2uy6SXFTkimV7PQWbE6+YhpZnOjxegKg7VYSQHxFMWMWf9giXYsNKf1qVageZxk4jy5Mjn4R2LeUCwYw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=1b49cJk4OUjdjqUcefuMC5NBjxGHx01SkWH6araqw9k=;\n\tb=m2/g52azR3cqxzPr7X5IhsQlwYmL7tyaRAyGoNjsNScAoggi+eGdutk/GN8bIIlTvkMGf7V/Kjq16uLZ65HpGaNINXIvlL0qwG7iMjOdkWHetN9+4TLWUaIbIyIpivuPAwpLMeY4PowmrUcqk9GFk1T75GctC8iHNesSEq+eqQcIBl3Twi6ONOsoXsBCokNtaMHAq48//KOMdLboeyvkYVeLDZ9zoS2dQAYt9KdsmWUOl/KBsnnTqT6tOcfNFgQmQr7rDvMHzBCyfTF1HWrfROkB/2ioh9Fs92ZnpBqijsHzYnXQb/uBlzKfKm8BioJycF5SL1xtxw1QCb1zE1HE6w==", "From": "Antoine Bouyer <antoine.bouyer@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "julien.vuillaumier@nxp.com, Andrei Gansari <andrei.gansari@nxp.com>,\n\tAntoine Bouyer <antoine.bouyer@nxp.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 2/2] pipeline: imx8-isi: Delay ISI routes config to\n\tacquire() time", "Date": "Tue, 4 Nov 2025 08:56:09 +0100", "Message-Id": "<20251104075609.94310-3-antoine.bouyer@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20251104075609.94310-1-antoine.bouyer@nxp.com>", "References": "<20251104075609.94310-1-antoine.bouyer@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "CH5PR02CA0015.namprd02.prod.outlook.com\n\t(2603:10b6:610:1ed::9) To GVXPR04MB9831.eurprd04.prod.outlook.com\n\t(2603:10a6:150:11c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "GVXPR04MB9831:EE_|DBAPR04MB7448:EE_", "X-MS-Office365-Filtering-Correlation-Id": "896ca975-fa13-438f-15af-08de1b776f3f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|376014|52116014|366016|1800799024|19092799006|38350700014;", "X-Microsoft-Antispam-Message-Info": "2yr9YXKwzAEIzVKcM5de5sOIR3t1rb62rW0/0g6y182D85879GV3CqXcmIWo5blQ7ibu+NvisANc+3EJ6d4IG43XKcu3rXlFDUepoFUDQXMgabOdBQfDmsp3trctiE6JhrPOAAx/s7SiNZakMpML26ER93eyJdG4JBeYpEP5FanAKQbjj0ZNEhQQ2pX5kyEEZRmuEn+TV6x2KwA49CgY8xE/4SFVt74bGL37/e92XcupPwsFUu7hwGUw4ec4TT+5GEe5d6QCWR8xbXZ5Ci5N1mUqUQS3Z93OWrHJ3XD5Ko0ENhsxYoLiD2jCxw3DWFbjZCH6sVpywgzVmPqWBYuw5H4beygWlHOpULjBkXy9AiyZAMcyl/a+66d7iK6PkC55jpCYTDsWWPxh4EACFfKOZoMGTtVY3Hn9pQ+u5KtmVN1CdjB+kqRAc5ewqm01A06GqbOdk4btTk06JDLW/x67bpAyv1CK/x3CdeFBOGuc0++GmLvrkvt1iAMdq3/W85qEj+dRMSSWf3OTxDtusjVCKksTQQDrSM+bCcRSk1vL4cVetX0dAy3XRQ7pBv6dx2fPL2WItShIUkGQyhLjrvYWo1zeTBm28YAE+9bOGzY6Sq1rBbkfWK3yUTAiV36FmuLWCul0PeRTQakKKKuMr195NRYWY3PtLg7yDsCotOsjOWPlDNqYH6LGB2cvpY0QonvDkoYmIUNnlcO6XjJN08eXkkeMrTnQeaOm0XomljXWLotUXK/5Iwtc9RqMGU5rzVp4azxV2h5CzGs8Ka54P5RX/ZbtnMx6m1f7DcqKsaNtiIoQokFHcvTL3EW+iFgLPv6LYyqYoLRHm/SasPwKjjHj6Dl08njBC8IZILWLW8BKRDkLNSid7gSWA29Ano5q0GaG1n/iQjcMEwyvRj1whyhUOve5Diixhov3oX/RI2SmGaJHPcWfleU7iv2oYHno8v+KYejEuQO0zBZsB1IPpNEy7S8vOmDD3xITng3cBNwXryLEjT/l+SV35KLN4IwqS2zIrEo7w8zSVSH24vo3unFJFLJnvlWB1l4/O15kioqKDNGDYr+qa3tup3GcLySZcCcIO4awJBNEWUJCibgndeKI2v4SiDwBTHm2YjqUR+9xf/Lm6sTXe/Q9jhHx9QhrQ2Uwi4JDdXw2j70R0uOYut7EQRzajCjNo7H7YHs62zxNcvArKmnK28Ua4ccsRQe5tRYehNENxfUyjzxv2BwcHUUhF1SCHWs2+8FvKOb8Ixk47wHgIWTpHlAxV/42zsy+jj3/nl+o+I2CrE3D1XmklVDzok1W8/gbavHo6/71hfHHQ+18x87lE08qSzEfs55fa+GrvZXcv6ygMd5EAtmt0/mkkuv1U4DWXnGCWX0OzpSqAOK6awSdlfxr+ILzibJnEc+A0ioN8FPCLTt5gDze7g+Yx7eAVcXFJzcJ/elYagpp++GIbdGHKIkKVaFsSnQ4D3PaUYSjPkmAW7wdZpsT13eIGx9asntZWFi5OtJ8eC/qXhwoqqccHBFm/7+U98KMwzFN", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:GVXPR04MB9831.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(376014)(52116014)(366016)(1800799024)(19092799006)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "RmRAw8PbkA2pvreM/dJ+ysoFBDcjb+TrZPtGpiGVO3nw7OnzyVY++DF92o+vxnZSQjBhNeNmdKq4Dftk6NmaXj5kAilLsn02NEZAxJ+d+cPMMHTVO/FakGUvIO5qZkzcD4I+qixtlNLwUHQAlt9Rsl1mAMHs7Oxiep4cXS6+M+dRi5xmA/PRUJPgZ88RRJtKQiricRn9DOp4aFAV9mDhvzFOUqTkLDcK0KG1Kk1gDknyYLIAZx2/oggg9AwCNNLIn2PmjgyFlufNyEJ1MmI+gJRxep7P9qf5Go2f1j1DzQfoebskGjjxWcuQZSYXLp0FT80bhhmJqXHrI9TxOMuszXtFfK6ALfX/aHJphOO0TThXNUjRstLTCTnJMSQK4TTN73UwoUpLzGrvZTaZJfTVYsWC24WHnN+oevBtO3JsPuMp3bNupuMV5mUeJs4WKOSuPwb3t8Vy7mS0432UDuh8RVp/kp2hOEqLVBxvdHOfWq/GvwaVZkIERnyqmTrYN8yYI4DFOiJAiqRoWOqjWYMwU+Oui3tyKXaCalPGHlqeHCqPrw24MVQdo60F6oKaAksT75GXaHKIyaM1UB/oKbEjb1WHAU1Em+fUTh8WjJR+12ulZCr2l5tOb2X7xzjshFz2eVPrG2kefKSIJfQk9xKupMrBrGt09rUB6U9NC9xNHOZz7meeFpm+uQG3E6a3ZmOIW9oU5GxxrzmqYut84SSa9VMTvx9v9ivDNaxwg80rJ/u12GbAEQTIjTlhknXNyJPK5eSQNghetu9P7Es+lkEvQ7i/tlfKf+XT4Edw/AUxYZnFY/L7P8eY64Y68JGn51FrCoxehT/3MFOLWXViPANKKvBqzFrkdZDIC9Y3zi5Mr/MM5RmHMWzTfS8aqYneWkGnNXoGZT74mr4n0hJ3XDfWTmC2UCC4D/f6I5Uafwda2jy4ipTWDeccTwVrvunGhnyTFb+vBh8nqIDYBrqeEyvB+Pj0XHIY4PjYWQxBrU5PI8Ar0ATqy4rut83iqbXmInGYtF0qN4qgWPUo1WnGRG5nb3+qSFUDB/PgO6KusynpQ/5qXXIX/g7lhj2ddt9sBOsaa8x+PoWvue2KHZbxBMzEBC6gxAxnfONKPwuwOo+HJKz6YhBsDX70ln9nQIwqO4edOAi9XCrhpwUW4Sam/1x2BqUJukp479+ehh++kfb4rmhUclQjfMMPtZ/jSa9KPX5rvA4Pf3ob/kHPY/VCR+tb41MvnJt4d68Hh97d3XnGgxPkDX52cRi6GKm6HWR7BLVaQzwP9TSD7wB5TC8ZXXHLX04UFazqKVNjelzFxBIlA4mAs+frF2+PDEbOMsYG9OIRsS4xUstg2LHxnG2IC1zWsCGUtTj3HIhv4Er58becGm9sRzjoJacu9Pasjj5i58cxzNB1stMRFYBgEscD/g5tCRYmiYyjtxaHbBPZYkfdAobL4nvIhoEOVejpjSDa+aHRO9gh+g/jrUFrNrCmlCyCcMve26Wta6nq0UPFrLDX2bn1/jkNIss9TJ03AjakQjRBj9EUfllL5y9oWwlJXIKZyhvWq8plrSCbqwqZVzMsEi/wfoYCPLwVAbC/k5Gx9DtCbRSFdnXWHH5QZ9oY4DABKw==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "896ca975-fa13-438f-15af-08de1b776f3f", "X-MS-Exchange-CrossTenant-AuthSource": "GVXPR04MB9831.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Nov 2025 07:54:51.7990\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "RPTAPPZtXEfYV3z6w4HFVPUONybqat7HctFpDvWr7I5qfGKX7vmJEYYdr8JZThF/xUKaK4Fe+f3tmMJULU2OnQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DBAPR04MB7448", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Andrei Gansari <andrei.gansari@nxp.com>\n\nFixes behavior when calling 'cam -l' during a live stream from a camera\nin another process.\n\nIssue is that multiple process should be able to list (match procedure)\nthe camera supported. But only the unique process that lock the media\ndevices in order to be able to configure then start the pipeline should\nsetup the routes, graphs, etc.\n\nThus, the setRouting() is to be moved to a PipelineHandlerISI::acquireDevice()\nimplementation to override the default Pipeline::acquireDevice() function.\n\nFixes: 92df79112fb2 (\"pipeline: imx8-isi: Add multicamera support\")\nSigned-off-by: Andrei Gansari <andrei.gansari@nxp.com>\nSigned-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 26 +++++++++++++++-----\n 1 file changed, 20 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex de09431cb9b9..ce8d0b35a2a7 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -71,6 +71,8 @@ public:\n \n \tunsigned int xbarSink_ = 0;\n \tunsigned int xbarSourceOffset_ = 0;\n+\n+\tconst std::string &cameraName() const { return sensor_->entity()->name(); }\n };\n \n class ISICameraConfiguration : public CameraConfiguration\n@@ -117,6 +119,8 @@ protected:\n \n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n+\tbool acquireDevice(Camera *camera) override;\n+\n private:\n \tstatic constexpr Size kPreviewSize = { 1920, 1080 };\n \tstatic constexpr Size kMinISISize = { 1, 1 };\n@@ -143,6 +147,8 @@ private:\n \n \tstd::unique_ptr<V4L2Subdevice> crossbar_;\n \tstd::vector<Pipe> pipes_;\n+\n+\tV4L2Subdevice::Routing routing_ = {};\n };\n \n /* -----------------------------------------------------------------------------\n@@ -950,6 +956,19 @@ int PipelineHandlerISI::queueRequestDevice(Camera *camera, Request *request)\n \treturn 0;\n }\n \n+bool PipelineHandlerISI::acquireDevice([[maybe_unused]] Camera *camera)\n+{\n+\tif (useCount() > 0)\n+\t\treturn true;\n+\n+\t/* Enable routing for all available sensors once */\n+\tint ret = crossbar_->setRouting(&routing_, V4L2Subdevice::ActiveFormat);\n+\tif (ret)\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n {\n \tDeviceMatch dm(\"mxc-isi\");\n@@ -1034,7 +1053,6 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \tunsigned int numSinks = 0;\n \tconst unsigned int xbarFirstSource = crossbar_->entity()->pads().size() - pipes_.size();\n \tconst unsigned int maxStreams = pipes_.size() / cameraCount;\n-\tV4L2Subdevice::Routing routing = {};\n \n \tfor (MediaPad *pad : crossbar_->entity()->pads()) {\n \t\tunsigned int sink = numSinks;\n@@ -1104,7 +1122,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \t\t/* Add routes to the crossbar switch routing table. */\n \t\tfor (unsigned i = 0; i < data->streams_.size(); i++) {\n \t\t\tunsigned int sourcePad = xbarFirstSource + data->xbarSourceOffset_ + i;\n-\t\t\trouting.emplace_back(V4L2Subdevice::Stream{ data->xbarSink_, 0 },\n+\t\t\trouting_.emplace_back(V4L2Subdevice::Stream{ data->xbarSink_, 0 },\n \t\t\t\t\t V4L2Subdevice::Stream{ sourcePad, 0 },\n \t\t\t\t\t V4L2_SUBDEV_ROUTE_FL_ACTIVE);\n \t\t}\n@@ -1116,10 +1134,6 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \t\tnumCameras++;\n \t}\n \n-\tret = crossbar_->setRouting(&routing, V4L2Subdevice::ActiveFormat);\n-\tif (ret)\n-\t\treturn false;\n-\n \treturn numCameras > 0;\n }\n \n", "prefixes": [ "v5", "2/2" ] }