Patch Detail
Show a patch.
GET /api/patches/24957/?format=api
{ "id": 24957, "url": "https://patchwork.libcamera.org/api/patches/24957/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24957/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251103213014.62713-4-uajain@igalia.com>", "date": "2025-11-03T21:30:14", "name": "[v4,3/3] gstreamer: Track RequestWrap's GstBuffer using GstPad", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9de6350e0e4f0f9aabe6b8e0c99adfa2ccf5e747", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24957/mbox/", "series": [ { "id": 5559, "url": "https://patchwork.libcamera.org/api/series/5559/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5559", "date": "2025-11-03T21:30:12", "name": "gstreamer: Assorted fixes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5559/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24957/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24957/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF34FC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Nov 2025 21:29:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A817360A9D;\n\tMon, 3 Nov 2025 22:29:46 +0100 (CET)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91CAE60A80\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 22:29:43 +0100 (CET)", "from [81.140.124.245] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vG27S-0013tS-QQ; Mon, 03 Nov 2025 22:29:42 +0100" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"b7Yk6EvQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=CnC0/1uAbE7yMbEwOPuIdEUN5t/5It+svlclkEm+FRc=;\n\tb=b7Yk6EvQKrpT1GnL9/tlOkh5aW\n\tzDdWSls0MmOuGQeFIiXs1GCeFhvgKeEZ5P/irelow6mhEu/Y47HZj8cuMbt8zi5aEo05Fkd9FzX6L\n\tNYYnjnguWgVgjOslvA2/EOBLeAQDDO1PxstX3KbnG2P4cJV3KIFyGr1ofQ9JuxCxWWDhJd0hUcNV4\n\t4MbJ0gXI0MHIJ4l0HTYH1T06/TsSmffT5w3gCAbtnH5XSRdqQuar6ZpCWUxMQd7r9Y2Z61LedGAtg\n\ttPWJqYsEudTrzOPJZ2gDQD8rh2eEevm7CyreBrpnJECTtcW70Z58rWP733joL3090XWztweOf/QRL\n\tFAMOe3Dw==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tUmang Jain <uajain@igalia.com>", "Subject": "[PATCH v4 3/3] gstreamer: Track RequestWrap's GstBuffer using GstPad", "Date": "Mon, 3 Nov 2025 21:30:14 +0000", "Message-ID": "<20251103213014.62713-4-uajain@igalia.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251103213014.62713-1-uajain@igalia.com>", "References": "<20251103213014.62713-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "GstPad is the link point where the buffers are pushed/pulled in the\ngstreamer pipeline hence, it makes more sense to associate and\ntrack GstBuffer(s) using GstPad rather than libcamera::Stream in\nRequestWrap.\n\nNo functional changes intended as there is only one stream per pad\nconfiguration followed in libcamerasrc.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 5443b062..391b228d 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -48,11 +48,11 @@ struct RequestWrap {\n \tRequestWrap(std::unique_ptr<Request> request);\n \t~RequestWrap();\n \n-\tvoid attachBuffer(Stream *stream, GstBuffer *buffer);\n-\tGstBuffer *detachBuffer(Stream *stream);\n+\tvoid attachBuffer(GstPad *srcpad, GstBuffer *buffer);\n+\tGstBuffer *detachBuffer(GstPad *srcpad);\n \n \tstd::unique_ptr<Request> request_;\n-\tstd::map<Stream *, GstBuffer *> buffers_;\n+\tstd::map<GstPad *, GstBuffer *> buffers_;\n \n \tGstClockTime latency_;\n \tGstClockTime pts_;\n@@ -65,32 +65,33 @@ RequestWrap::RequestWrap(std::unique_ptr<Request> request)\n \n RequestWrap::~RequestWrap()\n {\n-\tfor (std::pair<Stream *const, GstBuffer *> &item : buffers_) {\n+\tfor (std::pair<GstPad *const, GstBuffer *> &item : buffers_) {\n \t\tif (item.second)\n \t\t\tgst_buffer_unref(item.second);\n \t}\n }\n \n-void RequestWrap::attachBuffer(Stream *stream, GstBuffer *buffer)\n+void RequestWrap::attachBuffer(GstPad *srcpad, GstBuffer *buffer)\n {\n \tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n+\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n \n \trequest_->addBuffer(stream, fb);\n \n-\tauto item = buffers_.find(stream);\n+\tauto item = buffers_.find(srcpad);\n \tif (item != buffers_.end()) {\n \t\tgst_buffer_unref(item->second);\n \t\titem->second = buffer;\n \t} else {\n-\t\tbuffers_[stream] = buffer;\n+\t\tbuffers_[srcpad] = buffer;\n \t}\n }\n \n-GstBuffer *RequestWrap::detachBuffer(Stream *stream)\n+GstBuffer *RequestWrap::detachBuffer(GstPad *srcpad)\n {\n \tGstBuffer *buffer = nullptr;\n \n-\tauto item = buffers_.find(stream);\n+\tauto item = buffers_.find(srcpad);\n \tif (item != buffers_.end()) {\n \t\tbuffer = item->second;\n \t\titem->second = nullptr;\n@@ -189,7 +190,6 @@ int GstLibcameraSrcState::queueRequest()\n \t\tstd::make_unique<RequestWrap>(std::move(request));\n \n \tfor (GstPad *srcpad : srcpads_) {\n-\t\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n \t\tGstLibcameraPool *pool = gst_libcamera_pad_get_pool(srcpad);\n \t\tGstBuffer *buffer;\n \t\tGstFlowReturn ret;\n@@ -204,7 +204,7 @@ int GstLibcameraSrcState::queueRequest()\n \t\t\treturn -ENOBUFS;\n \t\t}\n \n-\t\twrap->attachBuffer(stream, buffer);\n+\t\twrap->attachBuffer(srcpad, buffer);\n \t}\n \n \tGST_TRACE_OBJECT(src_, \"Requesting buffers\");\n@@ -354,7 +354,7 @@ int GstLibcameraSrcState::processRequest()\n \tfor (gsize i = 0; i < srcpads_.size(); i++) {\n \t\tGstPad *srcpad = srcpads_[i];\n \t\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n-\t\tGstBuffer *buffer = wrap->detachBuffer(stream);\n+\t\tGstBuffer *buffer = wrap->detachBuffer(srcpad);\n \n \t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n \t\tconst StreamConfiguration &stream_cfg = stream->configuration();\n", "prefixes": [ "v4", "3/3" ] }