Patch Detail
Show a patch.
GET /api/patches/24953/?format=api
{ "id": 24953, "url": "https://patchwork.libcamera.org/api/patches/24953/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24953/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251103144755.438422-1-barnabas.pocze@ideasonboard.com>", "date": "2025-11-03T14:47:55", "name": "[v1] android: camera_hal_manager: Remove `cameraLocation()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d07982b360863e9060570b8a39614a72915e17c2", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24953/mbox/", "series": [ { "id": 5557, "url": "https://patchwork.libcamera.org/api/series/5557/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5557", "date": "2025-11-03T14:47:55", "name": "[v1] android: camera_hal_manager: Remove `cameraLocation()`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5557/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24953/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24953/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11506BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Nov 2025 14:48:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 460DD609D8;\n\tMon, 3 Nov 2025 15:48:01 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F3F8606A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 15:47:59 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A7E87CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 15:46:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jh78ht92\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762181166;\n\tbh=Y5cgqOHvfukGziZ5lwQeNaZKDG0kYHRnHzJHRApueHE=;\n\th=From:To:Subject:Date:From;\n\tb=Jh78ht924dmeqd1/rJEqfjrAHaxy0i2AbNqBUwn4/Us79PMRUEodOUq0Dy5aYDlTp\n\tE1p/cU/QSL8uDqhZVm+568dtXwuR4BTsSeelP+3Hd1Y/orFiwmeqefpAJfyP7x+LDH\n\tf8ifdf19d7d6ukHV75mq6k6EDivrWU/WOcssXIvk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] android: camera_hal_manager: Remove `cameraLocation()`", "Date": "Mon, 3 Nov 2025 15:47:55 +0100", "Message-ID": "<20251103144755.438422-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Inline the function as it is only used in a single place and does not do\nanything complicated. This also lets the `operator==` of `std::optional`\ntake care of the proper comparison instead of defaulting the value to -1\nand comparing that.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/android/camera_hal_manager.cpp | 7 +------\n src/android/camera_hal_manager.h | 2 --\n 2 files changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 7500c749be..a7a2571754 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -125,7 +125,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr<Camera> cam)\n \t\t * Now check if this is an external camera and assign\n \t\t * its id accordingly.\n \t\t */\n-\t\tif (cameraLocation(cam.get()) == properties::CameraLocationExternal) {\n+\t\tif (cam->properties().get(properties::Location) == properties::CameraLocationExternal) {\n \t\t\tisCameraExternal = true;\n \t\t\tid = nextExternalCameraId_;\n \t\t} else {\n@@ -227,11 +227,6 @@ void CameraHalManager::cameraRemoved(std::shared_ptr<Camera> cam)\n \tLOG(HAL, Debug) << \"Camera ID: \" << id << \" removed successfully.\";\n }\n \n-int32_t CameraHalManager::cameraLocation(const Camera *cam)\n-{\n-\treturn cam->properties().get(properties::Location).value_or(-1);\n-}\n-\n CameraDevice *CameraHalManager::cameraDeviceFromHalId(unsigned int id)\n {\n \tauto iter = std::find_if(cameras_.begin(), cameras_.end(),\ndiff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 836a8daf70..e2d4eacbb5 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -48,8 +48,6 @@ private:\n \n \tCameraHalManager();\n \n-\tstatic int32_t cameraLocation(const libcamera::Camera *cam);\n-\n \tvoid cameraAdded(std::shared_ptr<libcamera::Camera> cam);\n \tvoid cameraRemoved(std::shared_ptr<libcamera::Camera> cam);\n \n", "prefixes": [ "v1" ] }