Patch Detail
Show a patch.
GET /api/patches/24949/?format=api
{ "id": 24949, "url": "https://patchwork.libcamera.org/api/patches/24949/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24949/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251103140049.413881-1-barnabas.pocze@ideasonboard.com>", "date": "2025-11-03T14:00:49", "name": "[v1] ipa: libipa: agc_mean_luminance: Avoid unnecessary copies", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ddbcc9316223938fe5b6c0be617247a29f4c130d", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24949/mbox/", "series": [ { "id": 5555, "url": "https://patchwork.libcamera.org/api/series/5555/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5555", "date": "2025-11-03T14:00:49", "name": "[v1] ipa: libipa: agc_mean_luminance: Avoid unnecessary copies", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5555/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24949/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24949/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B675DC3241\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Nov 2025 14:00:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4F0A609D8;\n\tMon, 3 Nov 2025 15:00:55 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 841AA606A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 15:00:53 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D4D9C73\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Nov 2025 14:59:00 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QhMsLVg1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762178340;\n\tbh=nvpUT0NDmY4BcKpZ/eMdTgebnBm7OcYqpunHEipWxtA=;\n\th=From:To:Subject:Date:From;\n\tb=QhMsLVg1a0J2g5OzAzCWU55I+MqCAEo0e6xZ0/f3K21ZmHooAd1Ob0qNzICk0UfMn\n\txQLuUb3UDXi+Ki5jnsHxhRmDzXJD1WcwYhkuAISF+n1csE6chTPiuLENhbrNWxxR9z\n\t+CzlWAZx12FqxfTV/tWaYY1CCP5/dGKNiVHHE7yE=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] ipa: libipa: agc_mean_luminance: Avoid unnecessary copies", "Date": "Mon, 3 Nov 2025 15:00:49 +0100", "Message-ID": "<20251103140049.413881-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`constraintModes()` and `exposureModeHelpers()` need not return copies of\nthe internal objects, exposing const references is sufficient, so do that.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/libipa/agc_mean_luminance.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex d7ec548e3e..e5f164c318 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -53,12 +53,12 @@ public:\n \tvoid setLimits(utils::Duration minExposureTime, utils::Duration maxExposureTime,\n \t\t double minGain, double maxGain, std::vector<AgcConstraint> constraints);\n \n-\tstd::map<int32_t, std::vector<AgcConstraint>> constraintModes()\n+\tconst std::map<int32_t, std::vector<AgcConstraint>> &constraintModes() const\n \t{\n \t\treturn constraintModes_;\n \t}\n \n-\tstd::map<int32_t, std::shared_ptr<ExposureModeHelper>> exposureModeHelpers()\n+\tconst std::map<int32_t, std::shared_ptr<ExposureModeHelper>> &exposureModeHelpers() const\n \t{\n \t\treturn exposureModeHelpers_;\n \t}\n", "prefixes": [ "v1" ] }