Patch Detail
Show a patch.
GET /api/patches/24929/?format=api
{ "id": 24929, "url": "https://patchwork.libcamera.org/api/patches/24929/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24929/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251031095057.1181439-1-barnabas.pocze@ideasonboard.com>", "date": "2025-10-31T09:50:57", "name": "[RFC,v2] utils: checkstyle.py: Accept `Closes` commit trailer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "abe551e4d7f691ca83afc26341ae32ec4b60923d", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24929/mbox/", "series": [ { "id": 5547, "url": "https://patchwork.libcamera.org/api/series/5547/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5547", "date": "2025-10-31T09:50:57", "name": "[RFC,v2] utils: checkstyle.py: Accept `Closes` commit trailer", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5547/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24929/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24929/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64FFEBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 31 Oct 2025 09:51:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 295FE60971;\n\tFri, 31 Oct 2025 10:51:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABBEE606E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Oct 2025 10:51:01 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A892F1690;\n\tFri, 31 Oct 2025 10:49:10 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NYmsw7yP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761904150;\n\tbh=tHr0Zd/kpd33P5sSH7WmFaQhmcn8pMhsD/VfIL2oPvY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NYmsw7yPItoYojoeVoNUbzbC3b3bDsAHMXYfYehtA+3gcskLnG0wljp/laCUiYskC\n\t/cqdxwmMZsLpd+0DyKb2HC3AgJNP5VgLykT0JKEid1Wa2MwI7jx6N1LRJUC2RZ13hx\n\t6HqBiPpcvys1pw0mzoksbs0izvQ3gjht0sPN3xrI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[RFC PATCH v2] utils: checkstyle.py: Accept `Closes` commit trailer", "Date": "Fri, 31 Oct 2025 10:50:57 +0100", "Message-ID": "<20251031095057.1181439-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`Closes: <url>` is recognized by gitlab[0] and closes the referenced issue\nautomatically when a commit is made to the project's default branch. Now\nthat issues are hosted on gitlab, it will be the preferred way to reference\nthe fixed issue from a commit, so replace the previously used `Bug` with it\nin the checkstlye.py script.\n\n[0]: https://docs.gitlab.com/user/project/issues/managing_issues/#default-closing-pattern\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nchanges in v2:\n * remove `Bug`\n\nv1: https://patchwork.libcamera.org/patch/24888/\n---\nStill one potential question remains: should the url be restricted?\nI think it makes sense to allow arbitrary urls to support different\nbug trackers (e.g. rpi github).\n---\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.51.1", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex f6229bbd86..fa1355c173 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -541,7 +541,7 @@ class TrailersChecker(CommitChecker):\n\n known_trailers = {\n 'Acked-by': email_regex,\n- 'Bug': link_regex,\n+ 'Closes': link_regex,\n 'Co-developed-by': email_regex,\n 'Fixes': commit_regex,\n 'Link': link_regex,\n", "prefixes": [ "RFC", "v2" ] }