Patch Detail
Show a patch.
GET /api/patches/24914/?format=api
{ "id": 24914, "url": "https://patchwork.libcamera.org/api/patches/24914/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24914/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251030165816.1095180-12-barnabas.pocze@ideasonboard.com>", "date": "2025-10-30T16:58:05", "name": "[RFC,v3,11/22] libcamera: request: Store `MetadataList`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "60db69bec135ecd26d1aae9b98b6e4240cf1773e", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24914/mbox/", "series": [ { "id": 5545, "url": "https://patchwork.libcamera.org/api/series/5545/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5545", "date": "2025-10-30T16:57:54", "name": "libcamera: Add `MetadataList`", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5545/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24914/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24914/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01D93C32CE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Oct 2025 16:58:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 906EE6098E;\n\tThu, 30 Oct 2025 17:58:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A7EA60947\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Oct 2025 17:58:24 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E993918E5;\n\tThu, 30 Oct 2025 17:56:33 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZE2GtRmi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761843394;\n\tbh=SuOPzvKn2H326C+sircC2A8eH3QDwVNrhhGo1tYDfeQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZE2GtRmi+job4rNhcPSbjfGjiUBvRdKWHm7EbM5Lx6xaBywkb6do5325slZBKQXai\n\tmyytAWtN+Zhnt24KTnHwE/P5FVLAizn98ffeyo29rbautMSX6uhcIuUk+io7NPA0NU\n\tM/K7nwTIvVTXhSERH+Li69/S0+7lGap5d6Xy/jqo=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v3 11/22] libcamera: request: Store `MetadataList`", "Date": "Thu, 30 Oct 2025 17:58:05 +0100", "Message-ID": "<20251030165816.1095180-12-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1", "In-Reply-To": "<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>", "References": "<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a `MetadataList` to the `Request` object to store the metadata items\nreturned by the camera. The metadata list is initialized using the camera's\n`MetadataListPlan` object, which is supposed to be filled by the pipeline\nhandlers.\n\nThis new list is exposed as `metadata2`, and the old `ControlList` is\nstill present for now.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/request.h | 5 +++++\n src/libcamera/request.cpp | 2 ++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 0c5939f7b3..23e7bde72c 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -18,6 +18,7 @@\n \n #include <libcamera/controls.h>\n #include <libcamera/fence.h>\n+#include <libcamera/metadata_list.h>\n \n namespace libcamera {\n \n@@ -51,6 +52,9 @@ public:\n \n \tControlList &controls() { return *controls_; }\n \tControlList &metadata() { return *metadata_; }\n+#ifndef __DOXYGEN__\n+\t[[nodiscard]] MetadataList &metadata2() { return metadata2_; }\n+#endif\n \tconst BufferMap &buffers() const { return bufferMap_; }\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr<Fence> &&fence = {});\n@@ -69,6 +73,7 @@ private:\n \n \tControlList *controls_;\n \tControlList *metadata_;\n+\tMetadataList metadata2_;\n \tBufferMap bufferMap_;\n \n \tconst uint64_t cookie_;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 992d476e09..0ff465e6f7 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -357,6 +357,7 @@ void Request::Private::timeout()\n */\n Request::Request(Camera *camera, uint64_t cookie)\n \t: Extensible(std::make_unique<Private>(camera)),\n+\t metadata2_(camera->_d()->metadataPlan_),\n \t cookie_(cookie), status_(RequestPending)\n {\n \tcontrols_ = new ControlList(controls::controls,\n@@ -410,6 +411,7 @@ void Request::reuse(ReuseFlag flags)\n \n \tcontrols_->clear();\n \tmetadata_->clear();\n+\tmetadata2_.clear();\n }\n \n /**\n", "prefixes": [ "RFC", "v3", "11/22" ] }