Patch Detail
Show a patch.
GET /api/patches/24913/?format=api
{ "id": 24913, "url": "https://patchwork.libcamera.org/api/patches/24913/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24913/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251030165816.1095180-11-barnabas.pocze@ideasonboard.com>", "date": "2025-10-30T16:58:04", "name": "[RFC,v3,10/22] libcamera: camera: Store `MetadataListPlan` in `Camera::Private`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8b55b45b2e47dc7cb003e18bb2bfe325e46d4e32", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24913/mbox/", "series": [ { "id": 5545, "url": "https://patchwork.libcamera.org/api/series/5545/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5545", "date": "2025-10-30T16:57:54", "name": "libcamera: Add `MetadataList`", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5545/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24913/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24913/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 180E7C3331\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Oct 2025 16:58:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE13D60967;\n\tThu, 30 Oct 2025 17:58:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B73E060934\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Oct 2025 17:58:23 +0100 (CET)", "from pb-laptop.local (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9915B15D2;\n\tThu, 30 Oct 2025 17:56:33 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SeuW4F1c\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761843393;\n\tbh=IkO03SFMU6hCRMG1ItK9eiBRksIT39onlC8odA8a5dw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SeuW4F1cBT5jVv5LcYAlhJg0Soc7/bv93wk+df02deCyKn/+zNh5ZjRfkhlds70Fu\n\ti4IupyJTvZOYxJl3wlGf0nNCZ7grlwSpBMO7um3nxsLked5XNhrdHLkXrygWYX2V7S\n\tUKdX824ElC5yC3vcEjLl+DdYxUFy6OSfcSnRNDX4=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v3 10/22] libcamera: camera: Store `MetadataListPlan` in\n\t`Camera::Private`", "Date": "Thu, 30 Oct 2025 17:58:04 +0100", "Message-ID": "<20251030165816.1095180-11-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.1", "In-Reply-To": "<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>", "References": "<20251030165816.1095180-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Just like `ControlInfoMap controlInfo_` is a public member of the private\ncamera data for pipeline handlers to populate, add a `MetadataListPlan` as\nwell for the pipeline handlers to fill. This will be used to initialize\nthe `MetadataList` of each request created by the camera.\n\nAlso add `Camera::metadata()`, which makes it accessible for applications.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nchanges in v2:\n * make it available in `Camera::metadata()`\n---\n include/libcamera/camera.h | 2 ++\n include/libcamera/internal/camera.h | 2 ++\n src/libcamera/camera.cpp | 21 +++++++++++++++++++++\n 3 files changed, 25 insertions(+)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex b24a297400..53089282a4 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -31,6 +31,7 @@ class FrameBuffer;\n class FrameBufferAllocator;\n class PipelineHandler;\n class Request;\n+class MetadataListPlan;\n \n class SensorConfiguration\n {\n@@ -131,6 +132,7 @@ public:\n \n \tconst ControlInfoMap &controls() const;\n \tconst ControlList &properties() const;\n+\tconst MetadataListPlan &metadata() const;\n \n \tconst std::set<Stream *> &streams() const;\n \ndiff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 8a2e9ed589..016c1ae512 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -18,6 +18,7 @@\n #include <libcamera/base/class.h>\n \n #include <libcamera/camera.h>\n+#include <libcamera/metadata_list_plan.h>\n \n namespace libcamera {\n \n@@ -40,6 +41,7 @@ public:\n \tstd::queue<Request *> waitingRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n+\tMetadataListPlan metadataPlan_;\n \n \tuint32_t requestSequence_;\n \ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 2e1e146a25..7bfa50b52c 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -658,6 +658,14 @@ Camera::Private::~Private()\n * when creating the camera, and shall not be modified afterwards.\n */\n \n+/**\n+ * \\var Camera::Private::metadataPlan_\n+ * \\brief The set of metadata supported by the camera\n+ *\n+ * The metadata information shall be initialised by the pipeline handler when\n+ * creating the camera.\n+ */\n+\n /**\n * \\var Camera::Private::requestSequence_\n * \\brief The queuing sequence number of the request\n@@ -1074,6 +1082,19 @@ const ControlInfoMap &Camera::controls() const\n \treturn _d()->controlInfo_;\n }\n \n+/**\n+ * \\brief Retrieve the set of metadata supported by the camera\n+ *\n+ * The list of metadata controls that may be reported by the camera\n+ * for a \\ref Request::metadata() \"request\".\n+ *\n+ * \\return A MetadataListPlan listing the metadata controls supported by the camera\n+ */\n+const MetadataListPlan &Camera::metadata() const\n+{\n+\treturn _d()->metadataPlan_;\n+}\n+\n /**\n * \\brief Retrieve the list of properties of the camera\n *\n", "prefixes": [ "RFC", "v3", "10/22" ] }