Patch Detail
Show a patch.
GET /api/patches/24900/?format=api
{ "id": 24900, "url": "https://patchwork.libcamera.org/api/patches/24900/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24900/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251029172439.1513907-13-kieran.bingham@ideasonboard.com>", "date": "2025-10-29T17:24:37", "name": "[v2,12/13] ipa: rkisp1: cproc: Provide a Hue control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "68e646b1edbc8d4088e459ac18ce8e339951d450", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24900/mbox/", "series": [ { "id": 5544, "url": "https://patchwork.libcamera.org/api/series/5544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5544", "date": "2025-10-29T17:24:25", "name": "libipa: Introduce a Quantized type", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24900/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24900/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B6FCC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 Oct 2025 17:25:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 025DB608F3;\n\tWed, 29 Oct 2025 18:25:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B2B8608BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Oct 2025 18:24:49 +0100 (CET)", "from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01AF64FB7;\n\tWed, 29 Oct 2025 18:22:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LPUlsNDC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761758580;\n\tbh=l966tlqAt5TcMyFfQ13zq22CqD1lNDZDBsQfPsUjJa4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LPUlsNDCX30I99OUQPVzEt/CslsIwmPIdkE+ikbc7loNo9Z5rXwyY3KvBdPSbaO0e\n\tyZSvU5L5BOH84JeBWmuO98uuEyRLmOooBW5aKcrFP7gsYwXFNyq+9B4h6w7snPeugP\n\tCTaZ+N/zjFZXVHAhQ+nx1riEZFxK01eVBK/l6YP0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 12/13] ipa: rkisp1: cproc: Provide a Hue control", "Date": "Wed, 29 Oct 2025 17:24:37 +0000", "Message-ID": "<20251029172439.1513907-13-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.1", "In-Reply-To": "<20251029172439.1513907-1-kieran.bingham@ideasonboard.com>", "References": "<20251029172439.1513907-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The RKISP1 supports a configurable Hue as part of the colour processing\nunit (cproc).\n\nThis is implemented as a phase shift of the chrominance values between\n-90 and +87.188 degrees according to the datasheet however the type\nitself would imply that this is a range between -90 and 89.2969.\n\nImplement the new control converting to the hardware scale accordingly\nand report the applied control in the completed request metadata.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/cproc.cpp | 18 ++++++++++++++++++\n src/ipa/rkisp1/ipa_context.h | 3 +++\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\nindex 7475e6c1b609..5389882c1685 100644\n--- a/src/ipa/rkisp1/algorithms/cproc.cpp\n+++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n@@ -39,6 +39,7 @@ namespace {\n \n constexpr float kDefaultBrightness = 0.0f;\n constexpr float kDefaultContrast = 1.0f;\n+constexpr float kDefaultHue = 0.0f;\n constexpr float kDefaultSaturation = 1.0f;\n \n } /* namespace */\n@@ -53,6 +54,8 @@ int ColorProcessing::init(IPAContext &context,\n \n \tcmap[&controls::Brightness] = ControlInfo(-1.0f, 0.993f, kDefaultBrightness);\n \tcmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);\n+\tcmap[&controls::Hue] = ControlInfo(HueQ::TraitsType::min,\n+\t\t\t\t\t HueQ::TraitsType::max, kDefaultHue);\n \tcmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);\n \n \treturn 0;\n@@ -68,6 +71,7 @@ int ColorProcessing::configure(IPAContext &context,\n \n \tcproc.brightness = BrightnessQ(kDefaultBrightness);\n \tcproc.contrast = ContrastQ(kDefaultContrast);\n+\tcproc.hue = HueQ(kDefaultHue);\n \tcproc.saturation = SaturationQ(kDefaultSaturation);\n \n \treturn 0;\n@@ -109,6 +113,17 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \t\tLOG(RkISP1CProc, Debug) << \"Set contrast to \" << value.value();\n \t}\n \n+\tconst auto &hue = controls.get(controls::Hue);\n+\tif (hue) {\n+\t\tHueQ value = *hue;\n+\t\tif (cproc.hue != value) {\n+\t\t\tcproc.hue = value;\n+\t\t\tupdate = true;\n+\t\t}\n+\n+\t\tLOG(RkISP1CProc, Debug) << \"Set hue to \" << value.value();\n+\t}\n+\n \tconst auto saturation = controls.get(controls::Saturation);\n \tif (saturation) {\n \t\tSaturationQ value = *saturation;\n@@ -122,6 +137,7 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \n \tframeContext.cproc.brightness = cproc.brightness;\n \tframeContext.cproc.contrast = cproc.contrast;\n+\tframeContext.cproc.hue = cproc.hue;\n \tframeContext.cproc.saturation = cproc.saturation;\n \tframeContext.cproc.update = update;\n }\n@@ -142,6 +158,7 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n \tconfig.setEnabled(true);\n \tconfig->brightness = frameContext.cproc.brightness.quantized();\n \tconfig->contrast = frameContext.cproc.contrast.quantized();\n+\tconfig->hue = frameContext.cproc.hue.quantized();\n \tconfig->sat = frameContext.cproc.saturation.quantized();\n }\n \n@@ -154,6 +171,7 @@ void ColorProcessing::process([[maybe_unused]] IPAContext &context, [[maybe_unus\n {\n \tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n \tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n+\tmetadata.set(controls::Hue, frameContext.cproc.hue.value());\n \tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 0a5fb2769d31..a4badbfc0c36 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -37,6 +37,7 @@ namespace ipa::rkisp1 {\n /* Fixed point types used by CPROC */\n using BrightnessQ = Q1_7;\n using ContrastQ = UQ1_7;\n+using HueQ = Quantized<ScaledFixedPointQTraits<Q1_7::TraitsType, 90>>;\n using SaturationQ = UQ1_7;\n \n struct IPAHwSettings {\n@@ -124,6 +125,7 @@ struct IPAActiveState {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \t} cproc;\n \n@@ -178,6 +180,7 @@ struct IPAFrameContext : public FrameContext {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \n \t\tbool update;\n", "prefixes": [ "v2", "12/13" ] }