Patch Detail
Show a patch.
GET /api/patches/24886/?format=api
{ "id": 24886, "url": "https://patchwork.libcamera.org/api/patches/24886/?format=api", "web_url": "https://patchwork.libcamera.org/patch/24886/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251028211751.2761420-16-rui.wang@ideasonboard.com>", "date": "2025-10-28T21:17:49", "name": "[v1,16/17] ipa: rkisp1: algorithms: dpf: publish DPF metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c7276bb910c37d8b7228d4bf4ac29578956bdef2", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/24886/mbox/", "series": [ { "id": 5542, "url": "https://patchwork.libcamera.org/api/series/5542/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5542", "date": "2025-10-28T21:17:34", "name": "[v1,01/17] ipa: rkisp1: algorithms: add Denoise base class shell", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5542/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/24886/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/24886/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92B5BBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 21:19:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 504DB6086F;\n\tTue, 28 Oct 2025 22:19:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E2CC60808\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 22:19:07 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC7FEE1F;\n\tTue, 28 Oct 2025 22:17:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VAENglTG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761686238;\n\tbh=JPHlc3x2o23BpgvfoYpOddyjlh0IkwV1i6stakY1UFw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=VAENglTGD/W/7RUEC49PCMUpUqMqaCsVUgXGj1qt7g8jgIzglZ0DTpGNzLz0i245k\n\twJSjJUb1sWueL9UF0dt7uNfLs6Lig4OnEO7wHxIj8i2rrORShGdJOV7Z+s82ScX19z\n\tkPnrUhNXe0BYPhrKbRCo4n/+aDsfWQLMBdVXaSz4=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 16/17] ipa: rkisp1: algorithms: dpf: publish DPF metadata", "Date": "Tue, 28 Oct 2025 17:17:49 -0400", "Message-ID": "<20251028211751.2761420-16-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251028211751.2761420-1-rui.wang@ideasonboard.com>", "References": "<20251028211751.2761420-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement process() and fillMetadata() to publish DPF status and current\nconfiguration values in frame metadata. This allows applications to read\nback the active DPF settings.\n\nMetadata published every frame:\n- DpfIso: Current ISO value computed from AGC gains\n- DpfMode: Current mode (auto/manual)\n- DpfChannelStrengths: Active R/G/B strength values\n\nDeveloper mode metadata (when enabled):\n- DpfGreenSpatialCoefficients: Green spatial filter coefficients\n- DpfRedBlueSpatialCoefficients: RB spatial filter coefficients\n- DpfRbFilterSize: RB filter size (9x9 or 13x9)\n- DpfNoiseLevelLookupCoefficients: NLL coefficients\n- DpfNoiseLevelLookupScaleMode: NLL scale mode (linear/log)\n\nThe metadata acts as control reflection, showing applications what\nsettings are actually active in the hardware.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/denoise.h | 2 +\n src/ipa/rkisp1/algorithms/dpf.cpp | 58 +++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 6 +++\n 3 files changed, 66 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex 53a0b642..fdbf3445 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -62,6 +62,8 @@ protected:\n \n \tvirtual ControlInfoMap::Map getControlMap() const = 0;\n \n+\tvirtual void fillMetadata(IPAContext &context, IPAFrameContext &frameContext, ControlList &metadata) = 0;\n+\n private:\n \tbool manualMode_ = false; /**< Current manual/auto mode state */\n \tbool devMode_ = false; /**< Developer mode state for advanced controls */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 59c3559e..1d168d60 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -76,6 +76,10 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n \t\t\t<< \"DPF init: loaded \" << isoLevels_.size()\n \t\t\t<< \" ISO level(s) from tuning\";\n \t}\n+\n+\t// init controls value from Yaml\n+\tauto dpfMap = getControlMap();\n+\tcontext.ctrlMap.insert(dpfMap.begin(), dpfMap.end());\n \treturn 0;\n }\n \n@@ -665,6 +669,60 @@ void Dpf::prepareManualMode(IPAContext &context, const uint32_t frame,\n \t}\n }\n \n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::process\n+ */\n+void Dpf::process(IPAContext &context, const uint32_t frame [[maybe_unused]],\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats [[maybe_unused]],\n+\t\t ControlList &metadata)\n+{\n+\tfillMetadata(context, frameContext, metadata);\n+}\n+\n+void Dpf::fillMetadata(IPAContext &context, IPAFrameContext &frameContext, ControlList &metadata)\n+{\n+\tunsigned iso = computeIso(context, frameContext);\n+\tmetadata.set(controls::rkisp1::DpfIso, static_cast<int32_t>(iso));\n+\tmetadata.set(controls::rkisp1::DpfMode, isManualMode() ? controls::rkisp1::DpfModeManual : controls::rkisp1::DpfModeAuto);\n+\n+\t/* Publish current values every frame (acts like controls.set reflection). */\n+\n+\t/* Strength (R,G,B) - always available */\n+\tint32_t strength[3] = { (int32_t)strengthConfig_.r,\n+\t\t\t\t(int32_t)strengthConfig_.g,\n+\t\t\t\t(int32_t)strengthConfig_.b };\n+\tmetadata.set(controls::rkisp1::DpfChannelStrengths, Span<const int32_t, 3>(strength));\n+\n+\tif (isDevMode()) {\n+\t\t/* Advanced controls only in devmode */\n+\t\t/* Spatial kernels */\n+\t\tint32_t gCoeffs[RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS];\n+\t\tint32_t rbCoeffs[RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS];\n+\t\tfor (unsigned i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\t\tgCoeffs[i] = config_.g_flt.spatial_coeff[i];\n+\t\t\trbCoeffs[i] = config_.rb_flt.spatial_coeff[i];\n+\t\t}\n+\t\tmetadata.set(controls::rkisp1::DpfGreenSpatialCoefficients,\n+\t\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(gCoeffs));\n+\t\tmetadata.set(controls::rkisp1::DpfRedBlueSpatialCoefficients,\n+\t\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(rbCoeffs));\n+\n+\t\t/* RB filter size (0=9x9,1=13x9) */\n+\t\tint32_t fltSize = (config_.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9) ? 1 : 0;\n+\t\tmetadata.set(controls::rkisp1::DpfRbFilterSize, fltSize);\n+\n+\t\t/* NLL coefficients and scale */\n+\t\tint32_t nll[RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS];\n+\t\tfor (unsigned i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i)\n+\t\t\tnll[i] = config_.nll.coeff[i];\n+\t\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupCoefficients,\n+\t\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS>(nll));\n+\t\tint32_t scaleMode = (config_.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC) ? 1 : 0;\n+\t\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupScaleMode, scaleMode);\n+\t}\n+}\n+\n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n \n } /* namespace ipa::rkisp1::algorithms */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 5db50143..02f02869 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -30,6 +30,10 @@ public:\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t RkISP1Params *params) override;\n+\tvoid process(IPAContext &context, const uint32_t frame [[maybe_unused]],\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats [[maybe_unused]],\n+\t\t ControlList &metadata) override;\n \n private:\n \tstruct rkisp1_cif_isp_dpf_config config_ {\n@@ -113,6 +117,8 @@ private:\n \t\t\t IPAFrameContext &frameContext, RkISP1Params *params) override;\n \n \tControlInfoMap::Map getControlMap() const override;\n+\n+\tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext, ControlList &metadata) override;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n", "prefixes": [ "v1", "16/17" ] }